aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2014-11-16 13:00:06 -0500
committerGuenter Roeck <linux@roeck-us.net>2014-11-30 23:13:14 -0500
commit9cd892bcbe32fed1b78fe1b742d887ed2be1791d (patch)
treee3b855ea8883fce879c98dcc8bec7bdb116bc48a
parent8aefb93f09bf4464f6da8ee071edcede9517d4bf (diff)
hwmon: (nct6775) Add blank lines after declarations
checkpatch complains about WARNING: Missing a blank line after declarations Add missing blank lines. Also reorder variables length-wise where appropriate if a function header is touched anyway. Reviewed-by: Jean Delvare <jdelvare@suse.de> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
-rw-r--r--drivers/hwmon/nct6775.c30
1 files changed, 24 insertions, 6 deletions
diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
index c0dd307001c9..dc0df57200cd 100644
--- a/drivers/hwmon/nct6775.c
+++ b/drivers/hwmon/nct6775.c
@@ -1073,6 +1073,7 @@ static bool is_word_sized(struct nct6775_data *data, u16 reg)
1073static inline void nct6775_set_bank(struct nct6775_data *data, u16 reg) 1073static inline void nct6775_set_bank(struct nct6775_data *data, u16 reg)
1074{ 1074{
1075 u8 bank = reg >> 8; 1075 u8 bank = reg >> 8;
1076
1076 if (data->bank != bank) { 1077 if (data->bank != bank) {
1077 outb_p(NCT6775_REG_BANK, data->addr + ADDR_REG_OFFSET); 1078 outb_p(NCT6775_REG_BANK, data->addr + ADDR_REG_OFFSET);
1078 outb_p(bank, data->addr + DATA_REG_OFFSET); 1079 outb_p(bank, data->addr + DATA_REG_OFFSET);
@@ -1310,6 +1311,7 @@ static void nct6775_update_pwm(struct device *dev)
1310 if (!data->target_speed_tolerance[i] || 1311 if (!data->target_speed_tolerance[i] ||
1311 data->pwm_enable[i] == speed_cruise) { 1312 data->pwm_enable[i] == speed_cruise) {
1312 u8 t = fanmodecfg & 0x0f; 1313 u8 t = fanmodecfg & 0x0f;
1314
1313 if (data->REG_TOLERANCE_H) { 1315 if (data->REG_TOLERANCE_H) {
1314 t |= (nct6775_read_value(data, 1316 t |= (nct6775_read_value(data,
1315 data->REG_TOLERANCE_H[i]) & 0x70) >> 1; 1317 data->REG_TOLERANCE_H[i]) & 0x70) >> 1;
@@ -1484,6 +1486,7 @@ static struct nct6775_data *nct6775_update_device(struct device *dev)
1484 data->alarms = 0; 1486 data->alarms = 0;
1485 for (i = 0; i < NUM_REG_ALARM; i++) { 1487 for (i = 0; i < NUM_REG_ALARM; i++) {
1486 u8 alarm; 1488 u8 alarm;
1489
1487 if (!data->REG_ALARM[i]) 1490 if (!data->REG_ALARM[i])
1488 continue; 1491 continue;
1489 alarm = nct6775_read_value(data, data->REG_ALARM[i]); 1492 alarm = nct6775_read_value(data, data->REG_ALARM[i]);
@@ -1493,6 +1496,7 @@ static struct nct6775_data *nct6775_update_device(struct device *dev)
1493 data->beeps = 0; 1496 data->beeps = 0;
1494 for (i = 0; i < NUM_REG_BEEP; i++) { 1497 for (i = 0; i < NUM_REG_BEEP; i++) {
1495 u8 beep; 1498 u8 beep;
1499
1496 if (!data->REG_BEEP[i]) 1500 if (!data->REG_BEEP[i])
1497 continue; 1501 continue;
1498 beep = nct6775_read_value(data, data->REG_BEEP[i]); 1502 beep = nct6775_read_value(data, data->REG_BEEP[i]);
@@ -1515,8 +1519,9 @@ show_in_reg(struct device *dev, struct device_attribute *attr, char *buf)
1515{ 1519{
1516 struct nct6775_data *data = nct6775_update_device(dev); 1520 struct nct6775_data *data = nct6775_update_device(dev);
1517 struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr); 1521 struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr);
1518 int nr = sattr->nr;
1519 int index = sattr->index; 1522 int index = sattr->index;
1523 int nr = sattr->nr;
1524
1520 return sprintf(buf, "%ld\n", in_from_reg(data->in[nr][index], nr)); 1525 return sprintf(buf, "%ld\n", in_from_reg(data->in[nr][index], nr));
1521} 1526}
1522 1527
@@ -1526,10 +1531,12 @@ store_in_reg(struct device *dev, struct device_attribute *attr, const char *buf,
1526{ 1531{
1527 struct nct6775_data *data = dev_get_drvdata(dev); 1532 struct nct6775_data *data = dev_get_drvdata(dev);
1528 struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr); 1533 struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr);
1529 int nr = sattr->nr;
1530 int index = sattr->index; 1534 int index = sattr->index;
1535 int nr = sattr->nr;
1531 unsigned long val; 1536 unsigned long val;
1532 int err = kstrtoul(buf, 10, &val); 1537 int err;
1538
1539 err = kstrtoul(buf, 10, &val);
1533 if (err < 0) 1540 if (err < 0)
1534 return err; 1541 return err;
1535 mutex_lock(&data->update_lock); 1542 mutex_lock(&data->update_lock);
@@ -1546,6 +1553,7 @@ show_alarm(struct device *dev, struct device_attribute *attr, char *buf)
1546 struct nct6775_data *data = nct6775_update_device(dev); 1553 struct nct6775_data *data = nct6775_update_device(dev);
1547 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr); 1554 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);
1548 int nr = data->ALARM_BITS[sattr->index]; 1555 int nr = data->ALARM_BITS[sattr->index];
1556
1549 return sprintf(buf, "%u\n", 1557 return sprintf(buf, "%u\n",
1550 (unsigned int)((data->alarms >> nr) & 0x01)); 1558 (unsigned int)((data->alarms >> nr) & 0x01));
1551} 1559}
@@ -1581,6 +1589,7 @@ show_temp_alarm(struct device *dev, struct device_attribute *attr, char *buf)
1581 nr = find_temp_source(data, sattr->index, data->num_temp_alarms); 1589 nr = find_temp_source(data, sattr->index, data->num_temp_alarms);
1582 if (nr >= 0) { 1590 if (nr >= 0) {
1583 int bit = data->ALARM_BITS[nr + TEMP_ALARM_BASE]; 1591 int bit = data->ALARM_BITS[nr + TEMP_ALARM_BASE];
1592
1584 alarm = (data->alarms >> bit) & 0x01; 1593 alarm = (data->alarms >> bit) & 0x01;
1585 } 1594 }
1586 return sprintf(buf, "%u\n", alarm); 1595 return sprintf(buf, "%u\n", alarm);
@@ -1606,8 +1615,9 @@ store_beep(struct device *dev, struct device_attribute *attr, const char *buf,
1606 int nr = data->BEEP_BITS[sattr->index]; 1615 int nr = data->BEEP_BITS[sattr->index];
1607 int regindex = nr >> 3; 1616 int regindex = nr >> 3;
1608 unsigned long val; 1617 unsigned long val;
1618 int err;
1609 1619
1610 int err = kstrtoul(buf, 10, &val); 1620 err = kstrtoul(buf, 10, &val);
1611 if (err < 0) 1621 if (err < 0)
1612 return err; 1622 return err;
1613 if (val > 1) 1623 if (val > 1)
@@ -1640,6 +1650,7 @@ show_temp_beep(struct device *dev, struct device_attribute *attr, char *buf)
1640 nr = find_temp_source(data, sattr->index, data->num_temp_beeps); 1650 nr = find_temp_source(data, sattr->index, data->num_temp_beeps);
1641 if (nr >= 0) { 1651 if (nr >= 0) {
1642 int bit = data->BEEP_BITS[nr + TEMP_ALARM_BASE]; 1652 int bit = data->BEEP_BITS[nr + TEMP_ALARM_BASE];
1653
1643 beep = (data->beeps >> bit) & 0x01; 1654 beep = (data->beeps >> bit) & 0x01;
1644 } 1655 }
1645 return sprintf(buf, "%u\n", beep); 1656 return sprintf(buf, "%u\n", beep);
@@ -1653,8 +1664,9 @@ store_temp_beep(struct device *dev, struct device_attribute *attr,
1653 struct nct6775_data *data = dev_get_drvdata(dev); 1664 struct nct6775_data *data = dev_get_drvdata(dev);
1654 int nr, bit, regindex; 1665 int nr, bit, regindex;
1655 unsigned long val; 1666 unsigned long val;
1667 int err;
1656 1668
1657 int err = kstrtoul(buf, 10, &val); 1669 err = kstrtoul(buf, 10, &val);
1658 if (err < 0) 1670 if (err < 0)
1659 return err; 1671 return err;
1660 if (val > 1) 1672 if (val > 1)
@@ -1726,6 +1738,7 @@ show_fan(struct device *dev, struct device_attribute *attr, char *buf)
1726 struct nct6775_data *data = nct6775_update_device(dev); 1738 struct nct6775_data *data = nct6775_update_device(dev);
1727 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr); 1739 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);
1728 int nr = sattr->index; 1740 int nr = sattr->index;
1741
1729 return sprintf(buf, "%d\n", data->rpm[nr]); 1742 return sprintf(buf, "%d\n", data->rpm[nr]);
1730} 1743}
1731 1744
@@ -1735,6 +1748,7 @@ show_fan_min(struct device *dev, struct device_attribute *attr, char *buf)
1735 struct nct6775_data *data = nct6775_update_device(dev); 1748 struct nct6775_data *data = nct6775_update_device(dev);
1736 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr); 1749 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);
1737 int nr = sattr->index; 1750 int nr = sattr->index;
1751
1738 return sprintf(buf, "%d\n", 1752 return sprintf(buf, "%d\n",
1739 data->fan_from_reg_min(data->fan_min[nr], 1753 data->fan_from_reg_min(data->fan_min[nr],
1740 data->fan_div[nr])); 1754 data->fan_div[nr]));
@@ -1746,6 +1760,7 @@ show_fan_div(struct device *dev, struct device_attribute *attr, char *buf)
1746 struct nct6775_data *data = nct6775_update_device(dev); 1760 struct nct6775_data *data = nct6775_update_device(dev);
1747 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr); 1761 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);
1748 int nr = sattr->index; 1762 int nr = sattr->index;
1763
1749 return sprintf(buf, "%u\n", div_from_reg(data->fan_div[nr])); 1764 return sprintf(buf, "%u\n", div_from_reg(data->fan_div[nr]));
1750} 1765}
1751 1766
@@ -1757,9 +1772,9 @@ store_fan_min(struct device *dev, struct device_attribute *attr,
1757 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr); 1772 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);
1758 int nr = sattr->index; 1773 int nr = sattr->index;
1759 unsigned long val; 1774 unsigned long val;
1760 int err;
1761 unsigned int reg; 1775 unsigned int reg;
1762 u8 new_div; 1776 u8 new_div;
1777 int err;
1763 1778
1764 err = kstrtoul(buf, 10, &val); 1779 err = kstrtoul(buf, 10, &val);
1765 if (err < 0) 1780 if (err < 0)
@@ -1943,6 +1958,7 @@ show_temp_label(struct device *dev, struct device_attribute *attr, char *buf)
1943 struct nct6775_data *data = nct6775_update_device(dev); 1958 struct nct6775_data *data = nct6775_update_device(dev);
1944 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr); 1959 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);
1945 int nr = sattr->index; 1960 int nr = sattr->index;
1961
1946 return sprintf(buf, "%s\n", data->temp_label[data->temp_src[nr]]); 1962 return sprintf(buf, "%s\n", data->temp_label[data->temp_src[nr]]);
1947} 1963}
1948 1964
@@ -2019,6 +2035,7 @@ show_temp_type(struct device *dev, struct device_attribute *attr, char *buf)
2019 struct nct6775_data *data = nct6775_update_device(dev); 2035 struct nct6775_data *data = nct6775_update_device(dev);
2020 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr); 2036 struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);
2021 int nr = sattr->index; 2037 int nr = sattr->index;
2038
2022 return sprintf(buf, "%d\n", (int)data->temp_type[nr]); 2039 return sprintf(buf, "%d\n", (int)data->temp_type[nr]);
2023} 2040}
2024 2041
@@ -3009,6 +3026,7 @@ static ssize_t
3009show_vid(struct device *dev, struct device_attribute *attr, char *buf) 3026show_vid(struct device *dev, struct device_attribute *attr, char *buf)
3010{ 3027{
3011 struct nct6775_data *data = dev_get_drvdata(dev); 3028 struct nct6775_data *data = dev_get_drvdata(dev);
3029
3012 return sprintf(buf, "%d\n", vid_from_reg(data->vid, data->vrm)); 3030 return sprintf(buf, "%d\n", vid_from_reg(data->vid, data->vrm));
3013} 3031}
3014 3032