diff options
| author | Peter Hurley <peter@hurleysoftware.com> | 2011-07-24 00:10:46 -0400 |
|---|---|---|
| committer | Gustavo F. Padovan <padovan@profusion.mobi> | 2011-08-11 18:50:26 -0400 |
| commit | 9be4e3fbf2d3603e7a7010ede0697166738a788b (patch) | |
| tree | 112840ba9fe3d0712531875293d2b3a17a7f6158 | |
| parent | 950e2d51e866623e4c360280aa63b85ab66d3403 (diff) | |
Bluetooth: Fix lost wakeups waiting for sock state change
Fix race conditions which can cause lost wakeups while waiting
for sock state to change.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
| -rw-r--r-- | net/bluetooth/af_bluetooth.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c index 8add9b499912..117e0d161780 100644 --- a/net/bluetooth/af_bluetooth.c +++ b/net/bluetooth/af_bluetooth.c | |||
| @@ -494,9 +494,8 @@ int bt_sock_wait_state(struct sock *sk, int state, unsigned long timeo) | |||
| 494 | BT_DBG("sk %p", sk); | 494 | BT_DBG("sk %p", sk); |
| 495 | 495 | ||
| 496 | add_wait_queue(sk_sleep(sk), &wait); | 496 | add_wait_queue(sk_sleep(sk), &wait); |
| 497 | set_current_state(TASK_INTERRUPTIBLE); | ||
| 497 | while (sk->sk_state != state) { | 498 | while (sk->sk_state != state) { |
| 498 | set_current_state(TASK_INTERRUPTIBLE); | ||
| 499 | |||
| 500 | if (!timeo) { | 499 | if (!timeo) { |
| 501 | err = -EINPROGRESS; | 500 | err = -EINPROGRESS; |
| 502 | break; | 501 | break; |
| @@ -510,12 +509,13 @@ int bt_sock_wait_state(struct sock *sk, int state, unsigned long timeo) | |||
| 510 | release_sock(sk); | 509 | release_sock(sk); |
| 511 | timeo = schedule_timeout(timeo); | 510 | timeo = schedule_timeout(timeo); |
| 512 | lock_sock(sk); | 511 | lock_sock(sk); |
| 512 | set_current_state(TASK_INTERRUPTIBLE); | ||
| 513 | 513 | ||
| 514 | err = sock_error(sk); | 514 | err = sock_error(sk); |
| 515 | if (err) | 515 | if (err) |
| 516 | break; | 516 | break; |
| 517 | } | 517 | } |
| 518 | set_current_state(TASK_RUNNING); | 518 | __set_current_state(TASK_RUNNING); |
| 519 | remove_wait_queue(sk_sleep(sk), &wait); | 519 | remove_wait_queue(sk_sleep(sk), &wait); |
| 520 | return err; | 520 | return err; |
| 521 | } | 521 | } |
