diff options
author | Markus Elfring <elfring@users.sourceforge.net> | 2015-02-03 14:12:25 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-02-04 23:29:47 -0500 |
commit | 9b55669c14212f89dba39a2d8e00c1ec1d44c1ec (patch) | |
tree | c3b1051a8d55dc71b216c608fe1fa9be50bc1326 | |
parent | f339664c0be145b381c788bc0d5c07fbe1dd9d85 (diff) |
NetCP: Deletion of unnecessary checks before two function calls
The functions cpsw_ale_destroy() and of_dev_put() test whether their argument
is NULL and then return immediately. Thus the test around the call
is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/ti/netcp_ethss.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethernet/ti/netcp_ethss.c index 345cd2563772..84f5ce525750 100644 --- a/drivers/net/ethernet/ti/netcp_ethss.c +++ b/drivers/net/ethernet/ti/netcp_ethss.c | |||
@@ -2011,12 +2011,10 @@ static int gbe_probe(struct netcp_device *netcp_device, struct device *dev, | |||
2011 | quit: | 2011 | quit: |
2012 | if (gbe_dev->hw_stats) | 2012 | if (gbe_dev->hw_stats) |
2013 | devm_kfree(dev, gbe_dev->hw_stats); | 2013 | devm_kfree(dev, gbe_dev->hw_stats); |
2014 | if (gbe_dev->ale) | 2014 | cpsw_ale_destroy(gbe_dev->ale); |
2015 | cpsw_ale_destroy(gbe_dev->ale); | ||
2016 | if (gbe_dev->ss_regs) | 2015 | if (gbe_dev->ss_regs) |
2017 | devm_iounmap(dev, gbe_dev->ss_regs); | 2016 | devm_iounmap(dev, gbe_dev->ss_regs); |
2018 | if (interfaces) | 2017 | of_node_put(interfaces); |
2019 | of_node_put(interfaces); | ||
2020 | devm_kfree(dev, gbe_dev); | 2018 | devm_kfree(dev, gbe_dev); |
2021 | return ret; | 2019 | return ret; |
2022 | } | 2020 | } |