diff options
author | James Hogan <james.hogan@imgtec.com> | 2013-02-13 06:20:27 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-02-13 11:52:04 -0500 |
commit | 99d5851eefe589346c976a4b539ee498267bc5fd (patch) | |
tree | 9b56c9c0f956a08b6ed47950d85c9ab824fda48a | |
parent | c6d14ff11bec4c02601be198c84a5c76d1af90fc (diff) |
net: skbuff: fix compile error in skb_panic()
I get the following build error on next-20130213 due to the following
commit:
commit f05de73bf82fbbc00265c06d12efb7273f7dc54a ("skbuff: create
skb_panic() function and its wrappers").
It adds an argument called panic to a function that uses the BUG() macro
which tries to call panic, but the argument masks the panic() function
declaration, resulting in the following error (gcc 4.2.4):
net/core/skbuff.c In function 'skb_panic':
net/core/skbuff.c +126 : error: called object 'panic' is not a function
This is fixed by renaming the argument to msg.
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Jean Sacren <sakiwit@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/core/skbuff.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 8731c39b7a54..21a22cce6e53 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c | |||
@@ -109,7 +109,7 @@ static const struct pipe_buf_operations sock_pipe_buf_ops = { | |||
109 | * @skb: buffer | 109 | * @skb: buffer |
110 | * @sz: size | 110 | * @sz: size |
111 | * @addr: address | 111 | * @addr: address |
112 | * @panic: skb_over_panic or skb_under_panic | 112 | * @msg: skb_over_panic or skb_under_panic |
113 | * | 113 | * |
114 | * Out-of-line support for skb_put() and skb_push(). | 114 | * Out-of-line support for skb_put() and skb_push(). |
115 | * Called via the wrapper skb_over_panic() or skb_under_panic(). | 115 | * Called via the wrapper skb_over_panic() or skb_under_panic(). |
@@ -117,10 +117,10 @@ static const struct pipe_buf_operations sock_pipe_buf_ops = { | |||
117 | * __builtin_return_address is not used because it is not always reliable. | 117 | * __builtin_return_address is not used because it is not always reliable. |
118 | */ | 118 | */ |
119 | static void skb_panic(struct sk_buff *skb, unsigned int sz, void *addr, | 119 | static void skb_panic(struct sk_buff *skb, unsigned int sz, void *addr, |
120 | const char panic[]) | 120 | const char msg[]) |
121 | { | 121 | { |
122 | pr_emerg("%s: text:%p len:%d put:%d head:%p data:%p tail:%#lx end:%#lx dev:%s\n", | 122 | pr_emerg("%s: text:%p len:%d put:%d head:%p data:%p tail:%#lx end:%#lx dev:%s\n", |
123 | panic, addr, skb->len, sz, skb->head, skb->data, | 123 | msg, addr, skb->len, sz, skb->head, skb->data, |
124 | (unsigned long)skb->tail, (unsigned long)skb->end, | 124 | (unsigned long)skb->tail, (unsigned long)skb->end, |
125 | skb->dev ? skb->dev->name : "<NULL>"); | 125 | skb->dev ? skb->dev->name : "<NULL>"); |
126 | BUG(); | 126 | BUG(); |