diff options
author | Nicolas Palix <npalix@diku.dk> | 2010-08-24 11:39:05 -0400 |
---|---|---|
committer | Michal Marek <mmarek@suse.cz> | 2010-08-31 05:37:53 -0400 |
commit | 998f5523230a8a837809f942d556360f69121677 (patch) | |
tree | 8a6ef3b1d199ff4e7361f44a969cafaeb2424547 | |
parent | 43ba21b57a3e757000bfa8ccf46c81f232b4d881 (diff) |
Coccinelle: Add api/kstrdup.cocci
Use kstrdup rather than duplicating its implementation
Signed-off-by: Nicolas Palix <npalix@diku.dk>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Michal Marek <mmarek@suse.cz>
-rw-r--r-- | scripts/coccinelle/api/kstrdup.cocci | 39 |
1 files changed, 39 insertions, 0 deletions
diff --git a/scripts/coccinelle/api/kstrdup.cocci b/scripts/coccinelle/api/kstrdup.cocci new file mode 100644 index 000000000000..e0805ad08d39 --- /dev/null +++ b/scripts/coccinelle/api/kstrdup.cocci | |||
@@ -0,0 +1,39 @@ | |||
1 | /// Use kstrdup rather than duplicating its implementation | ||
2 | /// | ||
3 | // Confidence: High | ||
4 | // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2. | ||
5 | // Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2. | ||
6 | // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2. | ||
7 | // URL: http://coccinelle.lip6.fr/ | ||
8 | // Comments: | ||
9 | // Options: -no_includes -include_headers | ||
10 | |||
11 | virtual patch | ||
12 | |||
13 | @@ | ||
14 | expression from,to; | ||
15 | expression flag,E1,E2; | ||
16 | statement S; | ||
17 | @@ | ||
18 | |||
19 | - to = kmalloc(strlen(from) + 1,flag); | ||
20 | + to = kstrdup(from, flag); | ||
21 | ... when != \(from = E1 \| to = E1 \) | ||
22 | if (to==NULL || ...) S | ||
23 | ... when != \(from = E2 \| to = E2 \) | ||
24 | - strcpy(to, from); | ||
25 | |||
26 | @@ | ||
27 | expression x,from,to; | ||
28 | expression flag,E1,E2,E3; | ||
29 | statement S; | ||
30 | @@ | ||
31 | |||
32 | - x = strlen(from) + 1; | ||
33 | ... when != \( x = E1 \| from = E1 \) | ||
34 | - to = \(kmalloc\|kzalloc\)(x,flag); | ||
35 | + to = kstrdup(from, flag); | ||
36 | ... when != \(x = E2 \| from = E2 \| to = E2 \) | ||
37 | if (to==NULL || ...) S | ||
38 | ... when != \(x = E3 \| from = E3 \| to = E3 \) | ||
39 | - memcpy(to, from, x); | ||