diff options
| author | Pekka Enberg <penberg@kernel.org> | 2011-08-09 15:54:18 -0400 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2011-08-09 14:23:08 -0400 |
| commit | 981c1252691f4b855f2bb47ea93fb6052ea3aee2 (patch) | |
| tree | 7cb1acf6cbaf11c1baf3a474c891a4798a8bbcda | |
| parent | 580cabed88ebc631e740b16010f2fa6ba882652f (diff) | |
perf symbols: Check '/tmp/perf-' symbol file ownership
The external symbol files are generated by JIT compilers, for example, but we
need to make sure they're ours before injecting them to 'perf report'.
Requested-by: Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1312919658-17158-1-git-send-email-penberg@kernel.org
Signed-off-by: Pekka Enberg <penberg@kernel.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
| -rw-r--r-- | tools/perf/util/symbol.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index eec196329fd9..a8b53714542a 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c | |||
| @@ -1504,6 +1504,17 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter) | |||
| 1504 | dso->adjust_symbols = 0; | 1504 | dso->adjust_symbols = 0; |
| 1505 | 1505 | ||
| 1506 | if (strncmp(dso->name, "/tmp/perf-", 10) == 0) { | 1506 | if (strncmp(dso->name, "/tmp/perf-", 10) == 0) { |
| 1507 | struct stat st; | ||
| 1508 | |||
| 1509 | if (stat(dso->name, &st) < 0) | ||
| 1510 | return -1; | ||
| 1511 | |||
| 1512 | if (st.st_uid && (st.st_uid != geteuid())) { | ||
| 1513 | pr_warning("File %s not owned by current user or root, " | ||
| 1514 | "ignoring it.\n", dso->name); | ||
| 1515 | return -1; | ||
| 1516 | } | ||
| 1517 | |||
| 1507 | ret = dso__load_perf_map(dso, map, filter); | 1518 | ret = dso__load_perf_map(dso, map, filter); |
| 1508 | dso->symtab_type = ret > 0 ? SYMTAB__JAVA_JIT : | 1519 | dso->symtab_type = ret > 0 ? SYMTAB__JAVA_JIT : |
| 1509 | SYMTAB__NOT_FOUND; | 1520 | SYMTAB__NOT_FOUND; |
