diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2010-09-29 06:36:22 -0400 |
---|---|---|
committer | Chris Wilson <chris@chris-wilson.co.uk> | 2010-09-29 06:41:18 -0400 |
commit | 97d1ebaf81491afd8b45186056eda7ebf5da7875 (patch) | |
tree | 4ba884bc19b532dfedb607e9c702c04b913588ab | |
parent | f573c66061184ce28196a22229b6214256ceacd8 (diff) |
drm/i915/debug: Remove defunct WATCH_LRU
This has bitrotted through inuse and superseded by tracing and debugfs.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
-rw-r--r-- | drivers/gpu/drm/i915/i915_drv.h | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/i915_gem.c | 16 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/i915_gem_debug.c | 35 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/i915_gem_evict.c | 3 |
4 files changed, 0 insertions, 56 deletions
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 0ce76a82a675..703b8c92bdfa 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h | |||
@@ -77,7 +77,6 @@ enum plane { | |||
77 | #define WATCH_COHERENCY 0 | 77 | #define WATCH_COHERENCY 0 |
78 | #define WATCH_BUF 0 | 78 | #define WATCH_BUF 0 |
79 | #define WATCH_EXEC 0 | 79 | #define WATCH_EXEC 0 |
80 | #define WATCH_LRU 0 | ||
81 | #define WATCH_RELOC 0 | 80 | #define WATCH_RELOC 0 |
82 | #define WATCH_INACTIVE 0 | 81 | #define WATCH_INACTIVE 0 |
83 | #define WATCH_PWRITE 0 | 82 | #define WATCH_PWRITE 0 |
@@ -1089,7 +1088,6 @@ void i915_verify_inactive(struct drm_device *dev, char *file, int line); | |||
1089 | void i915_gem_object_check_coherency(struct drm_gem_object *obj, int handle); | 1088 | void i915_gem_object_check_coherency(struct drm_gem_object *obj, int handle); |
1090 | void i915_gem_dump_object(struct drm_gem_object *obj, int len, | 1089 | void i915_gem_dump_object(struct drm_gem_object *obj, int len, |
1091 | const char *where, uint32_t mark); | 1090 | const char *where, uint32_t mark); |
1092 | void i915_dump_lru(struct drm_device *dev, const char *where); | ||
1093 | 1091 | ||
1094 | /* i915_debugfs.c */ | 1092 | /* i915_debugfs.c */ |
1095 | int i915_debugfs_init(struct drm_minor *minor); | 1093 | int i915_debugfs_init(struct drm_minor *minor); |
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 81513fa5d303..5ce14f188c43 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c | |||
@@ -1865,12 +1865,6 @@ i915_gem_retire_requests_ring(struct drm_device *dev, | |||
1865 | break; | 1865 | break; |
1866 | 1866 | ||
1867 | obj = &obj_priv->base; | 1867 | obj = &obj_priv->base; |
1868 | |||
1869 | #if WATCH_LRU | ||
1870 | DRM_INFO("%s: retire %d moves to inactive list %p\n", | ||
1871 | __func__, request->seqno, obj); | ||
1872 | #endif | ||
1873 | |||
1874 | if (obj->write_domain != 0) | 1868 | if (obj->write_domain != 0) |
1875 | i915_gem_object_move_to_flushing(obj); | 1869 | i915_gem_object_move_to_flushing(obj); |
1876 | else | 1870 | else |
@@ -2646,9 +2640,6 @@ i915_gem_object_bind_to_gtt(struct drm_gem_object *obj, unsigned alignment) | |||
2646 | /* If the gtt is empty and we're still having trouble | 2640 | /* If the gtt is empty and we're still having trouble |
2647 | * fitting our object in, we're out of memory. | 2641 | * fitting our object in, we're out of memory. |
2648 | */ | 2642 | */ |
2649 | #if WATCH_LRU | ||
2650 | DRM_INFO("%s: GTT full, evicting something\n", __func__); | ||
2651 | #endif | ||
2652 | ret = i915_gem_evict_something(dev, obj->size, alignment); | 2643 | ret = i915_gem_evict_something(dev, obj->size, alignment); |
2653 | if (ret) | 2644 | if (ret) |
2654 | return ret; | 2645 | return ret; |
@@ -3950,18 +3941,11 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data, | |||
3950 | obj_priv = to_intel_bo(obj); | 3941 | obj_priv = to_intel_bo(obj); |
3951 | 3942 | ||
3952 | i915_gem_object_move_to_active(obj, ring); | 3943 | i915_gem_object_move_to_active(obj, ring); |
3953 | #if WATCH_LRU | ||
3954 | DRM_INFO("%s: move to exec list %p\n", __func__, obj); | ||
3955 | #endif | ||
3956 | } | 3944 | } |
3957 | 3945 | ||
3958 | i915_add_request(dev, file_priv, request, ring); | 3946 | i915_add_request(dev, file_priv, request, ring); |
3959 | request = NULL; | 3947 | request = NULL; |
3960 | 3948 | ||
3961 | #if WATCH_LRU | ||
3962 | i915_dump_lru(dev, __func__); | ||
3963 | #endif | ||
3964 | |||
3965 | i915_verify_inactive(dev, __FILE__, __LINE__); | 3949 | i915_verify_inactive(dev, __FILE__, __LINE__); |
3966 | 3950 | ||
3967 | err: | 3951 | err: |
diff --git a/drivers/gpu/drm/i915/i915_gem_debug.c b/drivers/gpu/drm/i915/i915_gem_debug.c index 80f380b1d951..26e67ee7f85d 100644 --- a/drivers/gpu/drm/i915/i915_gem_debug.c +++ b/drivers/gpu/drm/i915/i915_gem_debug.c | |||
@@ -97,41 +97,6 @@ i915_gem_dump_object(struct drm_gem_object *obj, int len, | |||
97 | } | 97 | } |
98 | #endif | 98 | #endif |
99 | 99 | ||
100 | #if WATCH_LRU | ||
101 | void | ||
102 | i915_dump_lru(struct drm_device *dev, const char *where) | ||
103 | { | ||
104 | drm_i915_private_t *dev_priv = dev->dev_private; | ||
105 | struct drm_i915_gem_object *obj_priv; | ||
106 | |||
107 | DRM_INFO("active list %s {\n", where); | ||
108 | spin_lock(&dev_priv->mm.active_list_lock); | ||
109 | list_for_each_entry(obj_priv, &dev_priv->mm.active_list, | ||
110 | list) | ||
111 | { | ||
112 | DRM_INFO(" %p: %08x\n", obj_priv, | ||
113 | obj_priv->last_rendering_seqno); | ||
114 | } | ||
115 | spin_unlock(&dev_priv->mm.active_list_lock); | ||
116 | DRM_INFO("}\n"); | ||
117 | DRM_INFO("flushing list %s {\n", where); | ||
118 | list_for_each_entry(obj_priv, &dev_priv->mm.flushing_list, | ||
119 | list) | ||
120 | { | ||
121 | DRM_INFO(" %p: %08x\n", obj_priv, | ||
122 | obj_priv->last_rendering_seqno); | ||
123 | } | ||
124 | DRM_INFO("}\n"); | ||
125 | DRM_INFO("inactive %s {\n", where); | ||
126 | list_for_each_entry(obj_priv, &dev_priv->mm.inactive_list, list) { | ||
127 | DRM_INFO(" %p: %08x\n", obj_priv, | ||
128 | obj_priv->last_rendering_seqno); | ||
129 | } | ||
130 | DRM_INFO("}\n"); | ||
131 | } | ||
132 | #endif | ||
133 | |||
134 | |||
135 | #if WATCH_COHERENCY | 100 | #if WATCH_COHERENCY |
136 | void | 101 | void |
137 | i915_gem_object_check_coherency(struct drm_gem_object *obj, int handle) | 102 | i915_gem_object_check_coherency(struct drm_gem_object *obj, int handle) |
diff --git a/drivers/gpu/drm/i915/i915_gem_evict.c b/drivers/gpu/drm/i915/i915_gem_evict.c index 63ac3d2ba52c..c503c81f4cdf 100644 --- a/drivers/gpu/drm/i915/i915_gem_evict.c +++ b/drivers/gpu/drm/i915/i915_gem_evict.c | |||
@@ -190,9 +190,6 @@ found: | |||
190 | /* Unbinding will emit any required flushes */ | 190 | /* Unbinding will emit any required flushes */ |
191 | list_for_each_entry_safe(obj_priv, tmp_obj_priv, | 191 | list_for_each_entry_safe(obj_priv, tmp_obj_priv, |
192 | &eviction_list, evict_list) { | 192 | &eviction_list, evict_list) { |
193 | #if WATCH_LRU | ||
194 | DRM_INFO("%s: evicting %p\n", __func__, &obj_priv->base); | ||
195 | #endif | ||
196 | ret = i915_gem_object_unbind(&obj_priv->base); | 193 | ret = i915_gem_object_unbind(&obj_priv->base); |
197 | if (ret) | 194 | if (ret) |
198 | return ret; | 195 | return ret; |