diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-09-19 08:05:45 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-10-01 01:45:02 -0400 |
commit | 955382f3895f644855b56893067b1b23c63893dd (patch) | |
tree | ea57cfcbaf7cde856424528b084f05baecc9a54e | |
parent | a1e2265332e9344f913811ac6d2b84a506195bd8 (diff) |
drm/i915: Ditch INTELFB_CONN_LIMIT
And the gratious overallocation of crtcs. Seems to go back to the ums
days of yonder ...
We also still need it to make the fbdev emulation happy, but I don't
think there's really a need. Especially since the current fbdev
emulation doesn't actually support cloning.
v2: Use sizeof(*pointer) pattern (Jani).
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r-- | drivers/gpu/drm/i915/intel_display.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_drv.h | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_fb.c | 2 |
3 files changed, 2 insertions, 3 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index d93da9c8cfb9..6aaa84d56624 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c | |||
@@ -9591,7 +9591,7 @@ static void intel_crtc_init(struct drm_device *dev, int pipe) | |||
9591 | struct intel_crtc *intel_crtc; | 9591 | struct intel_crtc *intel_crtc; |
9592 | int i; | 9592 | int i; |
9593 | 9593 | ||
9594 | intel_crtc = kzalloc(sizeof(struct intel_crtc) + (INTELFB_CONN_LIMIT * sizeof(struct drm_connector *)), GFP_KERNEL); | 9594 | intel_crtc = kzalloc(sizeof(*intel_crtc), GFP_KERNEL); |
9595 | if (intel_crtc == NULL) | 9595 | if (intel_crtc == NULL) |
9596 | return; | 9596 | return; |
9597 | 9597 | ||
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 4b75328462ed..fb38ef10ac5d 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h | |||
@@ -77,7 +77,6 @@ | |||
77 | /* the i915, i945 have a single sDVO i2c bus - which is different */ | 77 | /* the i915, i945 have a single sDVO i2c bus - which is different */ |
78 | #define MAX_OUTPUTS 6 | 78 | #define MAX_OUTPUTS 6 |
79 | /* maximum connectors per crtcs in the mode set */ | 79 | /* maximum connectors per crtcs in the mode set */ |
80 | #define INTELFB_CONN_LIMIT 4 | ||
81 | 80 | ||
82 | #define INTEL_I2C_BUS_DVO 1 | 81 | #define INTEL_I2C_BUS_DVO 1 |
83 | #define INTEL_I2C_BUS_SDVO 2 | 82 | #define INTEL_I2C_BUS_SDVO 2 |
diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c index 6aa66aaceaef..7ceb69b9dd61 100644 --- a/drivers/gpu/drm/i915/intel_fb.c +++ b/drivers/gpu/drm/i915/intel_fb.c | |||
@@ -225,7 +225,7 @@ int intel_fbdev_init(struct drm_device *dev) | |||
225 | 225 | ||
226 | ret = drm_fb_helper_init(dev, &ifbdev->helper, | 226 | ret = drm_fb_helper_init(dev, &ifbdev->helper, |
227 | INTEL_INFO(dev)->num_pipes, | 227 | INTEL_INFO(dev)->num_pipes, |
228 | INTELFB_CONN_LIMIT); | 228 | 4); |
229 | if (ret) { | 229 | if (ret) { |
230 | kfree(ifbdev); | 230 | kfree(ifbdev); |
231 | return ret; | 231 | return ret; |