aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJavier Martinez Canillas <javier.martinez@collabora.co.uk>2013-07-02 15:46:30 -0400
committerLinus Walleij <linus.walleij@linaro.org>2013-07-20 12:57:28 -0400
commit949eb1a4d29dc75e0b5b16b03747886b52ecf854 (patch)
tree2fd7925d5265058c7d3df1fce3b3a60a44d995a6
parentb4419e1a15905191661ffe75ba2f9e649f5d565e (diff)
gpio/omap: fix build error when OF_GPIO is not defined.
The OMAP GPIO driver check if the chip has an associated Device Tree node using the struct gpio_chip of_node member. But this is only build if CONFIG_OF_GPIO is defined which leads to the following error when using omap1_defconfig: linux/drivers/gpio/gpio-omap.c: In function 'omap_gpio_chip_init': linux/drivers/gpio/gpio-omap.c:1080:17: error: 'struct gpio_chip' has no member named 'of_node' linux/drivers/gpio/gpio-omap.c: In function 'omap_gpio_irq_map': linux/drivers/gpio/gpio-omap.c:1116:16: error: 'struct gpio_chip' has no member named 'of_node' Reported-by: Kevin Hilman <khilman@linaro.org> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/gpio/gpio-omap.c16
1 files changed, 14 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 3a0c1606f885..c57244ef428b 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1037,6 +1037,18 @@ omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start,
1037 IRQ_NOREQUEST | IRQ_NOPROBE, 0); 1037 IRQ_NOREQUEST | IRQ_NOPROBE, 0);
1038} 1038}
1039 1039
1040#if defined(CONFIG_OF_GPIO)
1041static inline bool omap_gpio_chip_boot_dt(struct gpio_chip *chip)
1042{
1043 return chip->of_node != NULL;
1044}
1045#else
1046static inline bool omap_gpio_chip_boot_dt(struct gpio_chip *chip)
1047{
1048 return false;
1049}
1050#endif
1051
1040static void omap_gpio_chip_init(struct gpio_bank *bank) 1052static void omap_gpio_chip_init(struct gpio_bank *bank)
1041{ 1053{
1042 int j; 1054 int j;
@@ -1077,7 +1089,7 @@ static void omap_gpio_chip_init(struct gpio_bank *bank)
1077 * irq_create_of_mapping() only for the GPIO lines that 1089 * irq_create_of_mapping() only for the GPIO lines that
1078 * are used as interrupts. 1090 * are used as interrupts.
1079 */ 1091 */
1080 if (!bank->chip.of_node) 1092 if (!omap_gpio_chip_boot_dt(&bank->chip))
1081 for (j = 0; j < bank->width; j++) 1093 for (j = 0; j < bank->width; j++)
1082 irq_create_mapping(bank->domain, j); 1094 irq_create_mapping(bank->domain, j);
1083 irq_set_chained_handler(bank->irq, gpio_irq_handler); 1095 irq_set_chained_handler(bank->irq, gpio_irq_handler);
@@ -1113,7 +1125,7 @@ static int omap_gpio_irq_map(struct irq_domain *d, unsigned int virq,
1113 * but until then this has to be done on a per driver 1125 * but until then this has to be done on a per driver
1114 * basis. Remove this once this is managed by the core. 1126 * basis. Remove this once this is managed by the core.
1115 */ 1127 */
1116 if (bank->chip.of_node) { 1128 if (omap_gpio_chip_boot_dt(&bank->chip)) {
1117 gpio = irq_to_gpio(bank, hwirq); 1129 gpio = irq_to_gpio(bank, hwirq);
1118 ret = gpio_request_one(gpio, GPIOF_IN, NULL); 1130 ret = gpio_request_one(gpio, GPIOF_IN, NULL);
1119 if (ret) { 1131 if (ret) {