diff options
| author | Grant Likely <grant.likely@secretlab.ca> | 2011-04-28 16:27:21 -0400 |
|---|---|---|
| committer | Grant Likely <grant.likely@secretlab.ca> | 2011-05-23 11:30:20 -0400 |
| commit | 93c02ab40ae6e06cb24d14845d9f008fdd24f43d (patch) | |
| tree | a8caf072ce7409eceb8178e952b7536bbd289460 | |
| parent | 6291319d4864848efc7b5d81389e2404fb478cb9 (diff) | |
arm/dt: probe for platforms via the device tree
If a dtb is passed to the kernel then the kernel needs to iterate
through compiled-in mdescs looking for one that matches and move the
dtb data to a safe location before it gets accidentally overwritten by
the kernel.
This patch creates a new function, setup_machine_fdt() which is
analogous to the setup_machine_atags() created in the previous patch.
It does all the early setup needed to use a device tree machine
description.
v5: - Print warning with neither dtb nor atags are passed to the kernel
- Fix bug in setting of __machine_arch_type to the selected machine,
not just the last machine in the list.
Reported-by: Tixy <tixy@yxit.co.uk>
- Copy command line directly into boot_command_line instead of cmd_line
v4: - Dump some output when a matching machine_desc cannot be found
v3: - Added processing of reserved list.
- Backed out the v2 change that copied instead of reserved the
dtb. dtb is reserved again and the real problem was fixed by
using alloc_bootmem_align() for early allocation of RAM for
unflattening the tree.
- Moved cmd_line and initrd changes to earlier patch to make series
bisectable.
v2: Changed to save the dtb by copying into an allocated buffer.
- Since the dtb will very likely be passed in the first 16k of ram
where the interrupt vectors live, memblock_reserve() is
insufficient to protect the dtb data.
[based on work originally written by Jeremy Kerr <jeremy.kerr@canonical.com>]
Tested-by: Tony Lindgren <tony@atomide.com>
Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
| -rw-r--r-- | arch/arm/include/asm/mach/arch.h | 2 | ||||
| -rw-r--r-- | arch/arm/include/asm/prom.h | 12 | ||||
| -rw-r--r-- | arch/arm/include/asm/setup.h | 2 | ||||
| -rw-r--r-- | arch/arm/kernel/devtree.c | 98 | ||||
| -rw-r--r-- | arch/arm/kernel/setup.c | 23 | ||||
| -rw-r--r-- | arch/arm/mm/init.c | 2 |
6 files changed, 135 insertions, 4 deletions
diff --git a/arch/arm/include/asm/mach/arch.h b/arch/arm/include/asm/mach/arch.h index 4764e67fb93d..946f4d778f71 100644 --- a/arch/arm/include/asm/mach/arch.h +++ b/arch/arm/include/asm/mach/arch.h | |||
| @@ -18,6 +18,8 @@ struct machine_desc { | |||
| 18 | unsigned int nr; /* architecture number */ | 18 | unsigned int nr; /* architecture number */ |
| 19 | const char *name; /* architecture name */ | 19 | const char *name; /* architecture name */ |
| 20 | unsigned long boot_params; /* tagged list */ | 20 | unsigned long boot_params; /* tagged list */ |
| 21 | const char **dt_compat; /* array of device tree | ||
| 22 | * 'compatible' strings */ | ||
| 21 | 23 | ||
| 22 | unsigned int nr_irqs; /* number of IRQs */ | 24 | unsigned int nr_irqs; /* number of IRQs */ |
| 23 | 25 | ||
diff --git a/arch/arm/include/asm/prom.h b/arch/arm/include/asm/prom.h index 8f1037fdc08f..11b8708fc4db 100644 --- a/arch/arm/include/asm/prom.h +++ b/arch/arm/include/asm/prom.h | |||
| @@ -21,5 +21,17 @@ static inline void irq_dispose_mapping(unsigned int virq) | |||
| 21 | return; | 21 | return; |
| 22 | } | 22 | } |
| 23 | 23 | ||
| 24 | extern struct machine_desc *setup_machine_fdt(unsigned int dt_phys); | ||
| 25 | extern void arm_dt_memblock_reserve(void); | ||
| 26 | |||
| 27 | #else /* CONFIG_OF */ | ||
| 28 | |||
| 29 | static inline struct machine_desc *setup_machine_fdt(unsigned int dt_phys) | ||
| 30 | { | ||
| 31 | return NULL; | ||
| 32 | } | ||
| 33 | |||
| 34 | static inline void arm_dt_memblock_reserve(void) { } | ||
| 35 | |||
| 24 | #endif /* CONFIG_OF */ | 36 | #endif /* CONFIG_OF */ |
| 25 | #endif /* ASMARM_PROM_H */ | 37 | #endif /* ASMARM_PROM_H */ |
diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h index 93b4702ffa0f..ee2ad8ae07af 100644 --- a/arch/arm/include/asm/setup.h +++ b/arch/arm/include/asm/setup.h | |||
| @@ -218,6 +218,8 @@ extern struct meminfo meminfo; | |||
| 218 | #define bank_phys_size(bank) (bank)->size | 218 | #define bank_phys_size(bank) (bank)->size |
| 219 | 219 | ||
| 220 | extern int arm_add_memory(phys_addr_t start, unsigned long size); | 220 | extern int arm_add_memory(phys_addr_t start, unsigned long size); |
| 221 | extern void early_print(const char *str, ...); | ||
| 222 | extern void dump_machine_table(void); | ||
| 221 | 223 | ||
| 222 | #endif /* __KERNEL__ */ | 224 | #endif /* __KERNEL__ */ |
| 223 | 225 | ||
diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c index 75e3df85b88c..a701e4226a6c 100644 --- a/arch/arm/kernel/devtree.c +++ b/arch/arm/kernel/devtree.c | |||
| @@ -21,6 +21,8 @@ | |||
| 21 | 21 | ||
| 22 | #include <asm/setup.h> | 22 | #include <asm/setup.h> |
| 23 | #include <asm/page.h> | 23 | #include <asm/page.h> |
| 24 | #include <asm/mach/arch.h> | ||
| 25 | #include <asm/mach-types.h> | ||
| 24 | 26 | ||
| 25 | void __init early_init_dt_add_memory_arch(u64 base, u64 size) | 27 | void __init early_init_dt_add_memory_arch(u64 base, u64 size) |
| 26 | { | 28 | { |
| @@ -32,6 +34,102 @@ void * __init early_init_dt_alloc_memory_arch(u64 size, u64 align) | |||
| 32 | return alloc_bootmem_align(size, align); | 34 | return alloc_bootmem_align(size, align); |
| 33 | } | 35 | } |
| 34 | 36 | ||
| 37 | void __init arm_dt_memblock_reserve(void) | ||
| 38 | { | ||
| 39 | u64 *reserve_map, base, size; | ||
| 40 | |||
| 41 | if (!initial_boot_params) | ||
| 42 | return; | ||
| 43 | |||
| 44 | /* Reserve the dtb region */ | ||
| 45 | memblock_reserve(virt_to_phys(initial_boot_params), | ||
| 46 | be32_to_cpu(initial_boot_params->totalsize)); | ||
| 47 | |||
| 48 | /* | ||
| 49 | * Process the reserve map. This will probably overlap the initrd | ||
| 50 | * and dtb locations which are already reserved, but overlaping | ||
| 51 | * doesn't hurt anything | ||
| 52 | */ | ||
| 53 | reserve_map = ((void*)initial_boot_params) + | ||
| 54 | be32_to_cpu(initial_boot_params->off_mem_rsvmap); | ||
| 55 | while (1) { | ||
| 56 | base = be64_to_cpup(reserve_map++); | ||
| 57 | size = be64_to_cpup(reserve_map++); | ||
| 58 | if (!size) | ||
| 59 | break; | ||
| 60 | memblock_reserve(base, size); | ||
| 61 | } | ||
| 62 | } | ||
| 63 | |||
| 64 | /** | ||
| 65 | * setup_machine_fdt - Machine setup when an dtb was passed to the kernel | ||
| 66 | * @dt_phys: physical address of dt blob | ||
| 67 | * | ||
| 68 | * If a dtb was passed to the kernel in r2, then use it to choose the | ||
| 69 | * correct machine_desc and to setup the system. | ||
| 70 | */ | ||
| 71 | struct machine_desc * __init setup_machine_fdt(unsigned int dt_phys) | ||
| 72 | { | ||
| 73 | struct boot_param_header *devtree; | ||
| 74 | struct machine_desc *mdesc, *mdesc_best = NULL; | ||
| 75 | unsigned int score, mdesc_score = ~1; | ||
| 76 | unsigned long dt_root; | ||
| 77 | const char *model; | ||
| 78 | |||
| 79 | devtree = phys_to_virt(dt_phys); | ||
| 80 | |||
| 81 | /* check device tree validity */ | ||
| 82 | if (be32_to_cpu(devtree->magic) != OF_DT_HEADER) | ||
| 83 | return NULL; | ||
| 84 | |||
| 85 | /* Search the mdescs for the 'best' compatible value match */ | ||
| 86 | initial_boot_params = devtree; | ||
| 87 | dt_root = of_get_flat_dt_root(); | ||
| 88 | for_each_machine_desc(mdesc) { | ||
| 89 | score = of_flat_dt_match(dt_root, mdesc->dt_compat); | ||
| 90 | if (score > 0 && score < mdesc_score) { | ||
| 91 | mdesc_best = mdesc; | ||
| 92 | mdesc_score = score; | ||
| 93 | } | ||
| 94 | } | ||
| 95 | if (!mdesc_best) { | ||
| 96 | const char *prop; | ||
| 97 | long size; | ||
| 98 | |||
| 99 | early_print("\nError: unrecognized/unsupported " | ||
| 100 | "device tree compatible list:\n[ "); | ||
| 101 | |||
| 102 | prop = of_get_flat_dt_prop(dt_root, "compatible", &size); | ||
| 103 | while (size > 0) { | ||
| 104 | early_print("'%s' ", prop); | ||
| 105 | size -= strlen(prop) + 1; | ||
| 106 | prop += strlen(prop) + 1; | ||
| 107 | } | ||
| 108 | early_print("]\n\n"); | ||
| 109 | |||
| 110 | dump_machine_table(); /* does not return */ | ||
| 111 | } | ||
| 112 | |||
| 113 | model = of_get_flat_dt_prop(dt_root, "model", NULL); | ||
| 114 | if (!model) | ||
| 115 | model = of_get_flat_dt_prop(dt_root, "compatible", NULL); | ||
| 116 | if (!model) | ||
| 117 | model = "<unknown>"; | ||
| 118 | pr_info("Machine: %s, model: %s\n", mdesc_best->name, model); | ||
| 119 | |||
| 120 | /* Retrieve various information from the /chosen node */ | ||
| 121 | of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line); | ||
| 122 | /* Initialize {size,address}-cells info */ | ||
| 123 | of_scan_flat_dt(early_init_dt_scan_root, NULL); | ||
| 124 | /* Setup memory, calling early_init_dt_add_memory_arch */ | ||
| 125 | of_scan_flat_dt(early_init_dt_scan_memory, NULL); | ||
| 126 | |||
| 127 | /* Change machine number to match the mdesc we're using */ | ||
| 128 | __machine_arch_type = mdesc_best->nr; | ||
| 129 | |||
| 130 | return mdesc_best; | ||
| 131 | } | ||
| 132 | |||
| 35 | /** | 133 | /** |
| 36 | * irq_create_of_mapping - Hook to resolve OF irq specifier into a Linux irq# | 134 | * irq_create_of_mapping - Hook to resolve OF irq specifier into a Linux irq# |
| 37 | * | 135 | * |
diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c index 42c2f0cedf1b..05db25ef3dd5 100644 --- a/arch/arm/kernel/setup.c +++ b/arch/arm/kernel/setup.c | |||
| @@ -20,6 +20,7 @@ | |||
| 20 | #include <linux/screen_info.h> | 20 | #include <linux/screen_info.h> |
| 21 | #include <linux/init.h> | 21 | #include <linux/init.h> |
| 22 | #include <linux/kexec.h> | 22 | #include <linux/kexec.h> |
| 23 | #include <linux/of_fdt.h> | ||
| 23 | #include <linux/crash_dump.h> | 24 | #include <linux/crash_dump.h> |
| 24 | #include <linux/root_dev.h> | 25 | #include <linux/root_dev.h> |
| 25 | #include <linux/cpu.h> | 26 | #include <linux/cpu.h> |
| @@ -42,6 +43,7 @@ | |||
| 42 | #include <asm/cachetype.h> | 43 | #include <asm/cachetype.h> |
| 43 | #include <asm/tlbflush.h> | 44 | #include <asm/tlbflush.h> |
| 44 | 45 | ||
| < | |||
