diff options
author | Steven Rostedt <srostedt@redhat.com> | 2010-11-08 16:35:48 -0500 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2010-11-18 11:23:10 -0500 |
commit | 9386c6ab7a33044d9907b00fc80976292bb02c2d (patch) | |
tree | 8648611eb32002e523d7ffa73ee8e103e5f5880f | |
parent | dc89568884ae1b8b96ca6fffe83b404ae472750e (diff) |
ktest: Use oldnoconfig instead of yes command
Running the command "yes ''" through the make oldconfig may enable
things we do not want enabled. If something is default enabled, the
yes command with '' as an argument will enable it.
Use oldnoconfig, which runs everything as if 'no' was used.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
-rw-r--r-- | tools/testing/ktest/ktest.pl | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index a7e86e391172..5bd00755727c 100644 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl | |||
@@ -694,7 +694,6 @@ sub check_buildlog { | |||
694 | sub build { | 694 | sub build { |
695 | my ($type) = @_; | 695 | my ($type) = @_; |
696 | my $defconfig = ""; | 696 | my $defconfig = ""; |
697 | my $append = ""; | ||
698 | 697 | ||
699 | unlink $buildlog; | 698 | unlink $buildlog; |
700 | 699 | ||
@@ -707,7 +706,7 @@ sub build { | |||
707 | 706 | ||
708 | # old config can ask questions | 707 | # old config can ask questions |
709 | if ($type eq "oldconfig") { | 708 | if ($type eq "oldconfig") { |
710 | $append = "yes ''|"; | 709 | $type = "oldnoconfig"; |
711 | 710 | ||
712 | # allow for empty configs | 711 | # allow for empty configs |
713 | run_command "touch $outputdir/.config"; | 712 | run_command "touch $outputdir/.config"; |
@@ -737,7 +736,7 @@ sub build { | |||
737 | $defconfig = "KCONFIG_ALLCONFIG=$minconfig"; | 736 | $defconfig = "KCONFIG_ALLCONFIG=$minconfig"; |
738 | } | 737 | } |
739 | 738 | ||
740 | run_command "$append $defconfig $make $type" or | 739 | run_command "$defconfig $make $type" or |
741 | dodie "failed make config"; | 740 | dodie "failed make config"; |
742 | 741 | ||
743 | $redirect = "$buildlog"; | 742 | $redirect = "$buildlog"; |