diff options
author | Balbir Singh <balbir@linux.vnet.ibm.com> | 2007-10-29 19:26:32 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2007-10-29 19:26:32 -0400 |
commit | 9301899be75b464ef097f0b5af7af6d9bd8f68a7 (patch) | |
tree | a7053c5c0babcdbad6d4baff0551d60e5c4308af | |
parent | 82798a17ad40df827d465329a20ace80497f9b32 (diff) |
sched: fix /proc/<PID>/stat stime/utime monotonicity, part 2
Extend Peter's patch to fix accounting issues, by keeping stime
monotonic too.
Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Tested-by: Frans Pop <elendil@planet.nl>
-rw-r--r-- | fs/proc/array.c | 3 | ||||
-rw-r--r-- | include/linux/sched.h | 2 | ||||
-rw-r--r-- | kernel/fork.c | 1 |
3 files changed, 4 insertions, 2 deletions
diff --git a/fs/proc/array.c b/fs/proc/array.c index d80baaabf835..eba339ecba27 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c | |||
@@ -374,7 +374,8 @@ static cputime_t task_stime(struct task_struct *p) | |||
374 | stime = nsec_to_clock_t(p->se.sum_exec_runtime) - | 374 | stime = nsec_to_clock_t(p->se.sum_exec_runtime) - |
375 | cputime_to_clock_t(task_utime(p)); | 375 | cputime_to_clock_t(task_utime(p)); |
376 | 376 | ||
377 | return clock_t_to_cputime(stime); | 377 | p->prev_stime = max(p->prev_stime, clock_t_to_cputime(stime)); |
378 | return p->prev_stime; | ||
378 | } | 379 | } |
379 | #endif | 380 | #endif |
380 | 381 | ||
diff --git a/include/linux/sched.h b/include/linux/sched.h index b0b1fe6e0b17..155d7438f7ad 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h | |||
@@ -1009,7 +1009,7 @@ struct task_struct { | |||
1009 | unsigned int rt_priority; | 1009 | unsigned int rt_priority; |
1010 | cputime_t utime, stime, utimescaled, stimescaled; | 1010 | cputime_t utime, stime, utimescaled, stimescaled; |
1011 | cputime_t gtime; | 1011 | cputime_t gtime; |
1012 | cputime_t prev_utime; | 1012 | cputime_t prev_utime, prev_stime; |
1013 | unsigned long nvcsw, nivcsw; /* context switch counts */ | 1013 | unsigned long nvcsw, nivcsw; /* context switch counts */ |
1014 | struct timespec start_time; /* monotonic time */ | 1014 | struct timespec start_time; /* monotonic time */ |
1015 | struct timespec real_start_time; /* boot based time */ | 1015 | struct timespec real_start_time; /* boot based time */ |
diff --git a/kernel/fork.c b/kernel/fork.c index a65bfc47177c..28a740151988 100644 --- a/kernel/fork.c +++ b/kernel/fork.c | |||
@@ -1057,6 +1057,7 @@ static struct task_struct *copy_process(unsigned long clone_flags, | |||
1057 | p->utimescaled = cputime_zero; | 1057 | p->utimescaled = cputime_zero; |
1058 | p->stimescaled = cputime_zero; | 1058 | p->stimescaled = cputime_zero; |
1059 | p->prev_utime = cputime_zero; | 1059 | p->prev_utime = cputime_zero; |
1060 | p->prev_stime = cputime_zero; | ||
1060 | 1061 | ||
1061 | #ifdef CONFIG_TASK_XACCT | 1062 | #ifdef CONFIG_TASK_XACCT |
1062 | p->rchar = 0; /* I/O counter: bytes read */ | 1063 | p->rchar = 0; /* I/O counter: bytes read */ |