aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Pugliese <thomas.pugliese@gmail.com>2014-02-28 22:54:37 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-02-28 23:23:03 -0500
commit927c4dac34cf465089b8d3ff570147ae3ce1a984 (patch)
treec84b57578b83baad0e0eed76922a742aa2ca300b
parent23c058201fe36adf1a225281739b3ec31ec4e858 (diff)
usb: wusbcore: fix compile warnings
Fix "pointer targets differ in signedness" and "variable set but not used" warnings Signed-off-by: Thomas Pugliese <thomas.pugliese@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/wusbcore/devconnect.c4
-rw-r--r--drivers/usb/wusbcore/wa-xfer.c6
2 files changed, 3 insertions, 7 deletions
diff --git a/drivers/usb/wusbcore/devconnect.c b/drivers/usb/wusbcore/devconnect.c
index 3b959e83b28e..0677139c6065 100644
--- a/drivers/usb/wusbcore/devconnect.c
+++ b/drivers/usb/wusbcore/devconnect.c
@@ -284,7 +284,7 @@ void wusbhc_devconnect_ack(struct wusbhc *wusbhc, struct wusb_dn_connect *dnc,
284 struct device *dev = wusbhc->dev; 284 struct device *dev = wusbhc->dev;
285 struct wusb_dev *wusb_dev; 285 struct wusb_dev *wusb_dev;
286 struct wusb_port *port; 286 struct wusb_port *port;
287 unsigned idx, devnum; 287 unsigned idx;
288 288
289 mutex_lock(&wusbhc->mutex); 289 mutex_lock(&wusbhc->mutex);
290 290
@@ -312,8 +312,6 @@ void wusbhc_devconnect_ack(struct wusbhc *wusbhc, struct wusb_dn_connect *dnc,
312 goto error_unlock; 312 goto error_unlock;
313 } 313 }
314 314
315 devnum = idx + 2;
316
317 /* Make sure we are using no crypto on that "virtual port" */ 315 /* Make sure we are using no crypto on that "virtual port" */
318 wusbhc->set_ptk(wusbhc, idx, 0, NULL, 0); 316 wusbhc->set_ptk(wusbhc, idx, 0, NULL, 0);
319 317
diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c
index 0636206f75ab..404ce81b286c 100644
--- a/drivers/usb/wusbcore/wa-xfer.c
+++ b/drivers/usb/wusbcore/wa-xfer.c
@@ -1007,7 +1007,7 @@ static void wa_seg_tr_cb(struct urb *urb)
1007 */ 1007 */
1008static struct scatterlist *wa_xfer_create_subset_sg(struct scatterlist *in_sg, 1008static struct scatterlist *wa_xfer_create_subset_sg(struct scatterlist *in_sg,
1009 const unsigned int bytes_transferred, 1009 const unsigned int bytes_transferred,
1010 const unsigned int bytes_to_transfer, unsigned int *out_num_sgs) 1010 const unsigned int bytes_to_transfer, int *out_num_sgs)
1011{ 1011{
1012 struct scatterlist *out_sg; 1012 struct scatterlist *out_sg;
1013 unsigned int bytes_processed = 0, offset_into_current_page_data = 0, 1013 unsigned int bytes_processed = 0, offset_into_current_page_data = 0,
@@ -1161,14 +1161,13 @@ static int __wa_populate_dto_urb(struct wa_xfer *xfer,
1161 */ 1161 */
1162static int __wa_xfer_setup_segs(struct wa_xfer *xfer, size_t xfer_hdr_size) 1162static int __wa_xfer_setup_segs(struct wa_xfer *xfer, size_t xfer_hdr_size)
1163{ 1163{
1164 int result, cnt, iso_frame_offset; 1164 int result, cnt, isoc_frame_offset = 0;
1165 size_t alloc_size = sizeof(*xfer->seg[0]) 1165 size_t alloc_size = sizeof(*xfer->seg[0])
1166 - sizeof(xfer->seg[0]->xfer_hdr) + xfer_hdr_size; 1166 - sizeof(xfer->seg[0]->xfer_hdr) + xfer_hdr_size;
1167 struct usb_device *usb_dev = xfer->wa->usb_dev; 1167 struct usb_device *usb_dev = xfer->wa->usb_dev;
1168 const struct usb_endpoint_descriptor *dto_epd = xfer->wa->dto_epd; 1168 const struct usb_endpoint_descriptor *dto_epd = xfer->wa->dto_epd;
1169 struct wa_seg *seg; 1169 struct wa_seg *seg;
1170 size_t buf_itr, buf_size, buf_itr_size; 1170 size_t buf_itr, buf_size, buf_itr_size;
1171 int isoc_frame_offset = 0;
1172 1171
1173 result = -ENOMEM; 1172 result = -ENOMEM;
1174 xfer->seg = kcalloc(xfer->segs, sizeof(xfer->seg[0]), GFP_ATOMIC); 1173 xfer->seg = kcalloc(xfer->segs, sizeof(xfer->seg[0]), GFP_ATOMIC);
@@ -1176,7 +1175,6 @@ static int __wa_xfer_setup_segs(struct wa_xfer *xfer, size_t xfer_hdr_size)
1176 goto error_segs_kzalloc; 1175 goto error_segs_kzalloc;
1177 buf_itr = 0; 1176 buf_itr = 0;
1178 buf_size = xfer->urb->transfer_buffer_length; 1177 buf_size = xfer->urb->transfer_buffer_length;
1179 iso_frame_offset = 0;
1180 for (cnt = 0; cnt < xfer->segs; cnt++) { 1178 for (cnt = 0; cnt < xfer->segs; cnt++) {
1181 size_t iso_pkt_descr_size = 0; 1179 size_t iso_pkt_descr_size = 0;
1182 int seg_isoc_frame_count = 0, seg_isoc_size = 0; 1180 int seg_isoc_frame_count = 0, seg_isoc_size = 0;