diff options
author | Németh Márton <nm127@freemail.hu> | 2009-04-29 14:57:24 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-06-16 17:20:58 -0400 |
commit | 925d74ae717c9a12d3618eb4b36b9fb632e2cef3 (patch) | |
tree | 29ed0bfccb473e9e1eafeb115989190898a4aed3 | |
parent | 3e9a489743ea87663e9ff638cb9b8fe13805a327 (diff) |
V4L/DVB (11736): videobuf: modify return value of VIDIOC_REQBUFS ioctl
The V4L2 ioctls usually return 0 when the operation was successful
and -1 in case of error. Currently VIDIOC_REQBUFS returns the
number of buffers which is redundant because this information is
available in count field of struct v4l2_requestbuffers. The
V4L2 API specification, revision 0.24 [1] explicitly specifies for
VIDIOC_REQBUFS that the return value shall be 0 on success.
The patch was tested with v4l-test 0.13 [2] with vivi driver.
References:
[1] V4L2 API specification, revision 0.24
http://v4l2spec.bytesex.org/spec/r13696.htm
[2] v4l-test: Test environment for Video For Linux Two API
http://v4l-test.sourceforge.net/
Signed-off-by: Márton Németh <nm127@freemail.hu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r-- | drivers/media/video/videobuf-core.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/video/videobuf-core.c b/drivers/media/video/videobuf-core.c index b7b05842cf28..29b3c693a8e4 100644 --- a/drivers/media/video/videobuf-core.c +++ b/drivers/media/video/videobuf-core.c | |||
@@ -439,6 +439,7 @@ int videobuf_reqbufs(struct videobuf_queue *q, | |||
439 | } | 439 | } |
440 | 440 | ||
441 | req->count = retval; | 441 | req->count = retval; |
442 | retval = 0; | ||
442 | 443 | ||
443 | done: | 444 | done: |
444 | mutex_unlock(&q->vb_lock); | 445 | mutex_unlock(&q->vb_lock); |