diff options
author | Denis Kirjanov <dkirjanov@kernel.org> | 2010-07-30 09:26:06 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-08-02 21:25:26 -0400 |
commit | 9092de6df330265f0cbfca496386d329ec8c2aa5 (patch) | |
tree | b171782d0cbcec49c7f116005225b124282b7c5b | |
parent | 0ebdd466f4682608a6b90ef018d36b57925f4d64 (diff) |
Staging: slicoss: Remove net_device_stats from the driver's private
Remove net_device_stats from the driver's private.
Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/staging/slicoss/slic.h | 1 | ||||
-rw-r--r-- | drivers/staging/slicoss/slicoss.c | 41 |
2 files changed, 21 insertions, 21 deletions
diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h index cab1a614e3a3..beab400805af 100644 --- a/drivers/staging/slicoss/slic.h +++ b/drivers/staging/slicoss/slic.h | |||
@@ -499,7 +499,6 @@ struct adapter { | |||
499 | struct slic_ifevents if_events; | 499 | struct slic_ifevents if_events; |
500 | struct slic_stats inicstats_prev; | 500 | struct slic_stats inicstats_prev; |
501 | struct slicnet_stats slic_stats; | 501 | struct slicnet_stats slic_stats; |
502 | struct net_device_stats stats; | ||
503 | }; | 502 | }; |
504 | 503 | ||
505 | 504 | ||
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index d442e3b831d5..f8c4b127e83a 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c | |||
@@ -860,6 +860,7 @@ static void slic_config_clear(struct adapter *adapter) | |||
860 | static bool slic_mac_filter(struct adapter *adapter, | 860 | static bool slic_mac_filter(struct adapter *adapter, |
861 | struct ether_header *ether_frame) | 861 | struct ether_header *ether_frame) |
862 | { | 862 | { |
863 | struct net_device *netdev = adapter->netdev; | ||
863 | u32 opts = adapter->macopts; | 864 | u32 opts = adapter->macopts; |
864 | u32 *dhost4 = (u32 *)ðer_frame->ether_dhost[0]; | 865 | u32 *dhost4 = (u32 *)ðer_frame->ether_dhost[0]; |
865 | u16 *dhost2 = (u16 *)ðer_frame->ether_dhost[4]; | 866 | u16 *dhost2 = (u16 *)ðer_frame->ether_dhost[4]; |
@@ -879,7 +880,7 @@ static bool slic_mac_filter(struct adapter *adapter, | |||
879 | if (ether_frame->ether_dhost[0] & 0x01) { | 880 | if (ether_frame->ether_dhost[0] & 0x01) { |
880 | if (opts & MAC_ALLMCAST) { | 881 | if (opts & MAC_ALLMCAST) { |
881 | adapter->rcv_multicasts++; | 882 | adapter->rcv_multicasts++; |
882 | adapter->stats.multicast++; | 883 | netdev->stats.multicast++; |
883 | return true; | 884 | return true; |
884 | } | 885 | } |
885 | if (opts & MAC_MCAST) { | 886 | if (opts & MAC_MCAST) { |
@@ -889,7 +890,7 @@ static bool slic_mac_filter(struct adapter *adapter, | |||
889 | if (!compare_ether_addr(mcaddr->address, | 890 | if (!compare_ether_addr(mcaddr->address, |
890 | ether_frame->ether_dhost)) { | 891 | ether_frame->ether_dhost)) { |
891 | adapter->rcv_multicasts++; | 892 | adapter->rcv_multicasts++; |
892 | adapter->stats.multicast++; | 893 | netdev->stats.multicast++; |
893 | return true; | 894 | return true; |
894 | } | 895 | } |
895 | mcaddr = mcaddr->next; | 896 | mcaddr = mcaddr->next; |
@@ -2199,11 +2200,10 @@ static int slic_debug_card_show(struct seq_file *seq, void *v) | |||
2199 | static int slic_debug_adapter_show(struct seq_file *seq, void *v) | 2200 | static int slic_debug_adapter_show(struct seq_file *seq, void *v) |
2200 | { | 2201 | { |
2201 | struct adapter *adapter = seq->private; | 2202 | struct adapter *adapter = seq->private; |
2203 | struct net_device *netdev = adapter->netdev; | ||
2202 | 2204 | ||
2203 | if ((adapter->netdev) && (adapter->netdev->name)) { | 2205 | seq_printf(seq, "info: interface : %s\n", |
2204 | seq_printf(seq, "info: interface : %s\n", | ||
2205 | adapter->netdev->name); | 2206 | adapter->netdev->name); |
2206 | } | ||
2207 | seq_printf(seq, "info: status : %s\n", | 2207 | seq_printf(seq, "info: status : %s\n", |
2208 | SLIC_LINKSTATE(adapter->linkstate)); | 2208 | SLIC_LINKSTATE(adapter->linkstate)); |
2209 | seq_printf(seq, "info: port : %d\n", | 2209 | seq_printf(seq, "info: port : %d\n", |
@@ -2221,9 +2221,9 @@ static int slic_debug_adapter_show(struct seq_file *seq, void *v) | |||
2221 | seq_printf(seq, "info: RcvQ current : %4.4X\n", | 2221 | seq_printf(seq, "info: RcvQ current : %4.4X\n", |
2222 | adapter->rcvqueue.count); | 2222 | adapter->rcvqueue.count); |
2223 | seq_printf(seq, "rx stats: packets : %8.8lX\n", | 2223 | seq_printf(seq, "rx stats: packets : %8.8lX\n", |
2224 | adapter->stats.rx_packets); | 2224 | netdev->stats.rx_packets); |
2225 | seq_printf(seq, "rx stats: bytes : %8.8lX\n", | 2225 | seq_printf(seq, "rx stats: bytes : %8.8lX\n", |
2226 | adapter->stats.rx_bytes); | 2226 | netdev->stats.rx_bytes); |
2227 | seq_printf(seq, "rx stats: broadcasts : %8.8X\n", | 2227 | seq_printf(seq, "rx stats: broadcasts : %8.8X\n", |
2228 | adapter->rcv_broadcasts); | 2228 | adapter->rcv_broadcasts); |
2229 | seq_printf(seq, "rx stats: multicasts : %8.8X\n", | 2229 | seq_printf(seq, "rx stats: multicasts : %8.8X\n", |
@@ -2237,13 +2237,13 @@ static int slic_debug_adapter_show(struct seq_file *seq, void *v) | |||
2237 | seq_printf(seq, "rx stats: drops : %8.8X\n", | 2237 | seq_printf(seq, "rx stats: drops : %8.8X\n", |
2238 | (u32) adapter->rcv_drops); | 2238 | (u32) adapter->rcv_drops); |
2239 | seq_printf(seq, "tx stats: packets : %8.8lX\n", | 2239 | seq_printf(seq, "tx stats: packets : %8.8lX\n", |
2240 | adapter->stats.tx_packets); | 2240 | netdev->stats.tx_packets); |
2241 | seq_printf(seq, "tx stats: bytes : %8.8lX\n", | 2241 | seq_printf(seq, "tx stats: bytes : %8.8lX\n", |
2242 | adapter->stats.tx_bytes); | 2242 | netdev->stats.tx_bytes); |
2243 | seq_printf(seq, "tx stats: errors : %8.8X\n", | 2243 | seq_printf(seq, "tx stats: errors : %8.8X\n", |
2244 | (u32) adapter->slic_stats.iface.xmt_errors); | 2244 | (u32) adapter->slic_stats.iface.xmt_errors); |
2245 | seq_printf(seq, "rx stats: multicasts : %8.8lX\n", | 2245 | seq_printf(seq, "rx stats: multicasts : %8.8lX\n", |
2246 | adapter->stats.multicast); | 2246 | netdev->stats.multicast); |
2247 | seq_printf(seq, "tx stats: collision errors : %8.8X\n", | 2247 | seq_printf(seq, "tx stats: collision errors : %8.8X\n", |
2248 | (u32) adapter->slic_stats.iface.xmit_collisions); | 2248 | (u32) adapter->slic_stats.iface.xmit_collisions); |
2249 | seq_printf(seq, "perf: Max rcv frames/isr : %8.8X\n", | 2249 | seq_printf(seq, "perf: Max rcv frames/isr : %8.8X\n", |
@@ -2620,13 +2620,14 @@ static void slic_xmit_fail(struct adapter *adapter, | |||
2620 | } | 2620 | } |
2621 | } | 2621 | } |
2622 | dev_kfree_skb(skb); | 2622 | dev_kfree_skb(skb); |
2623 | adapter->stats.tx_dropped++; | 2623 | adapter->netdev->stats.tx_dropped++; |
2624 | } | 2624 | } |
2625 | 2625 | ||
2626 | static void slic_rcv_handle_error(struct adapter *adapter, | 2626 | static void slic_rcv_handle_error(struct adapter *adapter, |
2627 | struct slic_rcvbuf *rcvbuf) | 2627 | struct slic_rcvbuf *rcvbuf) |
2628 | { | 2628 | { |
2629 | struct slic_hddr_wds *hdr = (struct slic_hddr_wds *)rcvbuf->data; | 2629 | struct slic_hddr_wds *hdr = (struct slic_hddr_wds *)rcvbuf->data; |
2630 | struct net_device *netdev = adapter->netdev; | ||
2630 | 2631 | ||
2631 | if (adapter->devid != SLIC_1GB_DEVICE_ID) { | 2632 | if (adapter->devid != SLIC_1GB_DEVICE_ID) { |
2632 | if (hdr->frame_status14 & VRHSTAT_802OE) | 2633 | if (hdr->frame_status14 & VRHSTAT_802OE) |
@@ -2637,15 +2638,15 @@ static void slic_rcv_handle_error(struct adapter *adapter, | |||
2637 | adapter->if_events.uflow802++; | 2638 | adapter->if_events.uflow802++; |
2638 | if (hdr->frame_status_b14 & VRHSTATB_RCVE) { | 2639 | if (hdr->frame_status_b14 & VRHSTATB_RCVE) { |
2639 | adapter->if_events.rcvearly++; | 2640 | adapter->if_events.rcvearly++; |
2640 | adapter->stats.rx_fifo_errors++; | 2641 | netdev->stats.rx_fifo_errors++; |
2641 | } | 2642 | } |
2642 | if (hdr->frame_status_b14 & VRHSTATB_BUFF) { | 2643 | if (hdr->frame_status_b14 & VRHSTATB_BUFF) { |
2643 | adapter->if_events.Bufov++; | 2644 | adapter->if_events.Bufov++; |
2644 | adapter->stats.rx_over_errors++; | 2645 | netdev->stats.rx_over_errors++; |
2645 | } | 2646 | } |
2646 | if (hdr->frame_status_b14 & VRHSTATB_CARRE) { | 2647 | if (hdr->frame_status_b14 & VRHSTATB_CARRE) { |
2647 | adapter->if_events.Carre++; | 2648 | adapter->if_events.Carre++; |
2648 | adapter->stats.tx_carrier_errors++; | 2649 | netdev->stats.tx_carrier_errors++; |
2649 | } | 2650 | } |
2650 | if (hdr->frame_status_b14 & VRHSTATB_LONGE) | 2651 | if (hdr->frame_status_b14 & VRHSTATB_LONGE) |
2651 | adapter->if_events.Longe++; | 2652 | adapter->if_events.Longe++; |
@@ -2653,7 +2654,7 @@ static void slic_rcv_handle_error(struct adapter *adapter, | |||
2653 | adapter->if_events.Invp++; | 2654 | adapter->if_events.Invp++; |
2654 | if (hdr->frame_status_b14 & VRHSTATB_CRC) { | 2655 | if (hdr->frame_status_b14 & VRHSTATB_CRC) { |
2655 | adapter->if_events.Crc++; | 2656 | adapter->if_events.Crc++; |
2656 | adapter->stats.rx_crc_errors++; | 2657 | netdev->stats.rx_crc_errors++; |
2657 | } | 2658 | } |
2658 | if (hdr->frame_status_b14 & VRHSTATB_DRBL) | 2659 | if (hdr->frame_status_b14 & VRHSTATB_DRBL) |
2659 | adapter->if_events.Drbl++; | 2660 | adapter->if_events.Drbl++; |
@@ -2719,6 +2720,7 @@ static void slic_rcv_handle_error(struct adapter *adapter, | |||
2719 | 2720 | ||
2720 | static void slic_rcv_handler(struct adapter *adapter) | 2721 | static void slic_rcv_handler(struct adapter *adapter) |
2721 | { | 2722 | { |
2723 | struct net_device *netdev = adapter->netdev; | ||
2722 | struct sk_buff *skb; | 2724 | struct sk_buff *skb; |
2723 | struct slic_rcvbuf *rcvbuf; | 2725 | struct slic_rcvbuf *rcvbuf; |
2724 | u32 frames = 0; | 2726 | u32 frames = 0; |
@@ -2744,8 +2746,8 @@ static void slic_rcv_handler(struct adapter *adapter) | |||
2744 | skb_pull(skb, SLIC_RCVBUF_HEADSIZE); | 2746 | skb_pull(skb, SLIC_RCVBUF_HEADSIZE); |
2745 | rx_bytes = (rcvbuf->length & IRHDDR_FLEN_MSK); | 2747 | rx_bytes = (rcvbuf->length & IRHDDR_FLEN_MSK); |
2746 | skb_put(skb, rx_bytes); | 2748 | skb_put(skb, rx_bytes); |
2747 | adapter->stats.rx_packets++; | 2749 | netdev->stats.rx_packets++; |
2748 | adapter->stats.rx_bytes += rx_bytes; | 2750 | netdev->stats.rx_bytes += rx_bytes; |
2749 | #if SLIC_OFFLOAD_IP_CHECKSUM | 2751 | #if SLIC_OFFLOAD_IP_CHECKSUM |
2750 | skb->ip_summed = CHECKSUM_UNNECESSARY; | 2752 | skb->ip_summed = CHECKSUM_UNNECESSARY; |
2751 | #endif | 2753 | #endif |
@@ -2939,8 +2941,8 @@ static netdev_tx_t slic_xmit_start(struct sk_buff *skb, struct net_device *dev) | |||
2939 | if (skbtype == NORMAL_ETHFRAME) | 2941 | if (skbtype == NORMAL_ETHFRAME) |
2940 | slic_xmit_build_request(adapter, hcmd, skb); | 2942 | slic_xmit_build_request(adapter, hcmd, skb); |
2941 | } | 2943 | } |
2942 | adapter->stats.tx_packets++; | 2944 | dev->stats.tx_packets++; |
2943 | adapter->stats.tx_bytes += skb->len; | 2945 | dev->stats.tx_bytes += skb->len; |
2944 | 2946 | ||
2945 | #ifdef DEBUG_DUMP | 2947 | #ifdef DEBUG_DUMP |
2946 | if (adapter->kill_card) { | 2948 | if (adapter->kill_card) { |
@@ -2972,7 +2974,6 @@ xmit_fail: | |||
2972 | static void slic_adapter_freeresources(struct adapter *adapter) | 2974 | static void slic_adapter_freeresources(struct adapter *adapter) |
2973 | { | 2975 | { |
2974 | slic_init_cleanup(adapter); | 2976 | slic_init_cleanup(adapter); |
2975 | memset(&adapter->stats, 0, sizeof(struct net_device_stats)); | ||
2976 | adapter->error_interrupts = 0; | 2977 | adapter->error_interrupts = 0; |
2977 | adapter->rcv_interrupts = 0; | 2978 | adapter->rcv_interrupts = 0; |
2978 | adapter->xmit_interrupts = 0; | 2979 | adapter->xmit_interrupts = 0; |