diff options
author | Thierry Reding <thierry.reding@avionic-design.de> | 2013-01-21 05:08:57 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-01-25 15:21:46 -0500 |
commit | 903b33e0292465ebe9705a70084bf9ad06a8a2a5 (patch) | |
tree | 72f5096291979580bef5f7d90c4dd5d4896eda9e | |
parent | 7c390a7e956b4bf7b7d6dba4dfb93299c4f0879a (diff) |
amba: Convert to devm_ioremap_resource()
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/amba/tegra-ahb.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c index 536c166f4253..ab92785f54dc 100644 --- a/drivers/amba/tegra-ahb.c +++ b/drivers/amba/tegra-ahb.c | |||
@@ -20,6 +20,7 @@ | |||
20 | * | 20 | * |
21 | */ | 21 | */ |
22 | 22 | ||
23 | #include <linux/err.h> | ||
23 | #include <linux/kernel.h> | 24 | #include <linux/kernel.h> |
24 | #include <linux/module.h> | 25 | #include <linux/module.h> |
25 | #include <linux/platform_device.h> | 26 | #include <linux/platform_device.h> |
@@ -257,9 +258,9 @@ static int tegra_ahb_probe(struct platform_device *pdev) | |||
257 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | 258 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
258 | if (!res) | 259 | if (!res) |
259 | return -ENODEV; | 260 | return -ENODEV; |
260 | ahb->regs = devm_request_and_ioremap(&pdev->dev, res); | 261 | ahb->regs = devm_ioremap_resource(&pdev->dev, res); |
261 | if (!ahb->regs) | 262 | if (IS_ERR(ahb->regs)) |
262 | return -EBUSY; | 263 | return PTR_ERR(ahb->regs); |
263 | 264 | ||
264 | ahb->dev = &pdev->dev; | 265 | ahb->dev = &pdev->dev; |
265 | platform_set_drvdata(pdev, ahb); | 266 | platform_set_drvdata(pdev, ahb); |