diff options
author | Salva Peiró <speiro@ai2.upv.es> | 2013-12-17 04:06:30 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-01-15 18:28:48 -0500 |
commit | 8f3843be6e6d1fcc5bcdad42b569a5d4797d9d1f (patch) | |
tree | 6eaa73bef8927c3fa80ddf6f1fcd3ecdec9219be | |
parent | 2173ca37c090930f51f701fdd963b63fe2502789 (diff) |
hamradio/yam: fix info leak in ioctl
[ Upstream commit 8e3fbf870481eb53b2d3a322d1fc395ad8b367ed ]
The yam_ioctl() code fails to initialise the cmd field
of the struct yamdrv_ioctl_cfg. Add an explicit memset(0)
before filling the structure to avoid the 4-byte info leak.
Signed-off-by: Salva Peiró <speiro@ai2.upv.es>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/net/hamradio/yam.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index 0721e72f9299..82529a2658d7 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c | |||
@@ -1058,6 +1058,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) | |||
1058 | break; | 1058 | break; |
1059 | 1059 | ||
1060 | case SIOCYAMGCFG: | 1060 | case SIOCYAMGCFG: |
1061 | memset(&yi, 0, sizeof(yi)); | ||
1061 | yi.cfg.mask = 0xffffffff; | 1062 | yi.cfg.mask = 0xffffffff; |
1062 | yi.cfg.iobase = yp->iobase; | 1063 | yi.cfg.iobase = yp->iobase; |
1063 | yi.cfg.irq = yp->irq; | 1064 | yi.cfg.irq = yp->irq; |