diff options
| author | Jie Yang <yang.jie@intel.com> | 2015-04-07 08:14:59 -0400 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2015-04-08 06:17:51 -0400 |
| commit | 8e64aedf80ae14b852abc0d7ca262530b69e9a18 (patch) | |
| tree | c07376cf906120cdfefd7f766e3af21d560aa2a6 | |
| parent | f34c4bc7e599bb895f77381c4d91ccc77635d68f (diff) | |
ASoC: Intel: Fix a buffer overflow issue
0day robot reported a buffer overflow issue:
...
sound/soc/intel/haswell/sst-haswell-pcm.c:1107 hsw_pcm_probe() error: buffer\
overflow 'hsw_dais' 4 <= 4
sound/soc/intel/haswell/sst-haswell-pcm.c:1109 hsw_pcm_probe() error: buffer\
overflow 'hsw_dais' 4 <= 4
...
Fix it by initializing the index(i) to correct value.
Signed-off-by: Jie Yang <yang.jie@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/intel/haswell/sst-haswell-pcm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/intel/haswell/sst-haswell-pcm.c b/sound/soc/intel/haswell/sst-haswell-pcm.c index 157b3a6c509e..23ae0400d6db 100644 --- a/sound/soc/intel/haswell/sst-haswell-pcm.c +++ b/sound/soc/intel/haswell/sst-haswell-pcm.c | |||
| @@ -1103,7 +1103,7 @@ static int hsw_pcm_probe(struct snd_soc_platform *platform) | |||
| 1103 | return 0; | 1103 | return 0; |
| 1104 | 1104 | ||
| 1105 | err: | 1105 | err: |
| 1106 | for (;i >= 0; i--) { | 1106 | for (--i; i >= 0; i--) { |
| 1107 | if (hsw_dais[i].playback.channels_min) | 1107 | if (hsw_dais[i].playback.channels_min) |
| 1108 | snd_dma_free_pages(&priv_data->dmab[i][0]); | 1108 | snd_dma_free_pages(&priv_data->dmab[i][0]); |
| 1109 | if (hsw_dais[i].capture.channels_min) | 1109 | if (hsw_dais[i].capture.channels_min) |
