diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2006-11-20 21:06:37 -0500 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2006-12-03 00:27:16 -0500 |
commit | 8e5200f54062b8af0ed1d186ea0f113854786d89 (patch) | |
tree | 71e00b21ae4f8410413f70141aa275529dbbfb84 | |
parent | 34bcca28335977e969338c98c6c43a1e08f592b2 (diff) |
[NET]: Fix assorted misannotations (from md5 and udplite merges).
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | include/net/tcp.h | 2 | ||||
-rw-r--r-- | include/net/udp.h | 2 | ||||
-rw-r--r-- | include/net/udplite.h | 4 | ||||
-rw-r--r-- | net/ipv4/tcp_ipv4.c | 2 | ||||
-rw-r--r-- | net/ipv4/udp.c | 4 | ||||
-rw-r--r-- | net/ipv6/tcp_ipv6.c | 4 | ||||
-rw-r--r-- | net/ipv6/udp.c | 2 | ||||
-rw-r--r-- | net/ipv6/udplite.c | 2 |
8 files changed, 11 insertions, 11 deletions
diff --git a/include/net/tcp.h b/include/net/tcp.h index aa7989c53791..c99774f15eba 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h | |||
@@ -1154,7 +1154,7 @@ extern int tcp_v4_md5_do_add(struct sock *sk, | |||
1154 | u8 newkeylen); | 1154 | u8 newkeylen); |
1155 | 1155 | ||
1156 | extern int tcp_v4_md5_do_del(struct sock *sk, | 1156 | extern int tcp_v4_md5_do_del(struct sock *sk, |
1157 | u32 addr); | 1157 | __be32 addr); |
1158 | 1158 | ||
1159 | extern struct tcp_md5sig_pool **tcp_alloc_md5sig_pool(void); | 1159 | extern struct tcp_md5sig_pool **tcp_alloc_md5sig_pool(void); |
1160 | extern void tcp_free_md5sig_pool(void); | 1160 | extern void tcp_free_md5sig_pool(void); |
diff --git a/include/net/udp.h b/include/net/udp.h index c5ccd9a3387b..eac69ff0582c 100644 --- a/include/net/udp.h +++ b/include/net/udp.h | |||
@@ -77,7 +77,7 @@ static inline __sum16 __udp_lib_checksum_complete(struct sk_buff *skb) | |||
77 | skb->csum)); | 77 | skb->csum)); |
78 | } | 78 | } |
79 | 79 | ||
80 | static inline __sum16 udp_lib_checksum_complete(struct sk_buff *skb) | 80 | static inline int udp_lib_checksum_complete(struct sk_buff *skb) |
81 | { | 81 | { |
82 | return skb->ip_summed != CHECKSUM_UNNECESSARY && | 82 | return skb->ip_summed != CHECKSUM_UNNECESSARY && |
83 | __udp_lib_checksum_complete(skb); | 83 | __udp_lib_checksum_complete(skb); |
diff --git a/include/net/udplite.h b/include/net/udplite.h index 3abaab7b78c6..67ac51424307 100644 --- a/include/net/udplite.h +++ b/include/net/udplite.h | |||
@@ -90,9 +90,9 @@ static __inline__ int udplite6_csum_init(struct sk_buff *skb, struct udphdr *uh) | |||
90 | int rc = udplite_checksum_init(skb, uh); | 90 | int rc = udplite_checksum_init(skb, uh); |
91 | 91 | ||
92 | if (!rc) | 92 | if (!rc) |
93 | skb->csum = ~csum_ipv6_magic(&skb->nh.ipv6h->saddr, | 93 | skb->csum = ~csum_unfold(csum_ipv6_magic(&skb->nh.ipv6h->saddr, |
94 | &skb->nh.ipv6h->daddr, | 94 | &skb->nh.ipv6h->daddr, |
95 | skb->len, IPPROTO_UDPLITE, 0); | 95 | skb->len, IPPROTO_UDPLITE, 0)); |
96 | return rc; | 96 | return rc; |
97 | } | 97 | } |
98 | 98 | ||
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index b7d5522092eb..e9d467124c4d 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c | |||
@@ -1020,7 +1020,7 @@ static int tcp_v4_do_calc_md5_hash(char *md5_hash, struct tcp_md5sig_key *key, | |||
1020 | #ifdef CONFIG_TCP_MD5SIG_DEBUG | 1020 | #ifdef CONFIG_TCP_MD5SIG_DEBUG |
1021 | int i; | 1021 | int i; |
1022 | #endif | 1022 | #endif |
1023 | __u16 old_checksum; | 1023 | __sum16 old_checksum; |
1024 | struct tcp_md5sig_pool *hp; | 1024 | struct tcp_md5sig_pool *hp; |
1025 | struct tcp4_pseudohdr *bp; | 1025 | struct tcp4_pseudohdr *bp; |
1026 | struct hash_desc *desc; | 1026 | struct hash_desc *desc; |
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index 7eb76fbf1b4b..28e4cf662ce0 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c | |||
@@ -114,7 +114,7 @@ DEFINE_RWLOCK(udp_hash_lock); | |||
114 | 114 | ||
115 | static int udp_port_rover; | 115 | static int udp_port_rover; |
116 | 116 | ||
117 | static inline int __udp_lib_lport_inuse(__be16 num, struct hlist_head udptable[]) | 117 | static inline int __udp_lib_lport_inuse(__u16 num, struct hlist_head udptable[]) |
118 | { | 118 | { |
119 | struct sock *sk; | 119 | struct sock *sk; |
120 | struct hlist_node *node; | 120 | struct hlist_node *node; |
@@ -455,7 +455,7 @@ static int udp_push_pending_frames(struct sock *sk, struct udp_sock *up) | |||
455 | struct sk_buff *skb; | 455 | struct sk_buff *skb; |
456 | struct udphdr *uh; | 456 | struct udphdr *uh; |
457 | int err = 0; | 457 | int err = 0; |
458 | u32 csum = 0; | 458 | __wsum csum = 0; |
459 | 459 | ||
460 | /* Grab the skbuff where UDP header space exists. */ | 460 | /* Grab the skbuff where UDP header space exists. */ |
461 | if ((skb = skb_peek(&sk->sk_write_queue)) == NULL) | 461 | if ((skb = skb_peek(&sk->sk_write_queue)) == NULL) |
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index d2170da77e5b..0adb337c4b7e 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c | |||
@@ -739,7 +739,7 @@ static int tcp_v6_do_calc_md5_hash(char *md5_hash, struct tcp_md5sig_key *key, | |||
739 | struct scatterlist sg[4]; | 739 | struct scatterlist sg[4]; |
740 | __u16 data_len; | 740 | __u16 data_len; |
741 | int block = 0; | 741 | int block = 0; |
742 | __u16 cksum; | 742 | __sum16 cksum; |
743 | struct tcp_md5sig_pool *hp; | 743 | struct tcp_md5sig_pool *hp; |
744 | struct tcp6_pseudohdr *bp; | 744 | struct tcp6_pseudohdr *bp; |
745 | struct hash_desc *desc; | 745 | struct hash_desc *desc; |
@@ -1032,7 +1032,7 @@ static void tcp_v6_send_reset(struct sock *sk, struct sk_buff *skb) | |||
1032 | 1032 | ||
1033 | #ifdef CONFIG_TCP_MD5SIG | 1033 | #ifdef CONFIG_TCP_MD5SIG |
1034 | if (key) { | 1034 | if (key) { |
1035 | u32 *opt = (u32*)(t1 + 1); | 1035 | __be32 *opt = (__be32*)(t1 + 1); |
1036 | opt[0] = htonl((TCPOPT_NOP << 24) | | 1036 | opt[0] = htonl((TCPOPT_NOP << 24) | |
1037 | (TCPOPT_NOP << 16) | | 1037 | (TCPOPT_NOP << 16) | |
1038 | (TCPOPT_MD5SIG << 8) | | 1038 | (TCPOPT_MD5SIG << 8) | |
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index efa8950ddd30..b3ea8af50a9b 100644 --- a/net/ipv6/udp.c +++ b/net/ipv6/udp.c | |||
@@ -248,7 +248,7 @@ out: | |||
248 | 248 | ||
249 | static __inline__ void udpv6_err(struct sk_buff *skb, | 249 | static __inline__ void udpv6_err(struct sk_buff *skb, |
250 | struct inet6_skb_parm *opt, int type, | 250 | struct inet6_skb_parm *opt, int type, |
251 | int code, int offset, __u32 info ) | 251 | int code, int offset, __be32 info ) |
252 | { | 252 | { |
253 | return __udp6_lib_err(skb, opt, type, code, offset, info, udp_hash); | 253 | return __udp6_lib_err(skb, opt, type, code, offset, info, udp_hash); |
254 | } | 254 | } |
diff --git a/net/ipv6/udplite.c b/net/ipv6/udplite.c index e0ec5e63004a..d4cafacc235b 100644 --- a/net/ipv6/udplite.c +++ b/net/ipv6/udplite.c | |||
@@ -24,7 +24,7 @@ static __inline__ int udplitev6_rcv(struct sk_buff **pskb) | |||
24 | 24 | ||
25 | static __inline__ void udplitev6_err(struct sk_buff *skb, | 25 | static __inline__ void udplitev6_err(struct sk_buff *skb, |
26 | struct inet6_skb_parm *opt, | 26 | struct inet6_skb_parm *opt, |
27 | int type, int code, int offset, __u32 info) | 27 | int type, int code, int offset, __be32 info) |
28 | { | 28 | { |
29 | return __udp6_lib_err(skb, opt, type, code, offset, info, udplite_hash); | 29 | return __udp6_lib_err(skb, opt, type, code, offset, info, udplite_hash); |
30 | } | 30 | } |