drm: Split out drm_probe_helper.c from drm_crtc_helper.c

This is leftover stuff from my previous doc round which I kinda wanted
to do but didn't yet due to rebase hell.

The modeset helpers and the probing helpers a independent and e.g.
i915 uses the probing stuff but has its own modeset infrastructure. It
hence makes to split this up. While at it add a DOC: comment for the
probing libraray.

It would be rather neat to pull some of the DocBook documenting these
two helpers into in-line DOC: comments. But unfortunately kerneldoc
doesn't support markdown or something similar to make nice-looking
documentation, so the current state is better.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>

5 files changed, 437 insertions, 372 deletions

diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
index 702c4474919c..677a02553ec0 100644
--- a/Documentation/DocBook/drm.tmpl
+++ b/Documentation/DocBook/drm.tmpl
@@ -2287,6 +2287,11 @@ void intel_crt_init(struct drm_device *dev)
 !Edrivers/gpu/drm/drm_crtc_helper.c
     </sect2>
     <sect2>
+      <title>Output Probing Helper Functions Reference</title>
+!Pdrivers/gpu/drm/drm_probe_helper.c output probing helper overview
+!Edrivers/gpu/drm/drm_probe_helper.c
+    </sect2>
+    <sect2>
       <title>fbdev Helper Functions Reference</title>
 !Pdrivers/gpu/drm/drm_fb_helper.c fbdev helpers
 !Edrivers/gpu/drm/drm_fb_helper.c
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index 9d25dbbe6771..48e38ba22783 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -23,7 +23,7 @@ drm-$(CONFIG_DRM_PANEL) += drm_panel.o
 
 drm-usb-y   := drm_usb.o
 
-drm_kms_helper-y := drm_crtc_helper.o drm_dp_helper.o
+drm_kms_helper-y := drm_crtc_helper.o drm_dp_helper.o drm_probe_helper.o
 drm_kms_helper-$(CONFIG_DRM_LOAD_EDID_FIRMWARE) += drm_edid_load.o
 drm_kms_helper-$(CONFIG_DRM_KMS_FB_HELPER) += drm_fb_helper.o
 drm_kms_helper-$(CONFIG_DRM_KMS_CMA_HELPER) += drm_fb_cma_helper.o
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index c43825e8f5c1..df281b54db01 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -72,147 +72,6 @@ void drm_helper_move_panel_connectors_to_head(struct drm_device *dev)
 }
 EXPORT_SYMBOL(drm_helper_move_panel_connectors_to_head);
 
-static bool drm_kms_helper_poll = true;
-module_param_named(poll, drm_kms_helper_poll, bool, 0600);
-
-static void drm_mode_validate_flag(struct drm_connector *connector,
-                                   int flags)
-{
-        struct drm_display_mode *mode;
-
-        if (flags == (DRM_MODE_FLAG_DBLSCAN | DRM_MODE_FLAG_INTERLACE |
-                      DRM_MODE_FLAG_3D_MASK))
-                return;
-
-        list_for_each_entry(mode, &connector->modes, head) {
-                if ((mode->flags & DRM_MODE_FLAG_INTERLACE) &&
-                                !(flags & DRM_MODE_FLAG_INTERLACE))
-                        mode->status = MODE_NO_INTERLACE;
-                if ((mode->flags & DRM_MODE_FLAG_DBLSCAN) &&
-                                !(flags & DRM_MODE_FLAG_DBLSCAN))
-                        mode->status = MODE_NO_DBLESCAN;
-                if ((mode->flags & DRM_MODE_FLAG_3D_MASK) &&
-                                !(flags & DRM_MODE_FLAG_3D_MASK))
-                        mode->status = MODE_NO_STEREO;
-        }
-
-        return;
-}
-
-/**
- * drm_helper_probe_single_connector_modes - get complete set of display modes
- * @connector: connector to probe
- * @maxX: max width for modes
- * @maxY: max height for modes
- *
- * Based on the helper callbacks implemented by @connector try to detect all
- * valid modes.  Modes will first be added to the connector's probed_modes list,
- * then culled (based on validity and the @maxX, @maxY parameters) and put into
- * the normal modes list.
- *
- * Intended to be use as a generic implementation of the ->fill_modes()
- * @connector vfunc for drivers that use the crtc helpers for output mode
- * filtering and detection.
- *
- * Returns:
- * The number of modes found on @connector.
- */
-int drm_helper_probe_single_connector_modes(struct drm_connector *connector,
-                                            uint32_t maxX, uint32_t maxY)
-{
-        struct drm_device *dev = connector->dev;
-        struct drm_display_mode *mode;
-        struct drm_connector_helper_funcs *connector_funcs =
-                connector->helper_private;
-        int count = 0;
-        int mode_flags = 0;
-        bool verbose_prune = true;
-
-        WARN_ON(!mutex_is_locked(&dev->mode_config.mutex));
-
-        DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", connector->base.id,
-                        drm_get_connector_name(connector));
-        /* set all modes to the unverified state */
-        list_for_each_entry(mode, &connector->modes, head)
-                mode->status = MODE_UNVERIFIED;
-
-        if (connector->force) {
-                if (connector->force == DRM_FORCE_ON)
-                        connector->status = connector_status_connected;
-                else
-                        connector->status = connector_status_disconnected;
-                if (connector->funcs->force)
-                        connector->funcs->force(connector);
-        } else {
-                connector->status = connector->funcs->detect(connector, true);
-        }
-
-        /* Re-enable polling in case the global poll config changed. */
-        if (drm_kms_helper_poll != dev->mode_config.poll_running)
-                drm_kms_helper_poll_enable(dev);
-
-        dev->mode_config.poll_running = drm_kms_helper_poll;
-
-        if (connector->status == connector_status_disconnected) {
-                DRM_DEBUG_KMS("[CONNECTOR:%d:%s] disconnected\n",
-                        connector->base.id, drm_get_connector_name(connector));
-                drm_mode_connector_update_edid_property(connector, NULL);
-                verbose_prune = false;
-                goto prune;
-        }
-
-#ifdef CONFIG_DRM_LOAD_EDID_FIRMWARE
-        count = drm_load_edid_firmware(connector);
-        if (count == 0)
-#endif
-                count = (*connector_funcs->get_modes)(connector);
-
-        if (count == 0 && connector->status == connector_status_connected)
-                count = drm_add_modes_noedid(connector, 1024, 768);
-        if (count == 0)
-                goto prune;
-
-        drm_mode_connector_list_update(connector);
-
-        if (maxX && maxY)
-                drm_mode_validate_size(dev, &connector->modes, maxX, maxY);
-
-        if (connector->interlace_allowed)
-                mode_flags |= DRM_MODE_FLAG_INTERLACE;
-        if (connector->doublescan_allowed)
-                mode_flags |= DRM_MODE_FLAG_DBLSCAN;
-        if (connector->stereo_allowed)
-                mode_flags |= DRM_MODE_FLAG_3D_MASK;
-        drm_mode_validate_flag(connector, mode_flags);
-
-        list_for_each_entry(mode, &connector->modes, head) {
-                if (mode->status == MODE_OK)
-                        mode->status = connector_funcs->mode_valid(connector,
-                                                                   mode);
-        }
-
-prune:
-        drm_mode_prune_invalid(dev, &connector->modes, verbose_prune);
-
-        if (list_empty(&connector->modes))
-                return 0;
-
-        list_for_each_entry(mode, &connector->modes, head)
-                mode->vrefresh = drm_mode_vrefresh(mode);
-
-        drm_mode_sort(&connector->modes);
-
-        DRM_DEBUG_KMS("[CONNECTOR:%d:%s] probed modes :\n", connector->base.id,
-                        drm_get_connector_name(connector));
-        list_for_each_entry(mode, &connector->modes, head) {
-                drm_mode_set_crtcinfo(mode, CRTC_INTERLACE_HALVE_V);
-                drm_mode_debug_printmodeline(mode);
-        }
-
-        return count;
-}
-EXPORT_SYMBOL(drm_helper_probe_single_connector_modes);
-
 /**
  * drm_helper_encoder_in_use - check if a given encoder is in use