diff options
author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2013-05-22 06:20:13 -0400 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2013-05-30 13:31:07 -0400 |
commit | 8aca119f561ddb51d407b26f5dacb4f4ce3b3364 (patch) | |
tree | eeec92e1fc50063957a8537fea61a21f97fd59ac | |
parent | 786e07ecb5b2ef896c9d42fa982d02da168e4290 (diff) |
gpio-langwell: amend error messages
There is no need to use hardcoded device name in the error messages, because
dev_err() prefixes the message with the device name anyway.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: David Cohen <david.a.cohen@intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r-- | drivers/gpio/gpio-langwell.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio/gpio-langwell.c index 54b6caf1742e..313d190c528d 100644 --- a/drivers/gpio/gpio-langwell.c +++ b/drivers/gpio/gpio-langwell.c | |||
@@ -347,7 +347,7 @@ static int lnw_gpio_probe(struct pci_dev *pdev, | |||
347 | 347 | ||
348 | lnw = devm_kzalloc(&pdev->dev, sizeof(*lnw), GFP_KERNEL); | 348 | lnw = devm_kzalloc(&pdev->dev, sizeof(*lnw), GFP_KERNEL); |
349 | if (!lnw) { | 349 | if (!lnw) { |
350 | dev_err(&pdev->dev, "can't allocate langwell_gpio chip data\n"); | 350 | dev_err(&pdev->dev, "can't allocate chip data\n"); |
351 | return -ENOMEM; | 351 | return -ENOMEM; |
352 | } | 352 | } |
353 | 353 | ||
@@ -374,7 +374,7 @@ static int lnw_gpio_probe(struct pci_dev *pdev, | |||
374 | pci_set_drvdata(pdev, lnw); | 374 | pci_set_drvdata(pdev, lnw); |
375 | retval = gpiochip_add(&lnw->chip); | 375 | retval = gpiochip_add(&lnw->chip); |
376 | if (retval) { | 376 | if (retval) { |
377 | dev_err(&pdev->dev, "langwell gpiochip_add error %d\n", retval); | 377 | dev_err(&pdev->dev, "gpiochip_add error %d\n", retval); |
378 | return retval; | 378 | return retval; |
379 | } | 379 | } |
380 | 380 | ||
@@ -408,8 +408,7 @@ static int wp_gpio_probe(struct platform_device *pdev) | |||
408 | 408 | ||
409 | lnw = devm_kzalloc(&pdev->dev, sizeof(struct lnw_gpio), GFP_KERNEL); | 409 | lnw = devm_kzalloc(&pdev->dev, sizeof(struct lnw_gpio), GFP_KERNEL); |
410 | if (!lnw) { | 410 | if (!lnw) { |
411 | dev_err(&pdev->dev, | 411 | dev_err(&pdev->dev, "can't allocate chip data\n"); |
412 | "can't allocate whitneypoint_gpio chip data\n"); | ||
413 | return -ENOMEM; | 412 | return -ENOMEM; |
414 | } | 413 | } |
415 | 414 | ||
@@ -432,8 +431,7 @@ static int wp_gpio_probe(struct platform_device *pdev) | |||
432 | gc->can_sleep = 0; | 431 | gc->can_sleep = 0; |
433 | retval = gpiochip_add(gc); | 432 | retval = gpiochip_add(gc); |
434 | if (retval) { | 433 | if (retval) { |
435 | dev_err(&pdev->dev, "whitneypoint gpiochip_add error %d\n", | 434 | dev_err(&pdev->dev, "gpiochip_add error %d\n", retval); |
436 | retval); | ||
437 | return retval; | 435 | return retval; |
438 | } | 436 | } |
439 | platform_set_drvdata(pdev, lnw); | 437 | platform_set_drvdata(pdev, lnw); |