diff options
| author | David Howells <dhowells@redhat.com> | 2012-10-04 07:10:18 -0400 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2012-10-04 07:10:18 -0400 |
| commit | 890139529d45ebd3c60d541f4eddc60e042fdf98 (patch) | |
| tree | b5a6bc076ca22ce95269544db5c9033496df8b95 | |
| parent | 612a9aab56a93533e76e3ad91642db7033e03b69 (diff) | |
UAPI: Fix the guards on various asm/unistd.h files
asm-generic/unistd.h and a number of asm/unistd.h files have been given
reinclusion guards that allow the guard to be overridden if __SYSCALL is
defined. Unfortunately, these files define __SYSCALL and don't undefine it
when they've finished with it, thus rendering the guard ineffective.
The reason for this override is to allow the file to be #included multiple
times with different settings on __SYSCALL for purposes like generating syscall
tables.
The following guards are problematic:
arch/arm64/include/asm/unistd.h:#if !defined(__ASM_UNISTD_H) || defined(__SYSCALL)
arch/arm64/include/asm/unistd32.h:#if !defined(__ASM_UNISTD32_H) || defined(__SYSCALL)
arch/c6x/include/asm/unistd.h:#if !defined(_ASM_C6X_UNISTD_H) || defined(__SYSCALL)
arch/hexagon/include/asm/unistd.h:#if !defined(_ASM_HEXAGON_UNISTD_H) || defined(__SYSCALL)
arch/openrisc/include/asm/unistd.h:#if !defined(__ASM_OPENRISC_UNISTD_H) || defined(__SYSCALL)
arch/score/include/asm/unistd.h:#if !defined(_ASM_SCORE_UNISTD_H) || defined(__SYSCALL)
arch/tile/include/asm/unistd.h:#if !defined(_ASM_TILE_UNISTD_H) || defined(__SYSCALL)
arch/unicore32/include/asm/unistd.h:#if !defined(__UNICORE_UNISTD_H__) || defined(__SYSCALL)
include/asm-generic/unistd.h:#if !defined(_ASM_GENERIC_UNISTD_H) || defined(__SYSCALL)
On the assumption that the guards' ineffectiveness has passed unnoticed, just
remove these guards entirely.
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
| -rw-r--r-- | arch/arm64/include/asm/unistd.h | 4 | ||||
| -rw-r--r-- | arch/arm64/include/asm/unistd32.h | 4 | ||||
| -rw-r--r-- | arch/c6x/include/asm/unistd.h | 4 | ||||
| -rw-r--r-- | arch/hexagon/include/asm/unistd.h | 5 | ||||
| -rw-r--r-- | arch/openrisc/include/asm/unistd.h | 5 | ||||
| -rw-r--r-- | arch/score/include/asm/unistd.h | 5 | ||||
| -rw-r--r-- | arch/tile/include/asm/unistd.h | 5 | ||||
| -rw-r--r-- | arch/unicore32/include/asm/unistd.h | 4 | ||||
| -rw-r--r-- | include/asm-generic/unistd.h | 4 |
9 files changed, 0 insertions, 40 deletions
diff --git a/arch/arm64/include/asm/unistd.h b/arch/arm64/include/asm/unistd.h index fe18a683274f..f55ba3e56c32 100644 --- a/arch/arm64/include/asm/unistd.h +++ b/arch/arm64/include/asm/unistd.h | |||
| @@ -13,8 +13,6 @@ | |||
| 13 | * You should have received a copy of the GNU General Public License | 13 | * You should have received a copy of the GNU General Public License |
| 14 | * along with this program. If not, see <http://www.gnu.org/licenses/>. | 14 | * along with this program. If not, see <http://www.gnu.org/licenses/>. |
| 15 | */ | 15 | */ |
| 16 | #if !defined(__ASM_UNISTD_H) || defined(__SYSCALL) | ||
| 17 | #define __ASM_UNISTD_H | ||
| 18 | 16 | ||
| 19 | #ifndef __SYSCALL_COMPAT | 17 | #ifndef __SYSCALL_COMPAT |
| 20 | #include <asm-generic/unistd.h> | 18 | #include <asm-generic/unistd.h> |
| @@ -23,5 +21,3 @@ | |||
| 23 | #if defined(__KERNEL__) && defined(CONFIG_COMPAT) | 21 | #if defined(__KERNEL__) && defined(CONFIG_COMPAT) |
| 24 | #include <asm/unistd32.h> | 22 | #include <asm/unistd32.h> |
| 25 | #endif | 23 | #endif |
| 26 | |||
| 27 | #endif /* __ASM_UNISTD_H */ | ||
diff --git a/arch/arm64/include/asm/unistd32.h b/arch/arm64/include/asm/unistd32.h index a50405f5ee42..3ba1f1a90629 100644 --- a/arch/arm64/include/asm/unistd32.h +++ b/arch/arm64/include/asm/unistd32.h | |||
| @@ -16,8 +16,6 @@ | |||
| 16 | * You should have received a copy of the GNU General Public License | 16 | * You should have received a copy of the GNU General Public License |
| 17 | * along with this program. If not, see <http://www.gnu.org/licenses/>. | 17 | * along with this program. If not, see <http://www.gnu.org/licenses/>. |
| 18 | */ | 18 | */ |
| 19 | #if !defined(__ASM_UNISTD32_H) || defined(__SYSCALL) | ||
| 20 | #define __ASM_UNISTD32_H | ||
| 21 | 19 | ||
| 22 | #ifndef __SYSCALL | 20 | #ifndef __SYSCALL |
| 23 | #define __SYSCALL(x, y) | 21 | #define __SYSCALL(x, y) |
| @@ -754,5 +752,3 @@ __SYSCALL(__NR_syncfs, sys_syncfs) | |||
| 754 | #define __ARCH_WANT_SYS_SIGPENDING | 752 | #define __ARCH_WANT_SYS_SIGPENDING |
| 755 | #define __ARCH_WANT_SYS_SIGPROCMASK | 753 | #define __ARCH_WANT_SYS_SIGPROCMASK |
| 756 | #define __ARCH_WANT_COMPAT_SYS_RT_SIGSUSPEND | 754 | #define __ARCH_WANT_COMPAT_SYS_RT_SIGSUSPEND |
| 757 | |||
| 758 | #endif /* __ASM_UNISTD32_H */ | ||
diff --git a/arch/c6x/include/asm/unistd.h b/arch/c6x/include/asm/unistd.h index 6d54ea4262eb..ed2259043eec 100644 --- a/arch/c6x/include/asm/unistd.h +++ b/arch/c6x/include/asm/unistd.h | |||
| @@ -13,8 +13,6 @@ | |||
| 13 | * NON INFRINGEMENT. See the GNU General Public License for | 13 | * NON INFRINGEMENT. See the GNU General Public License for |
| 14 | * more details. | 14 | * more details. |
| 15 | */ | 15 | */ |
| 16 | #if !defined(_ASM_C6X_UNISTD_H) || defined(__SYSCALL) | ||
| 17 | #define _ASM_C6X_UNISTD_H | ||
| 18 | 16 | ||
| 19 | /* Use the standard ABI for syscalls. */ | 17 | /* Use the standard ABI for syscalls. */ |
| 20 | #include <asm-generic/unistd.h> | 18 | #include <asm-generic/unistd.h> |
| @@ -22,5 +20,3 @@ | |||
| 22 | /* C6X-specific syscalls. */ | 20 | /* C6X-specific syscalls. */ |
| 23 | #define __NR_cache_sync (__NR_arch_specific_syscall + 0) | 21 | #define __NR_cache_sync (__NR_arch_specific_syscall + 0) |
| 24 | __SYSCALL(__NR_cache_sync, sys_cache_sync) | 22 | __SYSCALL(__NR_cache_sync, sys_cache_sync) |
| 25 | |||
| 26 | #endif /* _ASM_C6X_UNISTD_H */ | ||
diff --git a/arch/hexagon/include/asm/unistd.h b/arch/hexagon/include/asm/unistd.h index 4d0ecde3665f..c0d5565030ae 100644 --- a/arch/hexagon/include/asm/unistd.h +++ b/arch/hexagon/include/asm/unistd.h | |||
| @@ -18,9 +18,6 @@ | |||
| 18 | * 02110-1301, USA. | 18 | * 02110-1301, USA. |
| 19 | */ | 19 | */ |
| 20 | 20 | ||
| 21 | #if !defined(_ASM_HEXAGON_UNISTD_H) || defined(__SYSCALL) | ||
| 22 | #define _ASM_HEXAGON_UNISTD_H | ||
| 23 | |||
| 24 | /* | 21 | /* |
| 25 | * The kernel pulls this unistd.h in three different ways: | 22 | * The kernel pulls this unistd.h in three different ways: |
| 26 | * 1. the "normal" way which gets all the __NR defines | 23 | * 1. the "normal" way which gets all the __NR defines |
| @@ -32,5 +29,3 @@ | |||
| 32 | #define sys_mmap2 sys_mmap_pgoff | 29 | #define sys_mmap2 sys_mmap_pgoff |
| 33 | 30 | ||
| 34 | #include <asm-generic/unistd.h> | 31 | #include <asm-generic/unistd.h> |
| 35 | |||
| 36 | #endif | ||
diff --git a/arch/openrisc/include/asm/unistd.h b/arch/openrisc/include/asm/unistd.h index 89af3ab5c2e9..437bdbb61b14 100644 --- a/arch/openrisc/include/asm/unistd.h +++ b/arch/openrisc/include/asm/unistd.h | |||
| @@ -16,9 +16,6 @@ | |||
| 16 | * (at your option) any later version. | 16 | * (at your option) any later version. |
| 17 | */ | 17 | */ |
| 18 | 18 | ||
| 19 | #if !defined(__ASM_OPENRISC_UNISTD_H) || defined(__SYSCALL) | ||
| 20 | #define __ASM_OPENRISC_UNISTD_H | ||
| 21 | |||
| 22 | #define __ARCH_HAVE_MMU | 19 | #define __ARCH_HAVE_MMU |
| 23 | 20 | ||
| 24 | #define sys_mmap2 sys_mmap_pgoff | 21 | #define sys_mmap2 sys_mmap_pgoff |
| @@ -27,5 +24,3 @@ | |||
| 27 | 24 | ||
| 28 | #define __NR_or1k_atomic __NR_arch_specific_syscall | 25 | #define __NR_or1k_atomic __NR_arch_specific_syscall |
| 29 | __SYSCALL(__NR_or1k_atomic, sys_or1k_atomic) | 26 | __SYSCALL(__NR_or1k_atomic, sys_or1k_atomic) |
| 30 | |||
| 31 | #endif /* __ASM_OPENRISC_UNISTD_H */ | ||
diff --git a/arch/score/include/asm/unistd.h b/arch/score/include/asm/unistd.h index 4aa957364d4d..a862384e9c16 100644 --- a/arch/score/include/asm/unistd.h +++ b/arch/score/include/asm/unistd.h | |||
| @@ -1,6 +1,3 @@ | |||
| 1 | #if !defined(_ASM_SCORE_UNISTD_H) || defined(__SYSCALL) | ||
| 2 | #define _ASM_SCORE_UNISTD_H | ||
| 3 | |||
| 4 | #define __ARCH_HAVE_MMU | 1 | #define __ARCH_HAVE_MMU |
| 5 | 2 | ||
| 6 | #define __ARCH_WANT_SYSCALL_NO_AT | 3 | #define __ARCH_WANT_SYSCALL_NO_AT |
| @@ -9,5 +6,3 @@ | |||
| 9 | #define __ARCH_WANT_SYSCALL_DEPRECATED | 6 | #define __ARCH_WANT_SYSCALL_DEPRECATED |
| 10 | 7 | ||
| 11 | #include <asm-generic/unistd.h> | 8 | #include <asm-generic/unistd.h> |
| 12 | |||
| 13 | #endif /* _ASM_SCORE_UNISTD_H */ | ||
diff --git a/arch/tile/include/asm/unistd.h b/arch/tile/include/asm/unistd.h index a017246ca0ce..0e1f3e66e492 100644 --- a/arch/tile/include/asm/unistd.h +++ b/arch/tile/include/asm/unistd.h | |||
| @@ -12,9 +12,6 @@ | |||
| 12 | * more details. | 12 | * more details. |
| 13 | */ | 13 | */ |
| 14 | 14 | ||
| 15 | #if !defined(_ASM_TILE_UNISTD_H) || defined(__SYSCALL) | ||
| 16 | #define _ASM_TILE_UNISTD_H | ||
| 17 | |||
| 18 | #if !defined(__LP64__) || defined(__SYSCALL_COMPAT) | 15 | #if !defined(__LP64__) || defined(__SYSCALL_COMPAT) |
| 19 | /* Use the flavor of this syscall that matches the 32-bit API better. */ | 16 | /* Use the flavor of this syscall that matches the 32-bit API better. */ |
| 20 | #define __ARCH_WANT_SYNC_FILE_RANGE2 | 17 | #define __ARCH_WANT_SYNC_FILE_RANGE2 |
| @@ -43,5 +40,3 @@ __SYSCALL(__NR_cmpxchg_badaddr, sys_cmpxchg_badaddr) | |||
| 43 | #endif | 40 | #endif |
| 44 | #define __ARCH_WANT_SYS_NEWFSTATAT | 41 | #define __ARCH_WANT_SYS_NEWFSTATAT |
| 45 | #endif | 42 | #endif |
| 46 | |||
| 47 | #endif /* _ASM_TILE_UNISTD_H */ | ||
diff --git a/arch/unicore32/include/asm/unistd.h b/arch/unicore32/include/asm/unistd.h index 9b2428019961..2abcf61c615d 100644 --- a/arch/unicore32/include/asm/unistd.h +++ b/arch/unicore32/include/asm/unistd.h | |||
| @@ -9,10 +9,6 @@ | |||
| 9 | * it under the terms of the GNU General Public License version 2 as | 9 | * it under the terms of the GNU General Public License version 2 as |
| 10 | * published by the Free Software Foundation. | 10 | * published by the Free Software Foundation. |
| 11 | */ | 11 | */ |
| 12 | #if !defined(__UNICORE_UNISTD_H__) || defined(__SYSCALL) | ||
| 13 | #define __UNICORE_UNISTD_H__ | ||
| 14 | 12 | ||
| 15 | /* Use the standard ABI for syscalls. */ | 13 | /* Use the standard ABI for syscalls. */ |
| 16 | #include <asm-generic/unistd.h> | 14 | #include <asm-generic/unistd.h> |
| 17 | |||
| 18 | #endif /* __UNICORE_UNISTD_H__ */ | ||
diff --git a/include/asm-generic/unistd.h b/include/asm-generic/unistd.h index 3748ec92dcbc..cf22fae8cae1 100644 --- a/include/asm-generic/unistd.h +++ b/include/asm-generic/unistd.h | |||
| @@ -1,6 +1,3 @@ | |||
| 1 | #if !defined(_ASM_GENERIC_UNISTD_H) || defined(__SYSCALL) | ||
| 2 | #define _ASM_GENERIC_UNISTD_H | ||
| 3 | |||
| 4 | #include <asm/bitsperlong.h> | 1 | #include <asm/bitsperlong.h> |
| 5 | 2 | ||
| 6 | /* | 3 | /* |
| @@ -930,4 +927,3 @@ __SYSCALL(__NR_fork, sys_ni_syscall) | |||
| 930 | #endif | 927 | #endif |
| 931 | 928 | ||
| 932 | #endif /* __KERNEL__ */ | 929 | #endif /* __KERNEL__ */ |
| 933 | #endif /* _ASM_GENERIC_UNISTD_H */ | ||
