diff options
| author | Greg Kroah-Hartman <gregkh@suse.de> | 2008-08-18 16:21:04 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-10-17 17:41:10 -0400 |
| commit | 880c9c66a60c0aa4fb4dac2da9679da5f8f41903 (patch) | |
| tree | b5053854a7c97447b554f9cd3afbb32fbb7e478c | |
| parent | 5909f6ea2bc7f785ceb1bed14c670946a536ff2d (diff) | |
USB: remove info() macro from usb network drivers
USB should not be having it's own printk macros, so remove info() and
use the system-wide standard of dev_info() wherever possible.
Cc: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/net/irda/kingsun-sir.c | 3 | ||||
| -rw-r--r-- | drivers/net/irda/ks959-sir.c | 3 | ||||
| -rw-r--r-- | drivers/net/irda/ksdazzle-sir.c | 3 | ||||
| -rw-r--r-- | drivers/net/irda/stir4200.c | 8 | ||||
| -rw-r--r-- | drivers/net/usb/catc.c | 3 | ||||
| -rw-r--r-- | drivers/net/usb/kaweth.c | 19 | ||||
| -rw-r--r-- | drivers/net/usb/rtl8150.c | 15 |
7 files changed, 32 insertions, 22 deletions
diff --git a/drivers/net/irda/kingsun-sir.c b/drivers/net/irda/kingsun-sir.c index 73fe83be34fe..e1429fc6d050 100644 --- a/drivers/net/irda/kingsun-sir.c +++ b/drivers/net/irda/kingsun-sir.c | |||
| @@ -540,7 +540,8 @@ static int kingsun_probe(struct usb_interface *intf, | |||
| 540 | if (ret != 0) | 540 | if (ret != 0) |
| 541 | goto free_mem; | 541 | goto free_mem; |
| 542 | 542 | ||
| 543 | info("IrDA: Registered KingSun/DonShine device %s", net->name); | 543 | dev_info(&net->dev, "IrDA: Registered KingSun/DonShine device %s\n", |
| 544 | net->name); | ||
| 544 | 545 | ||
| 545 | usb_set_intfdata(intf, kingsun); | 546 | usb_set_intfdata(intf, kingsun); |
| 546 | 547 | ||
diff --git a/drivers/net/irda/ks959-sir.c b/drivers/net/irda/ks959-sir.c index 8c257a51341a..2482d61662a2 100644 --- a/drivers/net/irda/ks959-sir.c +++ b/drivers/net/irda/ks959-sir.c | |||
| @@ -801,7 +801,8 @@ static int ks959_probe(struct usb_interface *intf, | |||
| 801 | if (ret != 0) | 801 | if (ret != 0) |
| 802 | goto free_mem; | 802 | goto free_mem; |
| 803 | 803 | ||
| 804 | info("IrDA: Registered KingSun KS-959 device %s", net->name); | 804 | dev_info(&net->dev, "IrDA: Registered KingSun KS-959 device %s\n", |
| 805 | net->name); | ||
| 805 | 806 | ||
| 806 | usb_set_intfdata(intf, kingsun); | 807 | usb_set_intfdata(intf, kingsun); |
| 807 | 808 | ||
diff --git a/drivers/net/irda/ksdazzle-sir.c b/drivers/net/irda/ksdazzle-sir.c index d01a28593ce2..1e0de93fd618 100644 --- a/drivers/net/irda/ksdazzle-sir.c +++ b/drivers/net/irda/ksdazzle-sir.c | |||
| @@ -705,7 +705,8 @@ static int ksdazzle_probe(struct usb_interface *intf, | |||
| 705 | if (ret != 0) | 705 | if (ret != 0) |
| 706 | goto free_mem; | 706 | goto free_mem; |
| 707 | 707 | ||
| 708 | info("IrDA: Registered KingSun/Dazzle device %s", net->name); | 708 | dev_info(&net->dev, "IrDA: Registered KingSun/Dazzle device %s\n", |
| 709 | net->name); | ||
| 709 | 710 | ||
| 710 | usb_set_intfdata(intf, kingsun); | 711 | usb_set_intfdata(intf, kingsun); |
| 711 | 712 | ||
diff --git a/drivers/net/irda/stir4200.c b/drivers/net/irda/stir4200.c index 148ce2803b00..3575804fd7c6 100644 --- a/drivers/net/irda/stir4200.c +++ b/drivers/net/irda/stir4200.c | |||
| @@ -783,8 +783,9 @@ static int stir_transmit_thread(void *arg) | |||
| 783 | 783 | ||
| 784 | if (unlikely(receive_start(stir))) { | 784 | if (unlikely(receive_start(stir))) { |
| 785 | if (net_ratelimit()) | 785 | if (net_ratelimit()) |
| 786 | info("%s: receive usb submit failed", | 786 | dev_info(&dev->dev, |
| 787 | stir->netdev->name); | 787 | "%s: receive usb submit failed\n", |
| 788 | stir->netdev->name); | ||
| 788 | stir->receiving = 0; | 789 | stir->receiving = 0; |
| 789 | msleep(10); | 790 | msleep(10); |
| 790 | continue; | 791 | continue; |
| @@ -1073,7 +1074,8 @@ static int stir_probe(struct usb_interface *intf, | |||
| 1073 | if (ret != 0) | 1074 | if (ret != 0) |
| 1074 | goto err_out2; | 1075 | goto err_out2; |
| 1075 | 1076 | ||
| 1076 | info("IrDA: Registered SigmaTel device %s", net->name); | 1077 | dev_info(&intf->dev, "IrDA: Registered SigmaTel device %s\n", |
| 1078 | net->name); | ||
| 1077 | 1079 | ||
| 1078 | usb_set_intfdata(intf, stir); | 1080 | usb_set_intfdata(intf, stir); |
| 1079 | 1081 | ||
diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index 92ff9c83d9f2..466a89e24444 100644 --- a/drivers/net/usb/catc.c +++ b/drivers/net/usb/catc.c | |||
| @@ -954,7 +954,8 @@ static int __init catc_init(void) | |||
| 954 | { | 954 | { |
| 955 | int result = usb_register(&catc_driver); | 955 | int result = usb_register(&catc_driver); |
| 956 | if (result == 0) | 956 | if (result == 0) |
| 957 | info(DRIVER_VERSION " " DRIVER_DESC); | 957 | printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":" |
| 958 | DRIVER_DESC "\n"); | ||
| 958 | return result; | 959 | return result; |
| 959 | } | 960 | } |
| 960 | 961 | ||
diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index 4f7a0106781e..fdbf3be24fda 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c | |||
| @@ -1016,10 +1016,10 @@ static int kaweth_probe( | |||
| 1016 | */ | 1016 | */ |
| 1017 | 1017 | ||
| 1018 | if (le16_to_cpu(dev->descriptor.bcdDevice) >> 8) { | 1018 | if (le16_to_cpu(dev->descriptor.bcdDevice) >> 8) { |
| 1019 | info("Firmware present in device."); | 1019 | dev_info(&intf->dev, "Firmware present in device.\n"); |
| 1020 | } else { | 1020 | } else { |
| 1021 | /* Download the firmware */ | 1021 | /* Download the firmware */ |
| 1022 | info("Downloading firmware..."); | 1022 | dev_info(&intf->dev, "Downloading firmware...\n"); |
| 1023 | kaweth->firmware_buf = (__u8 *)__get_free_page(GFP_KERNEL); | 1023 | kaweth->firmware_buf = (__u8 *)__get_free_page(GFP_KERNEL); |
| 1024 | if ((result = kaweth_download_firmware(kaweth, | 1024 | if ((result = kaweth_download_firmware(kaweth, |
| 1025 | "kaweth/new_code.bin", | 1025 | "kaweth/new_code.bin", |
| @@ -1061,7 +1061,7 @@ static int kaweth_probe( | |||
| 1061 | } | 1061 | } |
| 1062 | 1062 | ||
| 1063 | /* Device will now disappear for a moment... */ | 1063 | /* Device will now disappear for a moment... */ |
| 1064 | info("Firmware loaded. I'll be back..."); | 1064 | dev_info(&intf->dev, "Firmware loaded. I'll be back...\n"); |
| 1065 | err_fw: | 1065 | err_fw: |
| 1066 | free_page((unsigned long)kaweth->firmware_buf); | 1066 | free_page((unsigned long)kaweth->firmware_buf); |
| 1067 | free_netdev(netdev); | 1067 | free_netdev(netdev); |
| @@ -1075,10 +1075,10 @@ err_fw: | |||
| 1075 | goto err_free_netdev; | 1075 | goto err_free_netdev; |
| 1076 | } | 1076 | } |
| 1077 | 1077 | ||
| 1078 | info("Statistics collection: %x", kaweth->configuration.statistics_mask); | 1078 | dev_info(&intf->dev, "Statistics collection: %x\n", kaweth->configuration.statistics_mask); |
| 1079 | info("Multicast filter limit: %x", kaweth->configuration.max_multicast_filters & ((1 << 15) - 1)); | 1079 | dev_info(&intf->dev, "Multicast filter limit: %x\n", kaweth->configuration.max_multicast_filters & ((1 << 15) - 1)); |
| 1080 | info("MTU: %d", le16_to_cpu(kaweth->configuration.segment_size)); | 1080 | dev_info(&intf->dev, "MTU: %d\n", le16_to_cpu(kaweth->configuration.segment_size)); |
| 1081 | info("Read MAC address %2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x", | 1081 | dev_info(&intf->dev, "Read MAC address %2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x\n", |
| 1082 | (int)kaweth->configuration.hw_addr[0], | 1082 | (int)kaweth->configuration.hw_addr[0], |
| 1083 | (int)kaweth->configuration.hw_addr[1], | 1083 | (int)kaweth->configuration.hw_addr[1], |
| 1084 | (int)kaweth->configuration.hw_addr[2], | 1084 | (int)kaweth->configuration.hw_addr[2], |
| @@ -1174,7 +1174,8 @@ err_fw: | |||
| 1174 | goto err_intfdata; | 1174 | goto err_intfdata; |
| 1175 | } | 1175 | } |
| 1176 | 1176 | ||
| 1177 | info("kaweth interface created at %s", kaweth->net->name); | 1177 | dev_info(&intf->dev, "kaweth interface created at %s\n", |
| 1178 | kaweth->net->name); | ||
| 1178 | 1179 | ||
| 1179 | dbg("Kaweth probe returning."); | 1180 | dbg("Kaweth probe returning."); |
| 1180 | 1181 | ||
| @@ -1205,7 +1206,7 @@ static void kaweth_disconnect(struct usb_interface *intf) | |||
| 1205 | struct kaweth_device *kaweth = usb_get_intfdata(intf); | 1206 | struct kaweth_device *kaweth = usb_get_intfdata(intf); |
| 1206 | struct net_device *netdev; | 1207 | struct net_device *netdev; |
| 1207 | 1208 | ||
| 1208 | info("Unregistering"); | 1209 | dev_info(&intf->dev, "Unregistering\n"); |
| 1209 | 1210 | ||
| 1210 | usb_set_intfdata(intf, NULL); | 1211 | usb_set_intfdata(intf, NULL); |
| 1211 | if (!kaweth) { | 1212 | if (!kaweth) { |
diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index 7726b5e86764..6133401ebc67 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c | |||
| @@ -538,7 +538,8 @@ static void write_bulk_callback(struct urb *urb) | |||
| 538 | if (!netif_device_present(dev->netdev)) | 538 | if (!netif_device_present(dev->netdev)) |
| 539 | return; | 539 | return; |
| 540 | if (urb->status) | 540 | if (urb->status) |
| 541 | info("%s: Tx status %d", dev->netdev->name, urb->status); | 541 | dev_info(&urb->dev->dev, "%s: Tx status %d\n", |
| 542 | dev->netdev->name, urb->status); | ||
| 542 | dev->netdev->trans_start = jiffies; | 543 | dev->netdev->trans_start = jiffies; |
| 543 | netif_wake_queue(dev->netdev); | 544 | netif_wake_queue(dev->netdev); |
| 544 | } | 545 | } |
| @@ -561,7 +562,8 @@ static void intr_callback(struct urb *urb) | |||
| 561 | return; | 562 | return; |
| 562 | /* -EPIPE: should clear the halt */ | 563 | /* -EPIPE: should clear the halt */ |
| 563 | default: | 564 | default: |
| 564 | info("%s: intr status %d", dev->netdev->name, urb->status); | 565 | dev_info(&urb->dev->dev, "%s: intr status %d\n", |
| 566 | dev->netdev->name, urb->status); | ||
| 565 | goto resubmit; | 567 | goto resubmit; |
| 566 | } | 568 | } |
| 567 | 569 | ||
| @@ -710,12 +712,12 @@ static void rtl8150_set_multicast(struct net_device *netdev) | |||
| 710 | netif_stop_queue(netdev); | 712 | netif_stop_queue(netdev); |
| 711 | if (netdev->flags & IFF_PROMISC) { | 713 | if (netdev->flags & IFF_PROMISC) { |
| 712 | dev->rx_creg |= cpu_to_le16(0x0001); | 714 | dev->rx_creg |= cpu_to_le16(0x0001); |
| 713 | info("%s: promiscuous mode", netdev->name); | 715 | dev_info(&netdev->dev, "%s: promiscuous mode\n", netdev->name); |
| 714 | } else if (netdev->mc_count || | 716 | } else if (netdev->mc_count || |
| 715 | (netdev->flags & IFF_ALLMULTI)) { | 717 | (netdev->flags & IFF_ALLMULTI)) { |
| 716 | dev->rx_creg &= cpu_to_le16(0xfffe); | 718 | dev->rx_creg &= cpu_to_le16(0xfffe); |
| 717 | dev->rx_creg |= cpu_to_le16(0x0002); | 719 | dev->rx_creg |= cpu_to_le16(0x0002); |
| 718 | info("%s: allmulti set", netdev->name); | 720 | dev_info(&netdev->dev, "%s: allmulti set\n", netdev->name); |
| 719 | } else { | 721 | } else { |
| 720 | /* ~RX_MULTICAST, ~RX_PROMISCUOUS */ | 722 | /* ~RX_MULTICAST, ~RX_PROMISCUOUS */ |
| 721 | dev->rx_creg &= cpu_to_le16(0x00fc); | 723 | dev->rx_creg &= cpu_to_le16(0x00fc); |
| @@ -947,7 +949,7 @@ static int rtl8150_probe(struct usb_interface *intf, | |||
| 947 | goto out2; | 949 | goto out2; |
| 948 | } | 950 | } |
| 949 | 951 | ||
| 950 | info("%s: rtl8150 is detected", netdev->name); | 952 | dev_info(&intf->dev, "%s: rtl8150 is detected\n", netdev->name); |
| 951 | 953 | ||
| 952 | return 0; | 954 | return 0; |
| 953 | 955 | ||
| @@ -984,7 +986,8 @@ static void rtl8150_disconnect(struct usb_interface *intf) | |||
| 984 | 986 | ||
| 985 | static int __init usb_rtl8150_init(void) | 987 | static int __init usb_rtl8150_init(void) |
| 986 | { | 988 | { |
| 987 | info(DRIVER_DESC " " DRIVER_VERSION); | 989 | printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":" |
| 990 | DRIVER_DESC "\n"); | ||
| 988 | return usb_register(&rtl8150_driver); | 991 | return usb_register(&rtl8150_driver); |
| 989 | } | 992 | } |
| 990 | 993 | ||
