aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYoungJun Cho <yj44.cho@samsung.com>2014-08-13 22:22:36 -0400
committerInki Dae <daeinki@gmail.com>2014-09-19 11:56:08 -0400
commit8525b5ec90a58b3e56709ffa1667d6593dbe24c3 (patch)
treed5f2339a1f18e4ed9d012b409a7a5f97d2f0d725
parent8337486a8fda53e5f46b3cb2b4eb3272608348cb (diff)
drm/exynos: dsi: fix exynos_dsi_set_pll() wrong return value
The type of this function is unsigned long, and it is expected to return proper fout value or zero if something is wrong. So this patch fixes wrong return value for error cases. Signed-off-by: YoungJun Cho <yj44.cho@samsung.com> Acked-by: Inki Dae <inki.dae@samsung.com> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> Acked-by: Andrzej Hajda <a.hajda@samsung.com> Signed-off-by: Inki Dae <inki.dae@samsung.com>
-rw-r--r--drivers/gpu/drm/exynos/exynos_drm_dsi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 442aa2d00132..d3393098f424 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -421,7 +421,7 @@ static unsigned long exynos_dsi_set_pll(struct exynos_dsi *dsi,
421 if (!fout) { 421 if (!fout) {
422 dev_err(dsi->dev, 422 dev_err(dsi->dev,
423 "failed to find PLL PMS for requested frequency\n"); 423 "failed to find PLL PMS for requested frequency\n");
424 return -EFAULT; 424 return 0;
425 } 425 }
426 dev_dbg(dsi->dev, "PLL freq %lu, (p %d, m %d, s %d)\n", fout, p, m, s); 426 dev_dbg(dsi->dev, "PLL freq %lu, (p %d, m %d, s %d)\n", fout, p, m, s);
427 427
@@ -453,7 +453,7 @@ static unsigned long exynos_dsi_set_pll(struct exynos_dsi *dsi,
453 do { 453 do {
454 if (timeout-- == 0) { 454 if (timeout-- == 0) {
455 dev_err(dsi->dev, "PLL failed to stabilize\n"); 455 dev_err(dsi->dev, "PLL failed to stabilize\n");
456 return -EFAULT; 456 return 0;
457 } 457 }
458 reg = readl(dsi->reg_base + DSIM_STATUS_REG); 458 reg = readl(dsi->reg_base + DSIM_STATUS_REG);
459 } while ((reg & DSIM_PLL_STABLE) == 0); 459 } while ((reg & DSIM_PLL_STABLE) == 0);