diff options
author | Manuel Schölling <manuel.schoelling@gmx.de> | 2014-06-07 17:57:25 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-06-11 03:12:04 -0400 |
commit | 84a7c0b1db1c17d5ded8d3800228a608e1070b40 (patch) | |
tree | 95c67ab040a0fe4ade6d48902d6b5309c7f60370 | |
parent | 2346829e641b804ece9ac9298136b56d9567c278 (diff) |
dns_resolver: assure that dns_query() result is null-terminated
dns_query() credulously assumes that keys are null-terminated and
returns a copy of a memory block that is off by one.
Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/dns_resolver/dns_query.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/dns_resolver/dns_query.c b/net/dns_resolver/dns_query.c index e7b6d53eef88..6853d22ebc07 100644 --- a/net/dns_resolver/dns_query.c +++ b/net/dns_resolver/dns_query.c | |||
@@ -149,7 +149,9 @@ int dns_query(const char *type, const char *name, size_t namelen, | |||
149 | if (!*_result) | 149 | if (!*_result) |
150 | goto put; | 150 | goto put; |
151 | 151 | ||
152 | memcpy(*_result, upayload->data, len + 1); | 152 | memcpy(*_result, upayload->data, len); |
153 | *_result[len] = '\0'; | ||
154 | |||
153 | if (_expiry) | 155 | if (_expiry) |
154 | *_expiry = rkey->expiry; | 156 | *_expiry = rkey->expiry; |
155 | 157 | ||