diff options
author | Dmitry Torokhov <dtor@chromium.org> | 2014-11-14 16:32:56 -0500 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2014-11-27 08:34:47 -0500 |
commit | 842e528e1abf1edaa6467c6dbda299ec724cb42a (patch) | |
tree | cc91183b4010bf35c73bd80395654def52f68d47 | |
parent | d0c3d95ae27a54f283a7acc5ead5bd8a15441a92 (diff) |
gpio: tz1090: Fix error handling of irq_of_parse_and_map
irq_of_parse_and_map() returns 0 on error, so testing for negative
result never works.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Acked-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r-- | drivers/gpio/gpio-tz1090.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-tz1090.c b/drivers/gpio/gpio-tz1090.c index 5246a60eff6d..6107d0682fd6 100644 --- a/drivers/gpio/gpio-tz1090.c +++ b/drivers/gpio/gpio-tz1090.c | |||
@@ -446,7 +446,7 @@ static int tz1090_gpio_bank_probe(struct tz1090_gpio_bank_info *info) | |||
446 | bank->irq = irq_of_parse_and_map(np, 0); | 446 | bank->irq = irq_of_parse_and_map(np, 0); |
447 | 447 | ||
448 | /* The interrupt is optional (it may be used by another core on chip) */ | 448 | /* The interrupt is optional (it may be used by another core on chip) */ |
449 | if (bank->irq < 0) { | 449 | if (!bank->irq) { |
450 | dev_info(dev, "IRQ not provided for bank %u, IRQs disabled\n", | 450 | dev_info(dev, "IRQ not provided for bank %u, IRQs disabled\n", |
451 | info->index); | 451 | info->index); |
452 | return 0; | 452 | return 0; |