aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2015-01-27 11:29:18 -0500
committerJesper Nilsson <jespern@axis.com>2015-02-14 12:54:04 -0500
commit83f1588e9f770832b3446324110ff5b71e5f017c (patch)
treec47754d4be84addce632b01bcac46b4810d2f931
parent458e3192455547bb4dce27e060c24cc22a2bd87d (diff)
CRIS: macro whitespace fixes in uaccess.h
While working on arch/cris/include/asm/uaccess.h, I noticed that some macros within this header are made harder to read because they violate a coding style rule: space is missing after comma. Fix it up. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
-rw-r--r--arch/cris/include/asm/uaccess.h113
1 files changed, 58 insertions, 55 deletions
diff --git a/arch/cris/include/asm/uaccess.h b/arch/cris/include/asm/uaccess.h
index 9cf5a23baed3..a21344ab8616 100644
--- a/arch/cris/include/asm/uaccess.h
+++ b/arch/cris/include/asm/uaccess.h
@@ -47,12 +47,13 @@
47#define get_fs() (current_thread_info()->addr_limit) 47#define get_fs() (current_thread_info()->addr_limit)
48#define set_fs(x) (current_thread_info()->addr_limit = (x)) 48#define set_fs(x) (current_thread_info()->addr_limit = (x))
49 49
50#define segment_eq(a,b) ((a).seg == (b).seg) 50#define segment_eq(a, b) ((a).seg == (b).seg)
51 51
52#define __kernel_ok (segment_eq(get_fs(), KERNEL_DS)) 52#define __kernel_ok (segment_eq(get_fs(), KERNEL_DS))
53#define __user_ok(addr,size) (((size) <= TASK_SIZE)&&((addr) <= TASK_SIZE-(size))) 53#define __user_ok(addr, size) \
54#define __access_ok(addr,size) (__kernel_ok || __user_ok((addr),(size))) 54 (((size) <= TASK_SIZE)&&((addr) <= TASK_SIZE-(size)))
55#define access_ok(type,addr,size) __access_ok((unsigned long)(addr),(size)) 55#define __access_ok(addr, size) (__kernel_ok || __user_ok((addr), (size)))
56#define access_ok(type, addr, size) __access_ok((unsigned long)(addr), (size))
56 57
57#include <arch/uaccess.h> 58#include <arch/uaccess.h>
58 59
@@ -92,56 +93,56 @@ struct exception_table_entry
92 * CRIS, we can just do these as direct assignments. (Of course, the 93 * CRIS, we can just do these as direct assignments. (Of course, the
93 * exception handling means that it's no longer "just"...) 94 * exception handling means that it's no longer "just"...)
94 */ 95 */
95#define get_user(x,ptr) \ 96#define get_user(x, ptr) \
96 __get_user_check((x),(ptr),sizeof(*(ptr))) 97 __get_user_check((x), (ptr), sizeof(*(ptr)))
97#define put_user(x,ptr) \ 98#define put_user(x, ptr) \
98 __put_user_check((__typeof__(*(ptr)))(x),(ptr),sizeof(*(ptr))) 99 __put_user_check((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
99 100
100#define __get_user(x,ptr) \ 101#define __get_user(x, ptr) \
101 __get_user_nocheck((x),(ptr),sizeof(*(ptr))) 102 __get_user_nocheck((x), (ptr), sizeof(*(ptr)))
102#define __put_user(x,ptr) \ 103#define __put_user(x, ptr) \
103 __put_user_nocheck((__typeof__(*(ptr)))(x),(ptr),sizeof(*(ptr))) 104 __put_user_nocheck((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
104 105
105extern long __put_user_bad(void); 106extern long __put_user_bad(void);
106 107
107#define __put_user_size(x,ptr,size,retval) \ 108#define __put_user_size(x, ptr, size, retval) \
108do { \ 109do { \
109 retval = 0; \ 110 retval = 0; \
110 switch (size) { \ 111 switch (size) { \
111 case 1: __put_user_asm(x,ptr,retval,"move.b"); break; \ 112 case 1: __put_user_asm(x, ptr, retval, "move.b"); break; \
112 case 2: __put_user_asm(x,ptr,retval,"move.w"); break; \ 113 case 2: __put_user_asm(x, ptr, retval, "move.w"); break; \
113 case 4: __put_user_asm(x,ptr,retval,"move.d"); break; \ 114 case 4: __put_user_asm(x, ptr, retval, "move.d"); break; \
114 case 8: __put_user_asm_64(x,ptr,retval); break; \ 115 case 8: __put_user_asm_64(x, ptr, retval); break; \
115 default: __put_user_bad(); \ 116 default: __put_user_bad(); \
116 } \ 117 } \
117} while (0) 118} while (0)
118 119
119#define __get_user_size(x,ptr,size,retval) \ 120#define __get_user_size(x, ptr, size, retval) \
120do { \ 121do { \
121 retval = 0; \ 122 retval = 0; \
122 switch (size) { \ 123 switch (size) { \
123 case 1: __get_user_asm(x,ptr,retval,"move.b"); break; \ 124 case 1: __get_user_asm(x, ptr, retval, "move.b"); break; \
124 case 2: __get_user_asm(x,ptr,retval,"move.w"); break; \ 125 case 2: __get_user_asm(x, ptr, retval, "move.w"); break; \
125 case 4: __get_user_asm(x,ptr,retval,"move.d"); break; \ 126 case 4: __get_user_asm(x, ptr, retval, "move.d"); break; \
126 case 8: __get_user_asm_64(x,ptr,retval); break; \ 127 case 8: __get_user_asm_64(x, ptr, retval); break; \
127 default: (x) = __get_user_bad(); \ 128 default: (x) = __get_user_bad(); \
128 } \ 129 } \
129} while (0) 130} while (0)
130 131
131#define __put_user_nocheck(x,ptr,size) \ 132#define __put_user_nocheck(x, ptr, size) \
132({ \ 133({ \
133 long __pu_err; \ 134 long __pu_err; \
134 __put_user_size((x),(ptr),(size),__pu_err); \ 135 __put_user_size((x), (ptr), (size), __pu_err); \
135 __pu_err; \ 136 __pu_err; \
136}) 137})
137 138
138#define __put_user_check(x,ptr,size) \ 139#define __put_user_check(x, ptr, size) \
139({ \ 140({ \
140 long __pu_err = -EFAULT; \ 141 long __pu_err = -EFAULT; \
141 __typeof__(*(ptr)) *__pu_addr = (ptr); \ 142 __typeof__(*(ptr)) *__pu_addr = (ptr); \
142 if (access_ok(VERIFY_WRITE,__pu_addr,size)) \ 143 if (access_ok(VERIFY_WRITE, __pu_addr, size)) \
143 __put_user_size((x),__pu_addr,(size),__pu_err); \ 144 __put_user_size((x), __pu_addr, (size), __pu_err); \
144 __pu_err; \ 145 __pu_err; \
145}) 146})
146 147
147struct __large_struct { unsigned long buf[100]; }; 148struct __large_struct { unsigned long buf[100]; };
@@ -149,20 +150,20 @@ struct __large_struct { unsigned long buf[100]; };
149 150
150 151
151 152
152#define __get_user_nocheck(x,ptr,size) \ 153#define __get_user_nocheck(x, ptr, size) \
153({ \ 154({ \
154 long __gu_err, __gu_val; \ 155 long __gu_err, __gu_val; \
155 __get_user_size(__gu_val,(ptr),(size),__gu_err); \ 156 __get_user_size(__gu_val, (ptr), (size), __gu_err); \
156 (x) = (__force __typeof__(*(ptr)))__gu_val; \ 157 (x) = (__force __typeof__(*(ptr)))__gu_val; \
157 __gu_err; \ 158 __gu_err; \
158}) 159})
159 160
160#define __get_user_check(x,ptr,size) \ 161#define __get_user_check(x, ptr, size) \
161({ \ 162({ \
162 long __gu_err = -EFAULT, __gu_val = 0; \ 163 long __gu_err = -EFAULT, __gu_val = 0; \
163 const __typeof__(*(ptr)) *__gu_addr = (ptr); \ 164 const __typeof__(*(ptr)) *__gu_addr = (ptr); \
164 if (access_ok(VERIFY_READ,__gu_addr,size)) \ 165 if (access_ok(VERIFY_READ, __gu_addr, size)) \
165 __get_user_size(__gu_val,__gu_addr,(size),__gu_err); \ 166 __get_user_size(__gu_val, __gu_addr, (size), __gu_err); \
166 (x) = (__force __typeof__(*(ptr)))__gu_val; \ 167 (x) = (__force __typeof__(*(ptr)))__gu_val; \
167 __gu_err; \ 168 __gu_err; \
168}) 169})
@@ -180,7 +181,7 @@ static inline unsigned long
180__generic_copy_to_user(void __user *to, const void *from, unsigned long n) 181__generic_copy_to_user(void __user *to, const void *from, unsigned long n)
181{ 182{
182 if (access_ok(VERIFY_WRITE, to, n)) 183 if (access_ok(VERIFY_WRITE, to, n))
183 return __copy_user(to,from,n); 184 return __copy_user(to, from, n);
184 return n; 185 return n;
185} 186}
186 187
@@ -188,7 +189,7 @@ static inline unsigned long
188__generic_copy_from_user(void *to, const void __user *from, unsigned long n) 189__generic_copy_from_user(void *to, const void __user *from, unsigned long n)
189{ 190{
190 if (access_ok(VERIFY_READ, from, n)) 191 if (access_ok(VERIFY_READ, from, n))
191 return __copy_user_zeroing(to,from,n); 192 return __copy_user_zeroing(to, from, n);
192 return n; 193 return n;
193} 194}
194 195
@@ -196,7 +197,7 @@ static inline unsigned long
196__generic_clear_user(void __user *to, unsigned long n) 197__generic_clear_user(void __user *to, unsigned long n)
197{ 198{
198 if (access_ok(VERIFY_WRITE, to, n)) 199 if (access_ok(VERIFY_WRITE, to, n))
199 return __do_clear_user(to,n); 200 return __do_clear_user(to, n);
200 return n; 201 return n;
201} 202}
202 203
@@ -373,29 +374,31 @@ static inline unsigned long
373__generic_copy_from_user_nocheck(void *to, const void __user *from, 374__generic_copy_from_user_nocheck(void *to, const void __user *from,
374 unsigned long n) 375 unsigned long n)
375{ 376{
376 return __copy_user_zeroing(to,from,n); 377 return __copy_user_zeroing(to, from, n);
377} 378}
378 379
379static inline unsigned long 380static inline unsigned long
380__generic_copy_to_user_nocheck(void __user *to, const void *from, 381__generic_copy_to_user_nocheck(void __user *to, const void *from,
381 unsigned long n) 382 unsigned long n)
382{ 383{
383 return __copy_user(to,from,n); 384 return __copy_user(to, from, n);
384} 385}
385 386
386static inline unsigned long 387static inline unsigned long
387__generic_clear_user_nocheck(void __user *to, unsigned long n) 388__generic_clear_user_nocheck(void __user *to, unsigned long n)
388{ 389{
389 return __do_clear_user(to,n); 390 return __do_clear_user(to, n);
390} 391}
391 392
392/* without checking */ 393/* without checking */
393 394
394#define __copy_to_user(to,from,n) __generic_copy_to_user_nocheck((to),(from),(n)) 395#define __copy_to_user(to, from, n) \
395#define __copy_from_user(to,from,n) __generic_copy_from_user_nocheck((to),(from),(n)) 396 __generic_copy_to_user_nocheck((to), (from), (n))
397#define __copy_from_user(to, from, n) \
398 __generic_copy_from_user_nocheck((to), (from), (n))
396#define __copy_to_user_inatomic __copy_to_user 399#define __copy_to_user_inatomic __copy_to_user
397#define __copy_from_user_inatomic __copy_from_user 400#define __copy_from_user_inatomic __copy_from_user
398#define __clear_user(to,n) __generic_clear_user_nocheck((to),(n)) 401#define __clear_user(to, n) __generic_clear_user_nocheck((to), (n))
399 402
400#define strlen_user(str) strnlen_user((str), 0x7ffffffe) 403#define strlen_user(str) strnlen_user((str), 0x7ffffffe)
401 404