diff options
| author | David S. Miller <davem@davemloft.net> | 2011-04-17 19:48:53 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-04-17 19:48:53 -0400 |
| commit | 81b424d9e2ef815b2035d4c2be0bc41dddbebc06 (patch) | |
| tree | 7b2b1b0cc42a43b6fffac0b1e208c04e3574bfc8 | |
| parent | 07f46f80f4ca4ddb700ff40a19876ba1b3242917 (diff) | |
isdn: mISDN: socket: Fix set-but-unused variables.
The variable 'len' is set but unused in data_sock_getsockopt().
The code should use 'len' to validate that the user's socket option is
indeed the right size.
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/isdn/mISDN/socket.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c index 7446d8b4282d..8e325227b4c0 100644 --- a/drivers/isdn/mISDN/socket.c +++ b/drivers/isdn/mISDN/socket.c | |||
| @@ -457,6 +457,9 @@ static int data_sock_getsockopt(struct socket *sock, int level, int optname, | |||
| 457 | if (get_user(len, optlen)) | 457 | if (get_user(len, optlen)) |
| 458 | return -EFAULT; | 458 | return -EFAULT; |
| 459 | 459 | ||
| 460 | if (len != sizeof(char)) | ||
| 461 | return -EINVAL; | ||
| 462 | |||
| 460 | switch (optname) { | 463 | switch (optname) { |
| 461 | case MISDN_TIME_STAMP: | 464 | case MISDN_TIME_STAMP: |
| 462 | if (_pms(sk)->cmask & MISDN_TIME_STAMP) | 465 | if (_pms(sk)->cmask & MISDN_TIME_STAMP) |
