diff options
author | Michael Grzeschik <m.grzeschik@pengutronix.de> | 2012-09-12 07:58:00 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-09-12 13:58:37 -0400 |
commit | 7f67c38bdcb6d8bce02e10521fbf1618b586319f (patch) | |
tree | f7a1f98192be0af83c21dbda5f524b3238a7c0c1 | |
parent | fea7a08acb13524b47711625eebea40a0ede69a0 (diff) |
usb: chipidea: udc: fix setup of endpoint maxpacket size
This patch changes the setup of the endpoint maxpacket size. All non control
endpoints are initialized with an undefined ((unsigned short)~0) maxpacket
size. The maxpacket size of Endpoint 0 will be kept at CTRL_PAYLOAD_MAX.
Some gadget drivers check for the maxpacket size before they enable the
endpoint, which leads to a wrong state in these drivers.
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/usb/chipidea/udc.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index c7a032a4f0c5..7801a3f8be90 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c | |||
@@ -1455,7 +1455,12 @@ static int init_eps(struct ci13xxx *ci) | |||
1455 | 1455 | ||
1456 | mEp->ep.name = mEp->name; | 1456 | mEp->ep.name = mEp->name; |
1457 | mEp->ep.ops = &usb_ep_ops; | 1457 | mEp->ep.ops = &usb_ep_ops; |
1458 | mEp->ep.maxpacket = CTRL_PAYLOAD_MAX; | 1458 | /* |
1459 | * for ep0: maxP defined in desc, for other | ||
1460 | * eps, maxP is set by epautoconfig() called | ||
1461 | * by gadget layer | ||
1462 | */ | ||
1463 | mEp->ep.maxpacket = (unsigned short)~0; | ||
1459 | 1464 | ||
1460 | INIT_LIST_HEAD(&mEp->qh.queue); | 1465 | INIT_LIST_HEAD(&mEp->qh.queue); |
1461 | mEp->qh.ptr = dma_pool_alloc(ci->qh_pool, GFP_KERNEL, | 1466 | mEp->qh.ptr = dma_pool_alloc(ci->qh_pool, GFP_KERNEL, |
@@ -1475,6 +1480,7 @@ static int init_eps(struct ci13xxx *ci) | |||
1475 | else | 1480 | else |
1476 | ci->ep0in = mEp; | 1481 | ci->ep0in = mEp; |
1477 | 1482 | ||
1483 | mEp->ep.maxpacket = CTRL_PAYLOAD_MAX; | ||
1478 | continue; | 1484 | continue; |
1479 | } | 1485 | } |
1480 | 1486 | ||