diff options
| author | Steven Rostedt <srostedt@redhat.com> | 2009-08-06 19:53:18 -0400 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-08-07 02:50:29 -0400 |
| commit | 7dbdee2e9a2ac42ea5135801bcc9d1a8e3f672aa (patch) | |
| tree | df94010b7388d14432269c0dfa958b9ca4b86a4b | |
| parent | 469535a598f28c13a2a42037e1b778f671af1d16 (diff) | |
tracing: Fix recordmcount.pl to handle sections with only weak functions
Roland Dreier found that a section that contained only a weak
function in one of the staging drivers and this caused
recordmcount.pl to spit out a warning and fail.
Although it is strange that a driver would have a weak function, and
this function only be used in one place, it should not be something
to make recordmcount.pl fail.
This patch fixes the issue in a simple manner: if only weak
functions exist in a section, then that section will not be
recorded.
Reported-by: Roland Dreier <rdreier@cisco.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
| -rwxr-xr-x | scripts/recordmcount.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl index 4889c44d71b5..911ba7ffab84 100755 --- a/scripts/recordmcount.pl +++ b/scripts/recordmcount.pl | |||
| @@ -393,7 +393,7 @@ while (<IN>) { | |||
| 393 | $read_function = 0; | 393 | $read_function = 0; |
| 394 | } | 394 | } |
| 395 | # print out any recorded offsets | 395 | # print out any recorded offsets |
| 396 | update_funcs() if ($text_found); | 396 | update_funcs() if (defined($ref_func)); |
| 397 | 397 | ||
| 398 | # reset all markers and arrays | 398 | # reset all markers and arrays |
| 399 | $text_found = 0; | 399 | $text_found = 0; |
| @@ -444,7 +444,7 @@ while (<IN>) { | |||
| 444 | } | 444 | } |
| 445 | 445 | ||
| 446 | # dump out anymore offsets that may have been found | 446 | # dump out anymore offsets that may have been found |
| 447 | update_funcs() if ($text_found); | 447 | update_funcs() if (defined($ref_func)); |
| 448 | 448 | ||
| 449 | # If we did not find any mcount callers, we are done (do nothing). | 449 | # If we did not find any mcount callers, we are done (do nothing). |
| 450 | if (!$opened) { | 450 | if (!$opened) { |
