diff options
author | Jens Axboe <axboe@fb.com> | 2014-11-17 12:41:57 -0500 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2014-11-17 12:41:57 -0500 |
commit | 7c7f2f2bc9a63f9605a16eabac59fc655dfe7c9a (patch) | |
tree | 5d3f60e0b52447eded55ebf8d649e19f0b4f7471 | |
parent | 1a3b595a281a44be4074fe33b317a0a4854b4197 (diff) |
blk-mq: add blk_mq_free_hctx_request()
It's silly to use blk_mq_free_request() which in turn maps the
request to the hardware queue, for places where we already know
what the hardware queue is. This saves us an extra mapping of a
hardware queue on request completion, if the caller knows this
information already.
Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r-- | block/blk-mq.c | 17 | ||||
-rw-r--r-- | include/linux/blk-mq.h | 1 |
2 files changed, 13 insertions, 5 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c index fdf12152946e..4347aa2be6ae 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c | |||
@@ -269,16 +269,23 @@ static void __blk_mq_free_request(struct blk_mq_hw_ctx *hctx, | |||
269 | blk_mq_queue_exit(q); | 269 | blk_mq_queue_exit(q); |
270 | } | 270 | } |
271 | 271 | ||
272 | void blk_mq_free_request(struct request *rq) | 272 | void blk_mq_free_hctx_request(struct blk_mq_hw_ctx *hctx, struct request *rq) |
273 | { | 273 | { |
274 | struct blk_mq_ctx *ctx = rq->mq_ctx; | 274 | struct blk_mq_ctx *ctx = rq->mq_ctx; |
275 | struct blk_mq_hw_ctx *hctx; | ||
276 | struct request_queue *q = rq->q; | ||
277 | 275 | ||
278 | ctx->rq_completed[rq_is_sync(rq)]++; | 276 | ctx->rq_completed[rq_is_sync(rq)]++; |
279 | |||
280 | hctx = q->mq_ops->map_queue(q, ctx->cpu); | ||
281 | __blk_mq_free_request(hctx, ctx, rq); | 277 | __blk_mq_free_request(hctx, ctx, rq); |
278 | |||
279 | } | ||
280 | EXPORT_SYMBOL_GPL(blk_mq_free_hctx_request); | ||
281 | |||
282 | void blk_mq_free_request(struct request *rq) | ||
283 | { | ||
284 | struct blk_mq_hw_ctx *hctx; | ||
285 | struct request_queue *q = rq->q; | ||
286 | |||
287 | hctx = q->mq_ops->map_queue(q, rq->mq_ctx->cpu); | ||
288 | blk_mq_free_hctx_request(hctx, rq); | ||
282 | } | 289 | } |
283 | EXPORT_SYMBOL_GPL(blk_mq_free_request); | 290 | EXPORT_SYMBOL_GPL(blk_mq_free_request); |
284 | 291 | ||
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h index c3b64ec5321e..fb0a4fb3dc2b 100644 --- a/include/linux/blk-mq.h +++ b/include/linux/blk-mq.h | |||
@@ -169,6 +169,7 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule); | |||
169 | void blk_mq_insert_request(struct request *, bool, bool, bool); | 169 | void blk_mq_insert_request(struct request *, bool, bool, bool); |
170 | void blk_mq_run_queues(struct request_queue *q, bool async); | 170 | void blk_mq_run_queues(struct request_queue *q, bool async); |
171 | void blk_mq_free_request(struct request *rq); | 171 | void blk_mq_free_request(struct request *rq); |
172 | void blk_mq_free_hctx_request(struct blk_mq_hw_ctx *, struct request *rq); | ||
172 | bool blk_mq_can_queue(struct blk_mq_hw_ctx *); | 173 | bool blk_mq_can_queue(struct blk_mq_hw_ctx *); |
173 | struct request *blk_mq_alloc_request(struct request_queue *q, int rw, | 174 | struct request *blk_mq_alloc_request(struct request_queue *q, int rw, |
174 | gfp_t gfp, bool reserved); | 175 | gfp_t gfp, bool reserved); |