diff options
| author | Paul Gortmaker <paul.gortmaker@windriver.com> | 2011-04-13 02:30:08 -0400 |
|---|---|---|
| committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2011-04-17 23:06:45 -0400 |
| commit | 7c7a81b53e581d727d069cc45df5510516faac31 (patch) | |
| tree | c62c2d3acc53987ef0cc569de15dde744eed8e82 | |
| parent | 8f3dda75cb942acc049adb2c95a6e5f4c3a8a410 (diff) | |
powerpc/kexec: Fix regression causing compile failure on UP
Recent commit b987812b3fcaf70fdf0037589e5d2f5f2453e6ce caused
a compile failure on UP because a considerably large block
of the file was included within CONFIG_SMP, hence making a stub
function not exposed on UP builds when it needed to be.
Relocate the stub to the #else /* ! CONFIG_SMP */ section
and also annotate the relevant else/endif so that nobody
else falls into the same trap I did.
Reported-by: Michael Guntsche <mike@it-loops.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
| -rw-r--r-- | arch/powerpc/kernel/crash.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c index 3d3d416339dd..5b5e1f002a8e 100644 --- a/arch/powerpc/kernel/crash.c +++ b/arch/powerpc/kernel/crash.c | |||
| @@ -163,7 +163,7 @@ static void crash_kexec_prepare_cpus(int cpu) | |||
| 163 | } | 163 | } |
| 164 | 164 | ||
| 165 | /* wait for all the CPUs to hit real mode but timeout if they don't come in */ | 165 | /* wait for all the CPUs to hit real mode but timeout if they don't come in */ |
| 166 | #if defined(CONFIG_PPC_STD_MMU_64) && defined(CONFIG_SMP) | 166 | #ifdef CONFIG_PPC_STD_MMU_64 |
| 167 | static void crash_kexec_wait_realmode(int cpu) | 167 | static void crash_kexec_wait_realmode(int cpu) |
| 168 | { | 168 | { |
| 169 | unsigned int msecs; | 169 | unsigned int msecs; |
| @@ -188,9 +188,7 @@ static void crash_kexec_wait_realmode(int cpu) | |||
| 188 | } | 188 | } |
| 189 | mb(); | 189 | mb(); |
| 190 | } | 190 | } |
| 191 | #else | 191 | #endif /* CONFIG_PPC_STD_MMU_64 */ |
| 192 | static inline void crash_kexec_wait_realmode(int cpu) {} | ||
| 193 | #endif | ||
| 194 | 192 | ||
| 195 | /* | 193 | /* |
| 196 | * This function will be called by secondary cpus or by kexec cpu | 194 | * This function will be called by secondary cpus or by kexec cpu |
| @@ -235,7 +233,9 @@ void crash_kexec_secondary(struct pt_regs *regs) | |||
| 235 | crash_ipi_callback(regs); | 233 | crash_ipi_callback(regs); |
| 236 | } | 234 | } |
| 237 | 235 | ||
| 238 | #else | 236 | #else /* ! CONFIG_SMP */ |
| 237 | static inline void crash_kexec_wait_realmode(int cpu) {} | ||
| 238 | |||
| 239 | static void crash_kexec_prepare_cpus(int cpu) | 239 | static void crash_kexec_prepare_cpus(int cpu) |
| 240 | { | 240 | { |
| 241 | /* | 241 | /* |
| @@ -255,7 +255,7 @@ void crash_kexec_secondary(struct pt_regs *regs) | |||
| 255 | { | 255 | { |
| 256 | cpus_in_sr = CPU_MASK_NONE; | 256 | cpus_in_sr = CPU_MASK_NONE; |
| 257 | } | 257 | } |
| 258 | #endif | 258 | #endif /* CONFIG_SMP */ |
| 259 | 259 | ||
| 260 | /* | 260 | /* |
| 261 | * Register a function to be called on shutdown. Only use this if you | 261 | * Register a function to be called on shutdown. Only use this if you |
