diff options
author | Rob Herring <robh@kernel.org> | 2015-01-09 21:34:36 -0500 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2015-01-16 09:04:38 -0500 |
commit | 7b09777c187dcbe3e0f4f53890eb2f6953801d88 (patch) | |
tree | 8f1a131f68d8f83d53e322e2c7b21c4883edb6d8 | |
parent | 250215ccf6def938f7b4f037185b8277eb54bcda (diff) |
MIPS: Add struct pci_ops member names to initialization
Some instances of pci_ops initialization rely on the read/write members'
location in the struct. This is fragile and may break when adding new
members to the beginning of the struct.
[ralf@linux-mips.org: indent = with tabs for consistency.]
Signed-off-by: Rob Herring <robh@kernel.org>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-pci@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>
Patchwork: https://patchwork.linux-mips.org/patch/8915/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
-rw-r--r-- | arch/mips/pci/pci-bcm1480.c | 4 | ||||
-rw-r--r-- | arch/mips/pci/pci-octeon.c | 4 | ||||
-rw-r--r-- | arch/mips/pci/pcie-octeon.c | 12 |
3 files changed, 10 insertions, 10 deletions
diff --git a/arch/mips/pci/pci-bcm1480.c b/arch/mips/pci/pci-bcm1480.c index 5ec2a7bae02c..f97e169393bc 100644 --- a/arch/mips/pci/pci-bcm1480.c +++ b/arch/mips/pci/pci-bcm1480.c | |||
@@ -173,8 +173,8 @@ static int bcm1480_pcibios_write(struct pci_bus *bus, unsigned int devfn, | |||
173 | } | 173 | } |
174 | 174 | ||
175 | struct pci_ops bcm1480_pci_ops = { | 175 | struct pci_ops bcm1480_pci_ops = { |
176 | bcm1480_pcibios_read, | 176 | .read = bcm1480_pcibios_read, |
177 | bcm1480_pcibios_write, | 177 | .write = bcm1480_pcibios_write, |
178 | }; | 178 | }; |
179 | 179 | ||
180 | static struct resource bcm1480_mem_resource = { | 180 | static struct resource bcm1480_mem_resource = { |
diff --git a/arch/mips/pci/pci-octeon.c b/arch/mips/pci/pci-octeon.c index d07e04121cc6..a04af55d89f1 100644 --- a/arch/mips/pci/pci-octeon.c +++ b/arch/mips/pci/pci-octeon.c | |||
@@ -327,8 +327,8 @@ static int octeon_write_config(struct pci_bus *bus, unsigned int devfn, | |||
327 | 327 | ||
328 | 328 | ||
329 | static struct pci_ops octeon_pci_ops = { | 329 | static struct pci_ops octeon_pci_ops = { |
330 | octeon_read_config, | 330 | .read = octeon_read_config, |
331 | octeon_write_config, | 331 | .write = octeon_write_config, |
332 | }; | 332 | }; |
333 | 333 | ||
334 | static struct resource octeon_pci_mem_resource = { | 334 | static struct resource octeon_pci_mem_resource = { |
diff --git a/arch/mips/pci/pcie-octeon.c b/arch/mips/pci/pcie-octeon.c index 5e36c33e5543..1bb0b2bf8d6e 100644 --- a/arch/mips/pci/pcie-octeon.c +++ b/arch/mips/pci/pcie-octeon.c | |||
@@ -1792,8 +1792,8 @@ static int octeon_dummy_write_config(struct pci_bus *bus, unsigned int devfn, | |||
1792 | } | 1792 | } |
1793 | 1793 | ||
1794 | static struct pci_ops octeon_pcie0_ops = { | 1794 | static struct pci_ops octeon_pcie0_ops = { |
1795 | octeon_pcie0_read_config, | 1795 | .read = octeon_pcie0_read_config, |
1796 | octeon_pcie0_write_config, | 1796 | .write = octeon_pcie0_write_config, |
1797 | }; | 1797 | }; |
1798 | 1798 | ||
1799 | static struct resource octeon_pcie0_mem_resource = { | 1799 | static struct resource octeon_pcie0_mem_resource = { |
@@ -1813,8 +1813,8 @@ static struct pci_controller octeon_pcie0_controller = { | |||
1813 | }; | 1813 | }; |
1814 | 1814 | ||
1815 | static struct pci_ops octeon_pcie1_ops = { | 1815 | static struct pci_ops octeon_pcie1_ops = { |
1816 | octeon_pcie1_read_config, | 1816 | .read = octeon_pcie1_read_config, |
1817 | octeon_pcie1_write_config, | 1817 | .write = octeon_pcie1_write_config, |
1818 | }; | 1818 | }; |
1819 | 1819 | ||
1820 | static struct resource octeon_pcie1_mem_resource = { | 1820 | static struct resource octeon_pcie1_mem_resource = { |
@@ -1834,8 +1834,8 @@ static struct pci_controller octeon_pcie1_controller = { | |||
1834 | }; | 1834 | }; |
1835 | 1835 | ||
1836 | static struct pci_ops octeon_dummy_ops = { | 1836 | static struct pci_ops octeon_dummy_ops = { |
1837 | octeon_dummy_read_config, | 1837 | .read = octeon_dummy_read_config, |
1838 | octeon_dummy_write_config, | 1838 | .write = octeon_dummy_write_config, |
1839 | }; | 1839 | }; |
1840 | 1840 | ||
1841 | static struct resource octeon_dummy_mem_resource = { | 1841 | static struct resource octeon_dummy_mem_resource = { |