aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVeaceslav Falico <vfalico@gmail.com>2014-07-29 07:27:43 -0400
committerDavid S. Miller <davem@davemloft.net>2014-07-31 14:16:09 -0400
commit7afcaec4969652e177cf0b247a1530ac927a20f8 (patch)
tree1853311000071bd3dd799252e9a407a18909b924
parentc36c9d50cc6af5c5bfcc195f21b73f55520c15f9 (diff)
bonding: use kobject_put instead of _del after kobject_add
Otherwise the name of the kobject isn't getting freed and other stuff from kobject_cleanup() isn't getting called. kobject_put() will call kobject_del() on its own in kobject_cleanup(). CC: Jay Vosburgh <j.vosburgh@gmail.com> CC: Andy Gospodarek <andy@greyhouse.net> Signed-off-by: Veaceslav Falico <vfalico@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/bonding/bond_sysfs_slave.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/bonding/bond_sysfs_slave.c b/drivers/net/bonding/bond_sysfs_slave.c
index 198677f58ce0..5cd532ca1cfe 100644
--- a/drivers/net/bonding/bond_sysfs_slave.c
+++ b/drivers/net/bonding/bond_sysfs_slave.c
@@ -125,7 +125,7 @@ int bond_sysfs_slave_add(struct slave *slave)
125 for (a = slave_attrs; *a; ++a) { 125 for (a = slave_attrs; *a; ++a) {
126 err = sysfs_create_file(&slave->kobj, &((*a)->attr)); 126 err = sysfs_create_file(&slave->kobj, &((*a)->attr));
127 if (err) { 127 if (err) {
128 kobject_del(&slave->kobj); 128 kobject_put(&slave->kobj);
129 return err; 129 return err;
130 } 130 }
131 } 131 }
@@ -140,5 +140,5 @@ void bond_sysfs_slave_del(struct slave *slave)
140 for (a = slave_attrs; *a; ++a) 140 for (a = slave_attrs; *a; ++a)
141 sysfs_remove_file(&slave->kobj, &((*a)->attr)); 141 sysfs_remove_file(&slave->kobj, &((*a)->attr));
142 142
143 kobject_del(&slave->kobj); 143 kobject_put(&slave->kobj);
144} 144}