diff options
author | Paul Gortmaker <paul.gortmaker@windriver.com> | 2014-02-11 16:10:12 -0500 |
---|---|---|
committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2014-02-26 09:35:16 -0500 |
commit | 7a754743185a4b05818e10058fa2fbe4e6969085 (patch) | |
tree | 9713d04467357fd137b71bbcd39499881f62ed55 | |
parent | 8857563b819b140aa8c9be920cfe44d5d3f808b7 (diff) |
rcu: Fix sparse warning for rcu_expedited from kernel/ksysfs.c
This commit fixes the follwoing warning:
kernel/ksysfs.c:143:5: warning: symbol 'rcu_expedited' was not declared. Should it be static?
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
[ paulmck: Moved the declaration to include/linux/rcupdate.h to avoid
including the RCU-internal rcu.h file outside of RCU. ]
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
-rw-r--r-- | include/linux/rcupdate.h | 1 | ||||
-rw-r--r-- | kernel/ksysfs.c | 2 | ||||
-rw-r--r-- | kernel/rcu/rcu.h | 2 |
3 files changed, 3 insertions, 2 deletions
diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h index 32decf1a9c6c..f3706c6b2e21 100644 --- a/include/linux/rcupdate.h +++ b/include/linux/rcupdate.h | |||
@@ -46,6 +46,7 @@ | |||
46 | #include <linux/compiler.h> | 46 | #include <linux/compiler.h> |
47 | #include <asm/barrier.h> | 47 | #include <asm/barrier.h> |
48 | 48 | ||
49 | extern int rcu_expedited; /* for sysctl */ | ||
49 | #ifdef CONFIG_RCU_TORTURE_TEST | 50 | #ifdef CONFIG_RCU_TORTURE_TEST |
50 | extern int rcutorture_runnable; /* for sysctl */ | 51 | extern int rcutorture_runnable; /* for sysctl */ |
51 | #endif /* #ifdef CONFIG_RCU_TORTURE_TEST */ | 52 | #endif /* #ifdef CONFIG_RCU_TORTURE_TEST */ |
diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c index d945a949760f..e660964086e2 100644 --- a/kernel/ksysfs.c +++ b/kernel/ksysfs.c | |||
@@ -19,6 +19,8 @@ | |||
19 | #include <linux/sched.h> | 19 | #include <linux/sched.h> |
20 | #include <linux/capability.h> | 20 | #include <linux/capability.h> |
21 | 21 | ||
22 | #include <linux/rcupdate.h> /* rcu_expedited */ | ||
23 | |||
22 | #define KERNEL_ATTR_RO(_name) \ | 24 | #define KERNEL_ATTR_RO(_name) \ |
23 | static struct kobj_attribute _name##_attr = __ATTR_RO(_name) | 25 | static struct kobj_attribute _name##_attr = __ATTR_RO(_name) |
24 | 26 | ||
diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rcu.h index 1bd787fddcb2..af2e60a8425d 100644 --- a/kernel/rcu/rcu.h +++ b/kernel/rcu/rcu.h | |||
@@ -116,8 +116,6 @@ static inline bool __rcu_reclaim(const char *rn, struct rcu_head *head) | |||
116 | } | 116 | } |
117 | } | 117 | } |
118 | 118 | ||
119 | extern int rcu_expedited; | ||
120 | |||
121 | #ifdef CONFIG_RCU_STALL_COMMON | 119 | #ifdef CONFIG_RCU_STALL_COMMON |
122 | 120 | ||
123 | extern int rcu_cpu_stall_suppress; | 121 | extern int rcu_cpu_stall_suppress; |