diff options
author | Alex Elder <elder@inktank.com> | 2013-04-29 00:32:34 -0400 |
---|---|---|
committer | Sage Weil <sage@inktank.com> | 2013-05-02 00:20:02 -0400 |
commit | 79ab7558aac7622109e9d9b089cac2c5f06aca20 (patch) | |
tree | 1956dd2f7784a34e9ae9b183979129b25c4ba0e0 | |
parent | b644de2ba0c5b590db9195c03358ccd0f061daa6 (diff) |
rbd: drop module later
Drop the module reference at the end of rbd_remove() for symmetry
with adding a reference at the top of rbd_add().
Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
-rw-r--r-- | drivers/block/rbd.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index ac94aa4b4d22..59048191ab17 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c | |||
@@ -4986,9 +4986,6 @@ static void rbd_dev_release(struct device *dev) | |||
4986 | rbd_spec_put(rbd_dev->parent_spec); | 4986 | rbd_spec_put(rbd_dev->parent_spec); |
4987 | kfree(rbd_dev->header_name); | 4987 | kfree(rbd_dev->header_name); |
4988 | rbd_dev_destroy(rbd_dev); | 4988 | rbd_dev_destroy(rbd_dev); |
4989 | |||
4990 | /* release module ref */ | ||
4991 | module_put(THIS_MODULE); | ||
4992 | } | 4989 | } |
4993 | 4990 | ||
4994 | static void rbd_dev_remove_parent(struct rbd_device *rbd_dev) | 4991 | static void rbd_dev_remove_parent(struct rbd_device *rbd_dev) |
@@ -5071,6 +5068,7 @@ static ssize_t rbd_remove(struct bus_type *bus, | |||
5071 | 5068 | ||
5072 | rbd_remove_all_snaps(rbd_dev); | 5069 | rbd_remove_all_snaps(rbd_dev); |
5073 | rbd_bus_del_dev(rbd_dev); | 5070 | rbd_bus_del_dev(rbd_dev); |
5071 | module_put(THIS_MODULE); | ||
5074 | done: | 5072 | done: |
5075 | mutex_unlock(&ctl_mutex); | 5073 | mutex_unlock(&ctl_mutex); |
5076 | 5074 | ||