diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-05-02 00:33:24 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-05-02 00:33:24 -0400 |
commit | 77c9e125b3c88372852ce6dac068387c3048a058 (patch) | |
tree | 6ef1d8045b22955bd9b510636e0ba306964c5d7c | |
parent | b741ab9da614b08da51cffa961435bc81314f3c4 (diff) |
USB: cxacru.c: remove dbg() usage
dbg() was a very old USB-specific macro that should no longer
be used. This patch removes it from being used in the driver
and uses dev_dbg() instead.
CC: Simon Arlott <cxacru@fire.lp0.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/usb/atm/cxacru.c | 34 |
1 files changed, 17 insertions, 17 deletions
diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index 98b89fe19867..b7eb86ad6bf2 100644 --- a/drivers/usb/atm/cxacru.c +++ b/drivers/usb/atm/cxacru.c | |||
@@ -674,7 +674,7 @@ static int cxacru_cm(struct cxacru_data *instance, enum cxacru_cm_request cm, | |||
674 | } | 674 | } |
675 | 675 | ||
676 | ret = offd; | 676 | ret = offd; |
677 | dbg("cm %#x", cm); | 677 | usb_dbg(instance->usbatm, "cm %#x\n", cm); |
678 | fail: | 678 | fail: |
679 | mutex_unlock(&instance->cm_serialize); | 679 | mutex_unlock(&instance->cm_serialize); |
680 | err: | 680 | err: |
@@ -733,7 +733,7 @@ static int cxacru_card_status(struct cxacru_data *instance) | |||
733 | { | 733 | { |
734 | int ret = cxacru_cm(instance, CM_REQUEST_CARD_GET_STATUS, NULL, 0, NULL, 0); | 734 | int ret = cxacru_cm(instance, CM_REQUEST_CARD_GET_STATUS, NULL, 0, NULL, 0); |
735 | if (ret < 0) { /* firmware not loaded */ | 735 | if (ret < 0) { /* firmware not loaded */ |
736 | dbg("cxacru_adsl_start: CARD_GET_STATUS returned %d", ret); | 736 | usb_dbg(instance->usbatm, "cxacru_adsl_start: CARD_GET_STATUS returned %d\n", ret); |
737 | return ret; | 737 | return ret; |
738 | } | 738 | } |
739 | return 0; | 739 | return 0; |
@@ -758,7 +758,7 @@ static int cxacru_atm_start(struct usbatm_data *usbatm_instance, | |||
758 | int ret; | 758 | int ret; |
759 | int start_polling = 1; | 759 | int start_polling = 1; |
760 | 760 | ||
761 | dbg("cxacru_atm_start"); | 761 | dev_dbg(&intf->dev, "%s\n", __func__); |
762 | 762 | ||
763 | /* Read MAC address */ | 763 | /* Read MAC address */ |
764 | ret = cxacru_cm(instance, CM_REQUEST_CARD_GET_MAC_ADDRESS, NULL, 0, | 764 | ret = cxacru_cm(instance, CM_REQUEST_CARD_GET_MAC_ADDRESS, NULL, 0, |
@@ -962,13 +962,13 @@ static int cxacru_fw(struct usb_device *usb_dev, enum cxacru_fw_request fw, | |||
962 | ret = usb_bulk_msg(usb_dev, usb_sndbulkpipe(usb_dev, CXACRU_EP_CMD), | 962 | ret = usb_bulk_msg(usb_dev, usb_sndbulkpipe(usb_dev, CXACRU_EP_CMD), |
963 | buf, offb, NULL, CMD_TIMEOUT); | 963 | buf, offb, NULL, CMD_TIMEOUT); |
964 | if (ret < 0) { | 964 | if (ret < 0) { |
965 | dbg("sending fw %#x failed", fw); | 965 | dev_dbg(&usb_dev->dev, "sending fw %#x failed\n", fw); |
966 | goto cleanup; | 966 | goto cleanup; |
967 | } | 967 | } |
968 | offb = 0; | 968 | offb = 0; |
969 | } | 969 | } |
970 | } while (offd < size); | 970 | } while (offd < size); |
971 | dbg("sent fw %#x", fw); | 971 | dev_dbg(&usb_dev->dev, "sent fw %#x\n", fw); |
972 | 972 | ||
973 | ret = 0; | 973 | ret = 0; |
974 | 974 | ||
@@ -988,7 +988,7 @@ static void cxacru_upload_firmware(struct cxacru_data *instance, | |||
988 | usb_dev->descriptor.idProduct }; | 988 | usb_dev->descriptor.idProduct }; |
989 | __le32 val; | 989 | __le32 val; |
990 | 990 | ||
991 | dbg("cxacru_upload_firmware"); | 991 | usb_dbg(usbatm, "%s\n", __func__); |
992 | 992 | ||
993 | /* FirmwarePllFClkValue */ | 993 | /* FirmwarePllFClkValue */ |
994 | val = cpu_to_le32(instance->modem_type->pll_f_clk); | 994 | val = cpu_to_le32(instance->modem_type->pll_f_clk); |
@@ -1074,7 +1074,7 @@ static int cxacru_find_firmware(struct cxacru_data *instance, | |||
1074 | char buf[16]; | 1074 | char buf[16]; |
1075 | 1075 | ||
1076 | sprintf(buf, "cxacru-%s.bin", phase); | 1076 | sprintf(buf, "cxacru-%s.bin", phase); |
1077 | dbg("cxacru_find_firmware: looking for %s", buf); | 1077 | usb_dbg(usbatm, "cxacru_find_firmware: looking for %s\n", buf); |
1078 | 1078 | ||
1079 | if (request_firmware(fw_p, buf, dev)) { | 1079 | if (request_firmware(fw_p, buf, dev)) { |
1080 | usb_dbg(usbatm, "no stage %s firmware found\n", phase); | 1080 | usb_dbg(usbatm, "no stage %s firmware found\n", phase); |
@@ -1115,9 +1115,9 @@ static int cxacru_heavy_init(struct usbatm_data *usbatm_instance, | |||
1115 | 1115 | ||
1116 | ret = cxacru_card_status(instance); | 1116 | ret = cxacru_card_status(instance); |
1117 | if (ret) | 1117 | if (ret) |
1118 | dbg("modem initialisation failed"); | 1118 | usb_dbg(usbatm_instance, "modem initialisation failed\n"); |
1119 | else | 1119 | else |
1120 | dbg("done setting up the modem"); | 1120 | usb_dbg(usbatm_instance, "done setting up the modem\n"); |
1121 | 1121 | ||
1122 | return ret; | 1122 | return ret; |
1123 | } | 1123 | } |
@@ -1133,7 +1133,7 @@ static int cxacru_bind(struct usbatm_data *usbatm_instance, | |||
1133 | /* instance init */ | 1133 | /* instance init */ |
1134 | instance = kzalloc(sizeof(*instance), GFP_KERNEL); | 1134 | instance = kzalloc(sizeof(*instance), GFP_KERNEL); |
1135 | if (!instance) { | 1135 | if (!instance) { |
1136 | dbg("cxacru_bind: no memory for instance data"); | 1136 | usb_dbg(usbatm_instance, "cxacru_bind: no memory for instance data\n"); |
1137 | return -ENOMEM; | 1137 | return -ENOMEM; |
1138 | } | 1138 | } |
1139 | 1139 | ||
@@ -1149,31 +1149,31 @@ static int cxacru_bind(struct usbatm_data *usbatm_instance, | |||
1149 | 1149 | ||
1150 | instance->rcv_buf = (u8 *) __get_free_page(GFP_KERNEL); | 1150 | instance->rcv_buf = (u8 *) __get_free_page(GFP_KERNEL); |
1151 | if (!instance->rcv_buf) { | 1151 | if (!instance->rcv_buf) { |
1152 | dbg("cxacru_bind: no memory for rcv_buf"); | 1152 | usb_dbg(usbatm_instance, "cxacru_bind: no memory for rcv_buf\n"); |
1153 | ret = -ENOMEM; | 1153 | ret = -ENOMEM; |
1154 | goto fail; | 1154 | goto fail; |
1155 | } | 1155 | } |
1156 | instance->snd_buf = (u8 *) __get_free_page(GFP_KERNEL); | 1156 | instance->snd_buf = (u8 *) __get_free_page(GFP_KERNEL); |
1157 | if (!instance->snd_buf) { | 1157 | if (!instance->snd_buf) { |
1158 | dbg("cxacru_bind: no memory for snd_buf"); | 1158 | usb_dbg(usbatm_instance, "cxacru_bind: no memory for snd_buf\n"); |
1159 | ret = -ENOMEM; | 1159 | ret = -ENOMEM; |
1160 | goto fail; | 1160 | goto fail; |
1161 | } | 1161 | } |
1162 | instance->rcv_urb = usb_alloc_urb(0, GFP_KERNEL); | 1162 | instance->rcv_urb = usb_alloc_urb(0, GFP_KERNEL); |
1163 | if (!instance->rcv_urb) { | 1163 | if (!instance->rcv_urb) { |
1164 | dbg("cxacru_bind: no memory for rcv_urb"); | 1164 | usb_dbg(usbatm_instance, "cxacru_bind: no memory for rcv_urb\n"); |
1165 | ret = -ENOMEM; | 1165 | ret = -ENOMEM; |
1166 | goto fail; | 1166 | goto fail; |
1167 | } | 1167 | } |
1168 | instance->snd_urb = usb_alloc_urb(0, GFP_KERNEL); | 1168 | instance->snd_urb = usb_alloc_urb(0, GFP_KERNEL); |
1169 | if (!instance->snd_urb) { | 1169 | if (!instance->snd_urb) { |
1170 | dbg("cxacru_bind: no memory for snd_urb"); | 1170 | usb_dbg(usbatm_instance, "cxacru_bind: no memory for snd_urb\n"); |
1171 | ret = -ENOMEM; | 1171 | ret = -ENOMEM; |
1172 | goto fail; | 1172 | goto fail; |
1173 | } | 1173 | } |
1174 | 1174 | ||
1175 | if (!cmd_ep) { | 1175 | if (!cmd_ep) { |
1176 | dbg("cxacru_bind: no command endpoint"); | 1176 | usb_dbg(usbatm_instance, "cxacru_bind: no command endpoint\n"); |
1177 | ret = -ENODEV; | 1177 | ret = -ENODEV; |
1178 | goto fail; | 1178 | goto fail; |
1179 | } | 1179 | } |
@@ -1227,10 +1227,10 @@ static void cxacru_unbind(struct usbatm_data *usbatm_instance, | |||
1227 | struct cxacru_data *instance = usbatm_instance->driver_data; | 1227 | struct cxacru_data *instance = usbatm_instance->driver_data; |
1228 | int is_polling = 1; | 1228 | int is_polling = 1; |
1229 | 1229 | ||
1230 | dbg("cxacru_unbind entered"); | 1230 | usb_dbg(usbatm_instance, "cxacru_unbind entered\n"); |
1231 | 1231 | ||
1232 | if (!instance) { | 1232 | if (!instance) { |
1233 | dbg("cxacru_unbind: NULL instance!"); | 1233 | usb_dbg(usbatm_instance, "cxacru_unbind: NULL instance!\n"); |
1234 | return; | 1234 | return; |
1235 | } | 1235 | } |
1236 | 1236 | ||