aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIan Abbott <abbotti@mev.co.uk>2015-03-27 15:14:34 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-04-03 07:14:07 -0400
commit75a12586cb717fb57197d3b3a9467ebab216c984 (patch)
tree86721ba4a74fed1fc56d3db47063a5d6585c0c19
parent21de3b8d84dd8ec0e129c7d2909e135e8af6f58e (diff)
staging: comedi: quatech_daqp_cs: remove #include "comedi_fc.h"
As preparation for removal of "comedi_fc.h", replace calls to the `cfc_check_trigger_...` functions from "comedi_fc.h" with the replacement `comedi_check_trigger_...` functions from "../comedidev.h" and remove the inclusion of "comedi_fc.h". Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/comedi/drivers/quatech_daqp_cs.c43
1 files changed, 23 insertions, 20 deletions
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index aa8653465771..152cb146fc16 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -52,7 +52,6 @@ Devices: [Quatech] DAQP-208 (daqp), DAQP-308
52#include <linux/completion.h> 52#include <linux/completion.h>
53 53
54#include "../comedi_pcmcia.h" 54#include "../comedi_pcmcia.h"
55#include "comedi_fc.h"
56 55
57struct daqp_private { 56struct daqp_private {
58 int stop; 57 int stop;
@@ -365,22 +364,22 @@ static int daqp_ai_cmdtest(struct comedi_device *dev,
365 364
366 /* Step 1 : check if triggers are trivially valid */ 365 /* Step 1 : check if triggers are trivially valid */
367 366
368 err |= cfc_check_trigger_src(&cmd->start_src, TRIG_NOW); 367 err |= comedi_check_trigger_src(&cmd->start_src, TRIG_NOW);
369 err |= cfc_check_trigger_src(&cmd->scan_begin_src, 368 err |= comedi_check_trigger_src(&cmd->scan_begin_src,
370 TRIG_TIMER | TRIG_FOLLOW); 369 TRIG_TIMER | TRIG_FOLLOW);
371 err |= cfc_check_trigger_src(&cmd->convert_src, 370 err |= comedi_check_trigger_src(&cmd->convert_src,
372 TRIG_TIMER | TRIG_NOW); 371 TRIG_TIMER | TRIG_NOW);
373 err |= cfc_check_trigger_src(&cmd->scan_end_src, TRIG_COUNT); 372 err |= comedi_check_trigger_src(&cmd->scan_end_src, TRIG_COUNT);
374 err |= cfc_check_trigger_src(&cmd->stop_src, TRIG_COUNT | TRIG_NONE); 373 err |= comedi_check_trigger_src(&cmd->stop_src, TRIG_COUNT | TRIG_NONE);
375 374
376 if (err) 375 if (err)
377 return 1; 376 return 1;
378 377
379 /* Step 2a : make sure trigger sources are unique */ 378 /* Step 2a : make sure trigger sources are unique */
380 379
381 err |= cfc_check_trigger_is_unique(cmd->scan_begin_src); 380 err |= comedi_check_trigger_is_unique(cmd->scan_begin_src);
382 err |= cfc_check_trigger_is_unique(cmd->convert_src); 381 err |= comedi_check_trigger_is_unique(cmd->convert_src);
383 err |= cfc_check_trigger_is_unique(cmd->stop_src); 382 err |= comedi_check_trigger_is_unique(cmd->stop_src);
384 383
385 /* Step 2b : and mutually compatible */ 384 /* Step 2b : and mutually compatible */
386 385
@@ -389,13 +388,14 @@ static int daqp_ai_cmdtest(struct comedi_device *dev,
389 388
390 /* Step 3: check if arguments are trivially valid */ 389 /* Step 3: check if arguments are trivially valid */
391 390
392 err |= cfc_check_trigger_arg_is(&cmd->start_arg, 0); 391 err |= comedi_check_trigger_arg_is(&cmd->start_arg, 0);
393 392
394#define MAX_SPEED 10000 /* 100 kHz - in nanoseconds */ 393#define MAX_SPEED 10000 /* 100 kHz - in nanoseconds */
395 394
396 if (cmd->scan_begin_src == TRIG_TIMER) 395 if (cmd->scan_begin_src == TRIG_TIMER) {
397 err |= cfc_check_trigger_arg_min(&cmd->scan_begin_arg, 396 err |= comedi_check_trigger_arg_min(&cmd->scan_begin_arg,
398 MAX_SPEED); 397 MAX_SPEED);
398 }
399 399
400 /* If both scan_begin and convert are both timer values, the only 400 /* If both scan_begin and convert are both timer values, the only
401 * way that can make sense is if the scan time is the number of 401 * way that can make sense is if the scan time is the number of
@@ -407,15 +407,18 @@ static int daqp_ai_cmdtest(struct comedi_device *dev,
407 err |= -EINVAL; 407 err |= -EINVAL;
408 } 408 }
409 409
410 if (cmd->convert_src == TRIG_TIMER) 410 if (cmd->convert_src == TRIG_TIMER) {
411 err |= cfc_check_trigger_arg_min(&cmd->convert_arg, MAX_SPEED); 411 err |= comedi_check_trigger_arg_min(&cmd->convert_arg,
412 MAX_SPEED);
413 }
412 414
413 err |= cfc_check_trigger_arg_is(&cmd->scan_end_arg, cmd->chanlist_len); 415 err |= comedi_check_trigger_arg_is(&cmd->scan_end_arg,
416 cmd->chanlist_len);
414 417
415 if (cmd->stop_src == TRIG_COUNT) 418 if (cmd->stop_src == TRIG_COUNT)
416 err |= cfc_check_trigger_arg_max(&cmd->stop_arg, 0x00ffffff); 419 err |= comedi_check_trigger_arg_max(&cmd->stop_arg, 0x00ffffff);
417 else /* TRIG_NONE */ 420 else /* TRIG_NONE */
418 err |= cfc_check_trigger_arg_is(&cmd->stop_arg, 0); 421 err |= comedi_check_trigger_arg_is(&cmd->stop_arg, 0);
419 422
420 if (err) 423 if (err)
421 return 3; 424 return 3;
@@ -425,13 +428,13 @@ static int daqp_ai_cmdtest(struct comedi_device *dev,
425 if (cmd->scan_begin_src == TRIG_TIMER) { 428 if (cmd->scan_begin_src == TRIG_TIMER) {
426 arg = cmd->scan_begin_arg; 429 arg = cmd->scan_begin_arg;
427 daqp_ns_to_timer(&arg, cmd->flags); 430 daqp_ns_to_timer(&arg, cmd->flags);
428 err |= cfc_check_trigger_arg_is(&cmd->scan_begin_arg, arg); 431 err |= comedi_check_trigger_arg_is(&cmd->scan_begin_arg, arg);
429 } 432 }
430 433
431 if (cmd->convert_src == TRIG_TIMER) { 434 if (cmd->convert_src == TRIG_TIMER) {
432 arg = cmd->convert_arg; 435 arg = cmd->convert_arg;
433 daqp_ns_to_timer(&arg, cmd->flags); 436 daqp_ns_to_timer(&arg, cmd->flags);
434 err |= cfc_check_trigger_arg_is(&cmd->convert_arg, arg); 437 err |= comedi_check_trigger_arg_is(&cmd->convert_arg, arg);
435 } 438 }
436 439
437 if (err) 440 if (err)