diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-10-02 04:28:45 -0400 |
|---|---|---|
| committer | Boaz Harrosh <bharrosh@panasas.com> | 2012-10-03 16:51:51 -0400 |
| commit | 74b217d0d3a46132fb61adab91d53c57e0d8f68a (patch) | |
| tree | e4a5adddbcbac3023ffe8d9876b8839f82bcecdf | |
| parent | b8017d2957fb0ebf0c2aa91d48f2465f6f799738 (diff) | |
ore: signedness bug in _sp2d_min_pg()
This for loop doesn't work correctly when "p" is unsigned.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
| -rw-r--r-- | fs/exofs/ore_raid.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/exofs/ore_raid.c b/fs/exofs/ore_raid.c index 5f376d14fdcc..b963f38ac298 100644 --- a/fs/exofs/ore_raid.c +++ b/fs/exofs/ore_raid.c | |||
| @@ -203,7 +203,7 @@ static unsigned _sp2d_min_pg(struct __stripe_pages_2d *sp2d) | |||
| 203 | 203 | ||
| 204 | static unsigned _sp2d_max_pg(struct __stripe_pages_2d *sp2d) | 204 | static unsigned _sp2d_max_pg(struct __stripe_pages_2d *sp2d) |
| 205 | { | 205 | { |
| 206 | unsigned p; | 206 | int p; |
| 207 | 207 | ||
| 208 | for (p = sp2d->pages_in_unit - 1; p >= 0; --p) { | 208 | for (p = sp2d->pages_in_unit - 1; p >= 0; --p) { |
| 209 | struct __1_page_stripe *_1ps = &sp2d->_1p_stripes[p]; | 209 | struct __1_page_stripe *_1ps = &sp2d->_1p_stripes[p]; |
