diff options
author | Matan Barak <matanb@mellanox.com> | 2015-04-26 08:55:57 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-04-26 22:59:53 -0400 |
commit | 73b5a6f2a7a1cb78ccdec3900afc8657e11bc6bf (patch) | |
tree | 8aa2b843848883286e19998dd952262c4849a895 | |
parent | a31196b07f8034eba6a3487a1ad1bb5ec5cd58a5 (diff) |
net/bonding: Make DRV macros private
The bonding modules currently defines four macros with
general names that pollute the global namespace:
DRV_VERSION
DRV_RELDATE
DRV_NAME
DRV_DESCRIPTION
Fixing that by defining a private bonding_priv.h
header files which includes those defines.
Signed-off-by: Matan Barak <matanb@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/bonding/bond_main.c | 2 | ||||
-rw-r--r-- | drivers/net/bonding/bond_procfs.c | 1 | ||||
-rw-r--r-- | drivers/net/bonding/bonding_priv.h | 25 | ||||
-rw-r--r-- | include/net/bonding.h | 7 |
4 files changed, 28 insertions, 7 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 78dde56ae6e6..3a10551d64cf 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c | |||
@@ -82,6 +82,8 @@ | |||
82 | #include <net/bond_3ad.h> | 82 | #include <net/bond_3ad.h> |
83 | #include <net/bond_alb.h> | 83 | #include <net/bond_alb.h> |
84 | 84 | ||
85 | #include "bonding_priv.h" | ||
86 | |||
85 | /*---------------------------- Module parameters ----------------------------*/ | 87 | /*---------------------------- Module parameters ----------------------------*/ |
86 | 88 | ||
87 | /* monitor all links that often (in milliseconds). <=0 disables monitoring */ | 89 | /* monitor all links that often (in milliseconds). <=0 disables monitoring */ |
diff --git a/drivers/net/bonding/bond_procfs.c b/drivers/net/bonding/bond_procfs.c index 62694cfc05b6..b20b35acb47d 100644 --- a/drivers/net/bonding/bond_procfs.c +++ b/drivers/net/bonding/bond_procfs.c | |||
@@ -4,6 +4,7 @@ | |||
4 | #include <net/netns/generic.h> | 4 | #include <net/netns/generic.h> |
5 | #include <net/bonding.h> | 5 | #include <net/bonding.h> |
6 | 6 | ||
7 | #include "bonding_priv.h" | ||
7 | 8 | ||
8 | static void *bond_info_seq_start(struct seq_file *seq, loff_t *pos) | 9 | static void *bond_info_seq_start(struct seq_file *seq, loff_t *pos) |
9 | __acquires(RCU) | 10 | __acquires(RCU) |
diff --git a/drivers/net/bonding/bonding_priv.h b/drivers/net/bonding/bonding_priv.h new file mode 100644 index 000000000000..5a4d81a9437c --- /dev/null +++ b/drivers/net/bonding/bonding_priv.h | |||
@@ -0,0 +1,25 @@ | |||
1 | /* | ||
2 | * Bond several ethernet interfaces into a Cisco, running 'Etherchannel'. | ||
3 | * | ||
4 | * Portions are (c) Copyright 1995 Simon "Guru Aleph-Null" Janes | ||
5 | * NCM: Network and Communications Management, Inc. | ||
6 | * | ||
7 | * BUT, I'm the one who modified it for ethernet, so: | ||
8 | * (c) Copyright 1999, Thomas Davis, tadavis@lbl.gov | ||
9 | * | ||
10 | * This software may be used and distributed according to the terms | ||
11 | * of the GNU Public License, incorporated herein by reference. | ||
12 | * | ||
13 | */ | ||
14 | |||
15 | #ifndef _BONDING_PRIV_H | ||
16 | #define _BONDING_PRIV_H | ||
17 | |||
18 | #define DRV_VERSION "3.7.1" | ||
19 | #define DRV_RELDATE "April 27, 2011" | ||
20 | #define DRV_NAME "bonding" | ||
21 | #define DRV_DESCRIPTION "Ethernet Channel Bonding Driver" | ||
22 | |||
23 | #define bond_version DRV_DESCRIPTION ": v" DRV_VERSION " (" DRV_RELDATE ")\n" | ||
24 | |||
25 | #endif | ||
diff --git a/include/net/bonding.h b/include/net/bonding.h index fda6feeb6c1f..78ed135e9dea 100644 --- a/include/net/bonding.h +++ b/include/net/bonding.h | |||
@@ -30,13 +30,6 @@ | |||
30 | #include <net/bond_alb.h> | 30 | #include <net/bond_alb.h> |
31 | #include <net/bond_options.h> | 31 | #include <net/bond_options.h> |
32 | 32 | ||
33 | #define DRV_VERSION "3.7.1" | ||
34 | #define DRV_RELDATE "April 27, 2011" | ||
35 | #define DRV_NAME "bonding" | ||
36 | #define DRV_DESCRIPTION "Ethernet Channel Bonding Driver" | ||
37 | |||
38 | #define bond_version DRV_DESCRIPTION ": v" DRV_VERSION " (" DRV_RELDATE ")\n" | ||
39 | |||
40 | #define BOND_MAX_ARP_TARGETS 16 | 33 | #define BOND_MAX_ARP_TARGETS 16 |
41 | 34 | ||
42 | #define BOND_DEFAULT_MIIMON 100 | 35 | #define BOND_DEFAULT_MIIMON 100 |