aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSachin Prabhu <sprabhu@redhat.com>2013-03-05 14:25:55 -0500
committerSteve French <sfrench@us.ibm.com>2013-03-06 19:28:35 -0500
commit72d282dc5109e5dc0d963be020604e0cc82f7ed7 (patch)
tree6f59f8b91ae28efd5496bee9b2190cb9f8e86345
parent9f225788cc047fb7c2ef2326eb4f86dee890e2ef (diff)
cifs: Fix bug when checking error condition in cifs_rename_pending_delete()
Fix check for error condition after setting attributes with CIFSSMBSetFileInfo(). Signed-off-by: Sachin Prabhu <sprabhu@redhat.com> Reviewed-by: Jeff Layton <jlayton@redhat.com> Reviewed-by: Pavel Shilovsky <piastry@etersoft.ru> Signed-off-by: Steve French <sfrench@us.ibm.com>
-rw-r--r--fs/cifs/inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index 83f2606c76d0..e7ae45cd94ef 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -1023,7 +1023,7 @@ cifs_rename_pending_delete(const char *full_path, struct dentry *dentry,
1023 current->tgid); 1023 current->tgid);
1024 /* although we would like to mark the file hidden 1024 /* although we would like to mark the file hidden
1025 if that fails we will still try to rename it */ 1025 if that fails we will still try to rename it */
1026 if (rc != 0) 1026 if (!rc)
1027 cifsInode->cifsAttrs = dosattr; 1027 cifsInode->cifsAttrs = dosattr;
1028 else 1028 else
1029 dosattr = origattr; /* since not able to change them */ 1029 dosattr = origattr; /* since not able to change them */