diff options
| author | Joe Perches <joe@perches.com> | 2013-02-16 06:20:03 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-02-18 12:45:52 -0500 |
| commit | 717ff727faa05958633e4e786f5b092c4bcf58e7 (patch) | |
| tree | 76a21c6247b7d29055f6ed3a48eeb7355851c220 | |
| parent | 885d29941435e16dea6a52e42bbb3c8b87676bd8 (diff) | |
tg3: Remove define and single use of GET_CHIP_REV_ID
It's the same value as tp->pci_chip_rev_id so use that
instead. This makes all CHIPREV_ID_<foo> tests the same.
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/tg3.c | 10 | ||||
| -rw-r--r-- | drivers/net/ethernet/broadcom/tg3.h | 4 |
2 files changed, 5 insertions, 9 deletions
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 1b5987676f7c..f511e8b6e7f5 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c | |||
| @@ -15761,12 +15761,10 @@ static int tg3_get_invariants(struct tg3 *tp, const struct pci_device_id *ent) | |||
| 15761 | &pci_state_reg); | 15761 | &pci_state_reg); |
| 15762 | if ((pci_state_reg & PCISTATE_CONV_PCI_MODE) == 0 && | 15762 | if ((pci_state_reg & PCISTATE_CONV_PCI_MODE) == 0 && |
| 15763 | !tg3_flag(tp, PCIX_TARGET_HWBUG)) { | 15763 | !tg3_flag(tp, PCIX_TARGET_HWBUG)) { |
| 15764 | u32 chiprevid = GET_CHIP_REV_ID(tp->misc_host_ctrl); | 15764 | if (tp->pci_chip_rev_id == CHIPREV_ID_5701_A0 || |
| 15765 | 15765 | tp->pci_chip_rev_id == CHIPREV_ID_5701_B0 || | |
| 15766 | if (chiprevid == CHIPREV_ID_5701_A0 || | 15766 | tp->pci_chip_rev_id == CHIPREV_ID_5701_B2 || |
| 15767 | chiprevid == CHIPREV_ID_5701_B0 || | 15767 | tp->pci_chip_rev_id == CHIPREV_ID_5701_B5) { |
| 15768 | chiprevid == CHIPREV_ID_5701_B2 || | ||
| 15769 | chiprevid == CHIPREV_ID_5701_B5) { | ||
| 15770 | void __iomem *sram_base; | 15768 | void __iomem *sram_base; |
| 15771 | 15769 | ||
| 15772 | /* Write some dummy words into the SRAM status block | 15770 | /* Write some dummy words into the SRAM status block |
diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h index b6767286d23c..3e27f2efbfe0 100644 --- a/drivers/net/ethernet/broadcom/tg3.h +++ b/drivers/net/ethernet/broadcom/tg3.h | |||
| @@ -120,9 +120,7 @@ | |||
| 120 | #define MISC_HOST_CTRL_TAGGED_STATUS 0x00000200 | 120 | #define MISC_HOST_CTRL_TAGGED_STATUS 0x00000200 |
| 121 | #define MISC_HOST_CTRL_CHIPREV 0xffff0000 | 121 | #define MISC_HOST_CTRL_CHIPREV 0xffff0000 |
| 122 | #define MISC_HOST_CTRL_CHIPREV_SHIFT 16 | 122 | #define MISC_HOST_CTRL_CHIPREV_SHIFT 16 |
| 123 | #define GET_CHIP_REV_ID(MISC_HOST_CTRL) \ | 123 | |
| 124 | (((MISC_HOST_CTRL) & MISC_HOST_CTRL_CHIPREV) >> \ | ||
| 125 | MISC_HOST_CTRL_CHIPREV_SHIFT) | ||
| 126 | #define CHIPREV_ID_5700_A0 0x7000 | 124 | #define CHIPREV_ID_5700_A0 0x7000 |
| 127 | #define CHIPREV_ID_5700_A1 0x7001 | 125 | #define CHIPREV_ID_5700_A1 0x7001 |
| 128 | #define CHIPREV_ID_5700_B0 0x7100 | 126 | #define CHIPREV_ID_5700_B0 0x7100 |
