diff options
author | Oleg Nesterov <oleg@redhat.com> | 2012-03-23 18:02:46 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-03-23 19:58:41 -0400 |
commit | 70834d3070c3f3015ab5c05176d54bd4a0100546 (patch) | |
tree | 4dbcea84c4584de05f83aa911164902b3f00265f | |
parent | a02d6fd643cbd4c559113b35b31d3b04e4ec60c7 (diff) |
usermodehelper: use UMH_WAIT_PROC consistently
A few call_usermodehelper() callers use the hardcoded constant instead of
the proper UMH_WAIT_PROC, fix them.
Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Lars Ellenberg <drbd-dev@lists.linbit.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michal Januszewski <spock@gentoo.org>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Kentaro Takeda <takedakn@nttdata.co.jp>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: James Morris <jmorris@namei.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | drivers/block/drbd/drbd_nl.c | 2 | ||||
-rw-r--r-- | drivers/staging/rtl8187se/r8180_core.c | 2 | ||||
-rw-r--r-- | drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 4 | ||||
-rw-r--r-- | drivers/video/uvesafb.c | 2 | ||||
-rw-r--r-- | security/tomoyo/load_policy.c | 2 |
5 files changed, 6 insertions, 6 deletions
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index e09f9cebbb20..abfaacaaf346 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c | |||
@@ -179,7 +179,7 @@ int drbd_khelper(struct drbd_conf *mdev, char *cmd) | |||
179 | dev_info(DEV, "helper command: %s %s %s\n", usermode_helper, cmd, mb); | 179 | dev_info(DEV, "helper command: %s %s %s\n", usermode_helper, cmd, mb); |
180 | 180 | ||
181 | drbd_bcast_ev_helper(mdev, cmd); | 181 | drbd_bcast_ev_helper(mdev, cmd); |
182 | ret = call_usermodehelper(usermode_helper, argv, envp, 1); | 182 | ret = call_usermodehelper(usermode_helper, argv, envp, UMH_WAIT_PROC); |
183 | if (ret) | 183 | if (ret) |
184 | dev_warn(DEV, "helper command: %s %s %s exit code %u (0x%x)\n", | 184 | dev_warn(DEV, "helper command: %s %s %s exit code %u (0x%x)\n", |
185 | usermode_helper, cmd, mb, | 185 | usermode_helper, cmd, mb, |
diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c index e4ade550cfe5..4fe52f6b0034 100644 --- a/drivers/staging/rtl8187se/r8180_core.c +++ b/drivers/staging/rtl8187se/r8180_core.c | |||
@@ -4159,7 +4159,7 @@ void GPIOChangeRFWorkItemCallBack(struct work_struct *work) | |||
4159 | argv[0] = RadioPowerPath; | 4159 | argv[0] = RadioPowerPath; |
4160 | argv[2] = NULL; | 4160 | argv[2] = NULL; |
4161 | 4161 | ||
4162 | call_usermodehelper(RadioPowerPath, argv, envp, 1); | 4162 | call_usermodehelper(RadioPowerPath, argv, envp, UMH_WAIT_PROC); |
4163 | } | 4163 | } |
4164 | } | 4164 | } |
4165 | 4165 | ||
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c index a7fa9aad6f2d..f026b7171f62 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | |||
@@ -208,7 +208,7 @@ static void dm_check_ac_dc_power(struct net_device *dev) | |||
208 | 208 | ||
209 | if (priv->rtllib->state != RTLLIB_LINKED) | 209 | if (priv->rtllib->state != RTLLIB_LINKED) |
210 | return; | 210 | return; |
211 | call_usermodehelper(ac_dc_check_script_path, argv, envp, 1); | 211 | call_usermodehelper(ac_dc_check_script_path, argv, envp, UMH_WAIT_PROC); |
212 | 212 | ||
213 | return; | 213 | return; |
214 | }; | 214 | }; |
@@ -2296,7 +2296,7 @@ void dm_CheckRfCtrlGPIO(void *data) | |||
2296 | 2296 | ||
2297 | argv[0] = RadioPowerPath; | 2297 | argv[0] = RadioPowerPath; |
2298 | argv[2] = NULL; | 2298 | argv[2] = NULL; |
2299 | call_usermodehelper(RadioPowerPath, argv, envp, 1); | 2299 | call_usermodehelper(RadioPowerPath, argv, envp, UMH_WAIT_PROC); |
2300 | } | 2300 | } |
2301 | } | 2301 | } |
2302 | 2302 | ||
diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c index 9db3de3a8418..260cca7ddb41 100644 --- a/drivers/video/uvesafb.c +++ b/drivers/video/uvesafb.c | |||
@@ -121,7 +121,7 @@ static int uvesafb_helper_start(void) | |||
121 | NULL, | 121 | NULL, |
122 | }; | 122 | }; |
123 | 123 | ||
124 | return call_usermodehelper(v86d_path, argv, envp, 1); | 124 | return call_usermodehelper(v86d_path, argv, envp, UMH_WAIT_PROC); |
125 | } | 125 | } |
126 | 126 | ||
127 | /* | 127 | /* |
diff --git a/security/tomoyo/load_policy.c b/security/tomoyo/load_policy.c index 67975405140f..078fac0bb4c5 100644 --- a/security/tomoyo/load_policy.c +++ b/security/tomoyo/load_policy.c | |||
@@ -102,7 +102,7 @@ void tomoyo_load_policy(const char *filename) | |||
102 | envp[0] = "HOME=/"; | 102 | envp[0] = "HOME=/"; |
103 | envp[1] = "PATH=/sbin:/bin:/usr/sbin:/usr/bin"; | 103 | envp[1] = "PATH=/sbin:/bin:/usr/sbin:/usr/bin"; |
104 | envp[2] = NULL; | 104 | envp[2] = NULL; |
105 | call_usermodehelper(argv[0], argv, envp, 1); | 105 | call_usermodehelper(argv[0], argv, envp, UMH_WAIT_PROC); |
106 | tomoyo_check_profile(); | 106 | tomoyo_check_profile(); |
107 | } | 107 | } |
108 | 108 | ||