diff options
| author | Beni Lev <beni.lev@intel.com> | 2013-02-19 07:40:11 -0500 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2013-03-06 10:47:03 -0500 |
| commit | 6e6cc9f319bf81b292ceb281228ab1d261172cac (patch) | |
| tree | 7daee37fe515dc4edcb9b5823efe54dafd25e45f | |
| parent | f4a7dfa3f21afc1b2362f19cebc79d3d7d5a9aee (diff) | |
iwlwifi: disable greenfield transmissions as a workaround
There's a bug that causes the rate scaling to get stuck
when it has to use single-stream rates with a peer that
can do GF and SGI; the two are incompatible so we can't
use them together, but that causes the algorithm to not
work at all, it always rejects updates.
Disable greenfield for now to prevent that problem. The
MVM driver currently only works on devices that don't
support greenfield anyway, but better be safe and not
allow us to forget about this.
Signed-off-by: Beni Lev <beni.lev@intel.com>
Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
| -rw-r--r-- | drivers/net/wireless/iwlwifi/mvm/rs.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/drivers/net/wireless/iwlwifi/mvm/rs.c b/drivers/net/wireless/iwlwifi/mvm/rs.c index 56b636d9ab30..a01a6612677e 100644 --- a/drivers/net/wireless/iwlwifi/mvm/rs.c +++ b/drivers/net/wireless/iwlwifi/mvm/rs.c | |||
| @@ -680,12 +680,14 @@ static int rs_toggle_antenna(u32 valid_ant, u32 *rate_n_flags, | |||
| 680 | */ | 680 | */ |
| 681 | static bool rs_use_green(struct ieee80211_sta *sta) | 681 | static bool rs_use_green(struct ieee80211_sta *sta) |
| 682 | { | 682 | { |
| 683 | struct iwl_mvm_sta *sta_priv = (void *)sta->drv_priv; | 683 | /* |
| 684 | 684 | * There's a bug somewhere in this code that causes the | |
| 685 | bool use_green = !(sta_priv->vif->bss_conf.ht_operation_mode & | 685 | * scaling to get stuck because GF+SGI can't be combined |
| 686 | IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT); | 686 | * in SISO rates. Until we find that bug, disable GF, it |
| 687 | 687 | * has only limited benefit and we still interoperate with | |
| 688 | return (sta->ht_cap.cap & IEEE80211_HT_CAP_GRN_FLD) && use_green; | 688 | * GF APs since we can always receive GF transmissions. |
| 689 | */ | ||
| 690 | return false; | ||
| 689 | } | 691 | } |
| 690 | 692 | ||
| 691 | /** | 693 | /** |