diff options
author | Antti Palosaari <crope@iki.fi> | 2013-03-09 09:36:35 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-03-23 08:59:56 -0400 |
commit | 6d7cfec4130fdbe4b74277c91b6ba91f56eaca03 (patch) | |
tree | 02947c12d494744a4195e0161985e2625230bac6 | |
parent | bdecbe43e345d1e5a0fa82625d7beb7c3371763e (diff) |
[media] dvb_usb_v2: make checkpatch.pl happy
New checkpatch version likes to see strings not to split multiple
lines even those are exceeding 80 line length.
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r-- | drivers/media/usb/dvb-usb-v2/dvb_usb_core.c | 81 | ||||
-rw-r--r-- | drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c | 5 | ||||
-rw-r--r-- | drivers/media/usb/dvb-usb-v2/usb_urb.c | 36 |
3 files changed, 65 insertions, 57 deletions
diff --git a/drivers/media/usb/dvb-usb-v2/dvb_usb_core.c b/drivers/media/usb/dvb-usb-v2/dvb_usb_core.c index c91da3c4d332..9b24a0e9675a 100644 --- a/drivers/media/usb/dvb-usb-v2/dvb_usb_core.c +++ b/drivers/media/usb/dvb-usb-v2/dvb_usb_core.c | |||
@@ -28,10 +28,11 @@ MODULE_PARM_DESC(disable_rc_polling, | |||
28 | static int dvb_usb_force_pid_filter_usage; | 28 | static int dvb_usb_force_pid_filter_usage; |
29 | module_param_named(force_pid_filter_usage, dvb_usb_force_pid_filter_usage, | 29 | module_param_named(force_pid_filter_usage, dvb_usb_force_pid_filter_usage, |
30 | int, 0444); | 30 | int, 0444); |
31 | MODULE_PARM_DESC(force_pid_filter_usage, "force all DVB USB devices to use a " \ | 31 | MODULE_PARM_DESC(force_pid_filter_usage, |
32 | "PID filter, if any (default: 0)"); | 32 | "force all DVB USB devices to use a PID filter, if any (default: 0)"); |
33 | 33 | ||
34 | static int dvb_usbv2_download_firmware(struct dvb_usb_device *d, const char *name) | 34 | static int dvb_usbv2_download_firmware(struct dvb_usb_device *d, |
35 | const char *name) | ||
35 | { | 36 | { |
36 | int ret; | 37 | int ret; |
37 | const struct firmware *fw; | 38 | const struct firmware *fw; |
@@ -44,10 +45,9 @@ static int dvb_usbv2_download_firmware(struct dvb_usb_device *d, const char *nam | |||
44 | 45 | ||
45 | ret = request_firmware(&fw, name, &d->udev->dev); | 46 | ret = request_firmware(&fw, name, &d->udev->dev); |
46 | if (ret < 0) { | 47 | if (ret < 0) { |
47 | dev_err(&d->udev->dev, "%s: Did not find the firmware file "\ | 48 | dev_err(&d->udev->dev, |
48 | "'%s'. Please see linux/Documentation/dvb/ " \ | 49 | "%s: Did not find the firmware file '%s'. Please see linux/Documentation/dvb/ for more details on firmware-problems. Status %d\n", |
49 | "for more details on firmware-problems. " \ | 50 | KBUILD_MODNAME, name, ret); |
50 | "Status %d\n", KBUILD_MODNAME, name, ret); | ||
51 | goto err; | 51 | goto err; |
52 | } | 52 | } |
53 | 53 | ||
@@ -181,9 +181,9 @@ static int dvb_usbv2_remote_init(struct dvb_usb_device *d) | |||
181 | /* initialize a work queue for handling polling */ | 181 | /* initialize a work queue for handling polling */ |
182 | INIT_DELAYED_WORK(&d->rc_query_work, | 182 | INIT_DELAYED_WORK(&d->rc_query_work, |
183 | dvb_usb_read_remote_control); | 183 | dvb_usb_read_remote_control); |
184 | dev_info(&d->udev->dev, "%s: schedule remote query interval " \ | 184 | dev_info(&d->udev->dev, |
185 | "to %d msecs\n", KBUILD_MODNAME, | 185 | "%s: schedule remote query interval to %d msecs\n", |
186 | d->rc.interval); | 186 | KBUILD_MODNAME, d->rc.interval); |
187 | schedule_delayed_work(&d->rc_query_work, | 187 | schedule_delayed_work(&d->rc_query_work, |
188 | msecs_to_jiffies(d->rc.interval)); | 188 | msecs_to_jiffies(d->rc.interval)); |
189 | d->rc_polling_active = true; | 189 | d->rc_polling_active = true; |
@@ -266,8 +266,7 @@ static inline int dvb_usb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, | |||
266 | struct dvb_usb_adapter *adap = dvbdmxfeed->demux->priv; | 266 | struct dvb_usb_adapter *adap = dvbdmxfeed->demux->priv; |
267 | struct dvb_usb_device *d = adap_to_d(adap); | 267 | struct dvb_usb_device *d = adap_to_d(adap); |
268 | int ret; | 268 | int ret; |
269 | dev_dbg(&d->udev->dev, "%s: adap=%d active_fe=%d feed_type=%d " \ | 269 | dev_dbg(&d->udev->dev, "%s: adap=%d active_fe=%d feed_type=%d setting pid [%s]: %04x (%04d) at index %d '%s'\n", |
270 | "setting pid [%s]: %04x (%04d) at index %d '%s'\n", | ||
271 | __func__, adap->id, adap->active_fe, dvbdmxfeed->type, | 270 | __func__, adap->id, adap->active_fe, dvbdmxfeed->type, |
272 | adap->pid_filtering ? "yes" : "no", dvbdmxfeed->pid, | 271 | adap->pid_filtering ? "yes" : "no", dvbdmxfeed->pid, |
273 | dvbdmxfeed->pid, dvbdmxfeed->index, | 272 | dvbdmxfeed->pid, dvbdmxfeed->index, |
@@ -289,9 +288,9 @@ static inline int dvb_usb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, | |||
289 | ret = d->props->streaming_ctrl( | 288 | ret = d->props->streaming_ctrl( |
290 | adap->fe[adap->active_fe], 0); | 289 | adap->fe[adap->active_fe], 0); |
291 | if (ret < 0) { | 290 | if (ret < 0) { |
292 | dev_err(&d->udev->dev, "%s: streaming_ctrl() " \ | 291 | dev_err(&d->udev->dev, |
293 | "failed=%d\n", KBUILD_MODNAME, | 292 | "%s: streaming_ctrl() failed=%d\n", |
294 | ret); | 293 | KBUILD_MODNAME, ret); |
295 | usb_urb_killv2(&adap->stream); | 294 | usb_urb_killv2(&adap->stream); |
296 | goto err_clear_wait; | 295 | goto err_clear_wait; |
297 | } | 296 | } |
@@ -354,8 +353,8 @@ static inline int dvb_usb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, | |||
354 | ret = adap->props->pid_filter_ctrl(adap, | 353 | ret = adap->props->pid_filter_ctrl(adap, |
355 | adap->pid_filtering); | 354 | adap->pid_filtering); |
356 | if (ret < 0) { | 355 | if (ret < 0) { |
357 | dev_err(&d->udev->dev, "%s: " \ | 356 | dev_err(&d->udev->dev, |
358 | "pid_filter_ctrl() failed=%d\n", | 357 | "%s: pid_filter_ctrl() failed=%d\n", |
359 | KBUILD_MODNAME, ret); | 358 | KBUILD_MODNAME, ret); |
360 | goto err_clear_wait; | 359 | goto err_clear_wait; |
361 | } | 360 | } |
@@ -365,9 +364,9 @@ static inline int dvb_usb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, | |||
365 | ret = d->props->streaming_ctrl( | 364 | ret = d->props->streaming_ctrl( |
366 | adap->fe[adap->active_fe], 1); | 365 | adap->fe[adap->active_fe], 1); |
367 | if (ret < 0) { | 366 | if (ret < 0) { |
368 | dev_err(&d->udev->dev, "%s: streaming_ctrl() " \ | 367 | dev_err(&d->udev->dev, |
369 | "failed=%d\n", KBUILD_MODNAME, | 368 | "%s: streaming_ctrl() failed=%d\n", |
370 | ret); | 369 | KBUILD_MODNAME, ret); |
371 | goto err_clear_wait; | 370 | goto err_clear_wait; |
372 | } | 371 | } |
373 | } | 372 | } |
@@ -595,8 +594,9 @@ static int dvb_usbv2_adapter_frontend_init(struct dvb_usb_adapter *adap) | |||
595 | if (d->props->frontend_attach) { | 594 | if (d->props->frontend_attach) { |
596 | ret = d->props->frontend_attach(adap); | 595 | ret = d->props->frontend_attach(adap); |
597 | if (ret < 0) { | 596 | if (ret < 0) { |
598 | dev_dbg(&d->udev->dev, "%s: frontend_attach() " \ | 597 | dev_dbg(&d->udev->dev, |
599 | "failed=%d\n", __func__, ret); | 598 | "%s: frontend_attach() failed=%d\n", |
599 | __func__, ret); | ||
600 | goto err_dvb_frontend_detach; | 600 | goto err_dvb_frontend_detach; |
601 | } | 601 | } |
602 | } else { | 602 | } else { |
@@ -616,8 +616,9 @@ static int dvb_usbv2_adapter_frontend_init(struct dvb_usb_adapter *adap) | |||
616 | 616 | ||
617 | ret = dvb_register_frontend(&adap->dvb_adap, adap->fe[i]); | 617 | ret = dvb_register_frontend(&adap->dvb_adap, adap->fe[i]); |
618 | if (ret < 0) { | 618 | if (ret < 0) { |
619 | dev_err(&d->udev->dev, "%s: frontend%d registration " \ | 619 | dev_err(&d->udev->dev, |
620 | "failed\n", KBUILD_MODNAME, i); | 620 | "%s: frontend%d registration failed\n", |
621 | KBUILD_MODNAME, i); | ||
621 | goto err_dvb_unregister_frontend; | 622 | goto err_dvb_unregister_frontend; |
622 | } | 623 | } |
623 | 624 | ||
@@ -691,33 +692,33 @@ static int dvb_usbv2_adapter_init(struct dvb_usb_device *d) | |||
691 | /* speed - when running at FULL speed we need a HW PID filter */ | 692 | /* speed - when running at FULL speed we need a HW PID filter */ |
692 | if (d->udev->speed == USB_SPEED_FULL && | 693 | if (d->udev->speed == USB_SPEED_FULL && |
693 | !(adap->props->caps & DVB_USB_ADAP_HAS_PID_FILTER)) { | 694 | !(adap->props->caps & DVB_USB_ADAP_HAS_PID_FILTER)) { |
694 | dev_err(&d->udev->dev, "%s: this USB2.0 device " \ | 695 | dev_err(&d->udev->dev, |
695 | "cannot be run on a USB1.1 port (it " \ | 696 | "%s: this USB2.0 device cannot be run on a USB1.1 port (it lacks a hardware PID filter)\n", |
696 | "lacks a hardware PID filter)\n", | ||
697 | KBUILD_MODNAME); | 697 | KBUILD_MODNAME); |
698 | ret = -ENODEV; | 698 | ret = -ENODEV; |
699 | goto err; | 699 | goto err; |
700 | } else if ((d->udev->speed == USB_SPEED_FULL && | 700 | } else if ((d->udev->speed == USB_SPEED_FULL && |
701 | adap->props->caps & DVB_USB_ADAP_HAS_PID_FILTER) || | 701 | adap->props->caps & DVB_USB_ADAP_HAS_PID_FILTER) || |
702 | (adap->props->caps & DVB_USB_ADAP_NEED_PID_FILTERING)) { | 702 | (adap->props->caps & DVB_USB_ADAP_NEED_PID_FILTERING)) { |
703 | dev_info(&d->udev->dev, "%s: will use the device's " \ | 703 | dev_info(&d->udev->dev, |
704 | "hardware PID filter " \ | 704 | "%s: will use the device's hardware PID filter (table count: %d)\n", |
705 | "(table count: %d)\n", KBUILD_MODNAME, | 705 | KBUILD_MODNAME, |
706 | adap->props->pid_filter_count); | 706 | adap->props->pid_filter_count); |
707 | adap->pid_filtering = 1; | 707 | adap->pid_filtering = 1; |
708 | adap->max_feed_count = adap->props->pid_filter_count; | 708 | adap->max_feed_count = adap->props->pid_filter_count; |
709 | } else { | 709 | } else { |
710 | dev_info(&d->udev->dev, "%s: will pass the complete " \ | 710 | dev_info(&d->udev->dev, |
711 | "MPEG2 transport stream to the " \ | 711 | "%s: will pass the complete MPEG2 transport stream to the software demuxer\n", |
712 | "software demuxer\n", KBUILD_MODNAME); | 712 | KBUILD_MODNAME); |
713 | adap->pid_filtering = 0; | 713 | adap->pid_filtering = 0; |
714 | adap->max_feed_count = 255; | 714 | adap->max_feed_count = 255; |
715 | } | 715 | } |
716 | 716 | ||
717 | if (!adap->pid_filtering && dvb_usb_force_pid_filter_usage && | 717 | if (!adap->pid_filtering && dvb_usb_force_pid_filter_usage && |
718 | adap->props->caps & DVB_USB_ADAP_HAS_PID_FILTER) { | 718 | adap->props->caps & DVB_USB_ADAP_HAS_PID_FILTER) { |
719 | dev_info(&d->udev->dev, "%s: PID filter enabled by " \ | 719 | dev_info(&d->udev->dev, |
720 | "module option\n", KBUILD_MODNAME); | 720 | "%s: PID filter enabled by module option\n", |
721 | KBUILD_MODNAME); | ||
721 | adap->pid_filtering = 1; | 722 | adap->pid_filtering = 1; |
722 | adap->max_feed_count = adap->props->pid_filter_count; | 723 | adap->max_feed_count = adap->props->pid_filter_count; |
723 | } | 724 | } |
@@ -846,8 +847,9 @@ static void dvb_usbv2_init_work(struct work_struct *work) | |||
846 | if (ret == 0) { | 847 | if (ret == 0) { |
847 | ; | 848 | ; |
848 | } else if (ret == COLD) { | 849 | } else if (ret == COLD) { |
849 | dev_info(&d->udev->dev, "%s: found a '%s' in cold " \ | 850 | dev_info(&d->udev->dev, |
850 | "state\n", KBUILD_MODNAME, d->name); | 851 | "%s: found a '%s' in cold state\n", |
852 | KBUILD_MODNAME, d->name); | ||
851 | 853 | ||
852 | if (!name) | 854 | if (!name) |
853 | name = d->props->firmware; | 855 | name = d->props->firmware; |
@@ -889,8 +891,9 @@ static void dvb_usbv2_init_work(struct work_struct *work) | |||
889 | if (ret < 0) | 891 | if (ret < 0) |
890 | goto err_usb_driver_release_interface; | 892 | goto err_usb_driver_release_interface; |
891 | 893 | ||
892 | dev_info(&d->udev->dev, "%s: '%s' successfully initialized and " \ | 894 | dev_info(&d->udev->dev, |
893 | "connected\n", KBUILD_MODNAME, d->name); | 895 | "%s: '%s' successfully initialized and connected\n", |
896 | KBUILD_MODNAME, d->name); | ||
894 | 897 | ||
895 | return; | 898 | return; |
896 | err_usb_driver_release_interface: | 899 | err_usb_driver_release_interface: |
diff --git a/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c b/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c index aa0c35ef3179..33ff97e708e3 100644 --- a/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c +++ b/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c | |||
@@ -54,8 +54,9 @@ static int dvb_usb_v2_generic_io(struct dvb_usb_device *d, | |||
54 | d->props->generic_bulk_ctrl_endpoint_response), | 54 | d->props->generic_bulk_ctrl_endpoint_response), |
55 | rbuf, rlen, &actual_length, 2000); | 55 | rbuf, rlen, &actual_length, 2000); |
56 | if (ret) | 56 | if (ret) |
57 | dev_err(&d->udev->dev, "%s: 2nd usb_bulk_msg() " \ | 57 | dev_err(&d->udev->dev, |
58 | "failed=%d\n", KBUILD_MODNAME, ret); | 58 | "%s: 2nd usb_bulk_msg() failed=%d\n", |
59 | KBUILD_MODNAME, ret); | ||
59 | 60 | ||
60 | dev_dbg(&d->udev->dev, "%s: <<< %*ph\n", __func__, | 61 | dev_dbg(&d->udev->dev, "%s: <<< %*ph\n", __func__, |
61 | actual_length, rbuf); | 62 | actual_length, rbuf); |
diff --git a/drivers/media/usb/dvb-usb-v2/usb_urb.c b/drivers/media/usb/dvb-usb-v2/usb_urb.c index 7346f85f3f2f..ca8f3c2b1082 100644 --- a/drivers/media/usb/dvb-usb-v2/usb_urb.c +++ b/drivers/media/usb/dvb-usb-v2/usb_urb.c | |||
@@ -22,8 +22,8 @@ static void usb_urb_complete(struct urb *urb) | |||
22 | int i; | 22 | int i; |
23 | u8 *b; | 23 | u8 *b; |
24 | 24 | ||
25 | dev_dbg_ratelimited(&stream->udev->dev, "%s: %s urb completed " \ | 25 | dev_dbg_ratelimited(&stream->udev->dev, |
26 | "status=%d length=%d/%d pack_num=%d errors=%d\n", | 26 | "%s: %s urb completed status=%d length=%d/%d pack_num=%d errors=%d\n", |
27 | __func__, ptype == PIPE_ISOCHRONOUS ? "isoc" : "bulk", | 27 | __func__, ptype == PIPE_ISOCHRONOUS ? "isoc" : "bulk", |
28 | urb->status, urb->actual_length, | 28 | urb->status, urb->actual_length, |
29 | urb->transfer_buffer_length, | 29 | urb->transfer_buffer_length, |
@@ -49,8 +49,8 @@ static void usb_urb_complete(struct urb *urb) | |||
49 | case PIPE_ISOCHRONOUS: | 49 | case PIPE_ISOCHRONOUS: |
50 | for (i = 0; i < urb->number_of_packets; i++) { | 50 | for (i = 0; i < urb->number_of_packets; i++) { |
51 | if (urb->iso_frame_desc[i].status != 0) | 51 | if (urb->iso_frame_desc[i].status != 0) |
52 | dev_dbg(&stream->udev->dev, "%s: iso frame " \ | 52 | dev_dbg(&stream->udev->dev, |
53 | "descriptor has an error=%d\n", | 53 | "%s: iso frame descriptor has an error=%d\n", |
54 | __func__, | 54 | __func__, |
55 | urb->iso_frame_desc[i].status); | 55 | urb->iso_frame_desc[i].status); |
56 | else if (urb->iso_frame_desc[i].actual_length > 0) | 56 | else if (urb->iso_frame_desc[i].actual_length > 0) |
@@ -67,8 +67,9 @@ static void usb_urb_complete(struct urb *urb) | |||
67 | stream->complete(stream, b, urb->actual_length); | 67 | stream->complete(stream, b, urb->actual_length); |
68 | break; | 68 | break; |
69 | default: | 69 | default: |
70 | dev_err(&stream->udev->dev, "%s: unknown endpoint type in " \ | 70 | dev_err(&stream->udev->dev, |
71 | "completition handler\n", KBUILD_MODNAME); | 71 | "%s: unknown endpoint type in completition handler\n", |
72 | KBUILD_MODNAME); | ||
72 | return; | 73 | return; |
73 | } | 74 | } |
74 | usb_submit_urb(urb, GFP_ATOMIC); | 75 | usb_submit_urb(urb, GFP_ATOMIC); |
@@ -101,8 +102,8 @@ int usb_urb_submitv2(struct usb_data_stream *stream, | |||
101 | dev_dbg(&stream->udev->dev, "%s: submit urb=%d\n", __func__, i); | 102 | dev_dbg(&stream->udev->dev, "%s: submit urb=%d\n", __func__, i); |
102 | ret = usb_submit_urb(stream->urb_list[i], GFP_ATOMIC); | 103 | ret = usb_submit_urb(stream->urb_list[i], GFP_ATOMIC); |
103 | if (ret) { | 104 | if (ret) { |
104 | dev_err(&stream->udev->dev, "%s: could not submit " \ | 105 | dev_err(&stream->udev->dev, |
105 | "urb no. %d - get them all back\n", | 106 | "%s: could not submit urb no. %d - get them all back\n", |
106 | KBUILD_MODNAME, i); | 107 | KBUILD_MODNAME, i); |
107 | usb_urb_killv2(stream); | 108 | usb_urb_killv2(stream); |
108 | return ret; | 109 | return ret; |
@@ -229,8 +230,9 @@ static int usb_alloc_stream_buffers(struct usb_data_stream *stream, int num, | |||
229 | stream->buf_num = 0; | 230 | stream->buf_num = 0; |
230 | stream->buf_size = size; | 231 | stream->buf_size = size; |
231 | 232 | ||
232 | dev_dbg(&stream->udev->dev, "%s: all in all I will use %lu bytes for " \ | 233 | dev_dbg(&stream->udev->dev, |
233 | "streaming\n", __func__, num * size); | 234 | "%s: all in all I will use %lu bytes for streaming\n", |
235 | __func__, num * size); | ||
234 | 236 | ||
235 | for (stream->buf_num = 0; stream->buf_num < num; stream->buf_num++) { | 237 | for (stream->buf_num = 0; stream->buf_num < num; stream->buf_num++) { |
236 | stream->buf_list[stream->buf_num] = usb_alloc_coherent( | 238 | stream->buf_list[stream->buf_num] = usb_alloc_coherent( |
@@ -274,8 +276,8 @@ int usb_urb_reconfig(struct usb_data_stream *stream, | |||
274 | } | 276 | } |
275 | 277 | ||
276 | if (stream->buf_num < props->count || stream->buf_size < buf_size) { | 278 | if (stream->buf_num < props->count || stream->buf_size < buf_size) { |
277 | dev_err(&stream->udev->dev, "%s: cannot reconfigure as " \ | 279 | dev_err(&stream->udev->dev, |
278 | "allocated buffers are too small\n", | 280 | "%s: cannot reconfigure as allocated buffers are too small\n", |
279 | KBUILD_MODNAME); | 281 | KBUILD_MODNAME); |
280 | return -EINVAL; | 282 | return -EINVAL; |
281 | } | 283 | } |
@@ -321,8 +323,9 @@ int usb_urb_initv2(struct usb_data_stream *stream, | |||
321 | memcpy(&stream->props, props, sizeof(*props)); | 323 | memcpy(&stream->props, props, sizeof(*props)); |
322 | 324 | ||
323 | if (!stream->complete) { | 325 | if (!stream->complete) { |
324 | dev_err(&stream->udev->dev, "%s: there is no data callback - " \ | 326 | dev_err(&stream->udev->dev, |
325 | "this doesn't make sense\n", KBUILD_MODNAME); | 327 | "%s: there is no data callback - this doesn't make sense\n", |
328 | KBUILD_MODNAME); | ||
326 | return -EINVAL; | 329 | return -EINVAL; |
327 | } | 330 | } |
328 | 331 | ||
@@ -343,8 +346,9 @@ int usb_urb_initv2(struct usb_data_stream *stream, | |||
343 | 346 | ||
344 | return usb_urb_alloc_isoc_urbs(stream); | 347 | return usb_urb_alloc_isoc_urbs(stream); |
345 | default: | 348 | default: |
346 | dev_err(&stream->udev->dev, "%s: unknown urb-type for data " \ | 349 | dev_err(&stream->udev->dev, |
347 | "transfer\n", KBUILD_MODNAME); | 350 | "%s: unknown urb-type for data transfer\n", |
351 | KBUILD_MODNAME); | ||
348 | return -EINVAL; | 352 | return -EINVAL; |
349 | } | 353 | } |
350 | } | 354 | } |