diff options
author | David Ertman <davidx.m.ertman@intel.com> | 2014-04-05 02:07:00 -0400 |
---|---|---|
committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2014-04-23 04:05:08 -0400 |
commit | 6cf08d1c50872acb6c8400567b1df2d02a03e58d (patch) | |
tree | b5f7afa11cd7b3652d9b8302ebe538d5ddccce37 | |
parent | 3992c8ed48be25a37f6dd04a9c46a4504674546a (diff) |
e1000e: Cleanup to fix checkpatch missing blank lines
Fixing "WARNING:SPACING: networking uses a blank line after declarations"
Signed-off-by: Dave Ertman <davidx.m.ertman@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/ethtool.c | 3 | ||||
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/ich8lan.c | 1 | ||||
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/netdev.c | 13 | ||||
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/nvm.c | 1 | ||||
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/param.c | 4 | ||||
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/phy.c | 1 |
6 files changed, 23 insertions, 0 deletions
diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c index 2204a9c412b5..4e5ad7ebe1f2 100644 --- a/drivers/net/ethernet/intel/e1000e/ethtool.c +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c | |||
@@ -169,6 +169,7 @@ static int e1000_get_settings(struct net_device *netdev, | |||
169 | } | 169 | } |
170 | } else if (!pm_runtime_suspended(netdev->dev.parent)) { | 170 | } else if (!pm_runtime_suspended(netdev->dev.parent)) { |
171 | u32 status = er32(STATUS); | 171 | u32 status = er32(STATUS); |
172 | |||
172 | if (status & E1000_STATUS_LU) { | 173 | if (status & E1000_STATUS_LU) { |
173 | if (status & E1000_STATUS_SPEED_1000) | 174 | if (status & E1000_STATUS_SPEED_1000) |
174 | speed = SPEED_1000; | 175 | speed = SPEED_1000; |
@@ -793,6 +794,7 @@ static bool reg_set_and_check(struct e1000_adapter *adapter, u64 *data, | |||
793 | int reg, u32 mask, u32 write) | 794 | int reg, u32 mask, u32 write) |
794 | { | 795 | { |
795 | u32 val; | 796 | u32 val; |
797 | |||
796 | __ew32(&adapter->hw, reg, write & mask); | 798 | __ew32(&adapter->hw, reg, write & mask); |
797 | val = __er32(&adapter->hw, reg); | 799 | val = __er32(&adapter->hw, reg); |
798 | if ((write & mask) != (val & mask)) { | 800 | if ((write & mask) != (val & mask)) { |
@@ -1717,6 +1719,7 @@ static int e1000_link_test(struct e1000_adapter *adapter, u64 *data) | |||
1717 | *data = 0; | 1719 | *data = 0; |
1718 | if (hw->phy.media_type == e1000_media_type_internal_serdes) { | 1720 | if (hw->phy.media_type == e1000_media_type_internal_serdes) { |
1719 | int i = 0; | 1721 | int i = 0; |
1722 | |||
1720 | hw->mac.serdes_has_link = false; | 1723 | hw->mac.serdes_has_link = false; |
1721 | 1724 | ||
1722 | /* On some blade server designs, link establishment | 1725 | /* On some blade server designs, link establishment |
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c index 9866f264f55e..a2901139b209 100644 --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c | |||
@@ -1320,6 +1320,7 @@ static s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw) | |||
1320 | */ | 1320 | */ |
1321 | if ((hw->mac.type == e1000_pch2lan) && link) { | 1321 | if ((hw->mac.type == e1000_pch2lan) && link) { |
1322 | u32 reg; | 1322 | u32 reg; |
1323 | |||
1323 | reg = er32(STATUS); | 1324 | reg = er32(STATUS); |
1324 | if (!(reg & (E1000_STATUS_FD | E1000_STATUS_SPEED_MASK))) { | 1325 | if (!(reg & (E1000_STATUS_FD | E1000_STATUS_SPEED_MASK))) { |
1325 | reg = er32(TIPG); | 1326 | reg = er32(TIPG); |
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 255481c389e3..90077e8955a7 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c | |||
@@ -599,6 +599,7 @@ static void e1000e_update_rdt_wa(struct e1000_ring *rx_ring, unsigned int i) | |||
599 | 599 | ||
600 | if (unlikely(!ret_val && (i != readl(rx_ring->tail)))) { | 600 | if (unlikely(!ret_val && (i != readl(rx_ring->tail)))) { |
601 | u32 rctl = er32(RCTL); | 601 | u32 rctl = er32(RCTL); |
602 | |||
602 | ew32(RCTL, rctl & ~E1000_RCTL_EN); | 603 | ew32(RCTL, rctl & ~E1000_RCTL_EN); |
603 | e_err("ME firmware caused invalid RDT - resetting\n"); | 604 | e_err("ME firmware caused invalid RDT - resetting\n"); |
604 | schedule_work(&adapter->reset_task); | 605 | schedule_work(&adapter->reset_task); |
@@ -615,6 +616,7 @@ static void e1000e_update_tdt_wa(struct e1000_ring *tx_ring, unsigned int i) | |||
615 | 616 | ||
616 | if (unlikely(!ret_val && (i != readl(tx_ring->tail)))) { | 617 | if (unlikely(!ret_val && (i != readl(tx_ring->tail)))) { |
617 | u32 tctl = er32(TCTL); | 618 | u32 tctl = er32(TCTL); |
619 | |||
618 | ew32(TCTL, tctl & ~E1000_TCTL_EN); | 620 | ew32(TCTL, tctl & ~E1000_TCTL_EN); |
619 | e_err("ME firmware caused invalid TDT - resetting\n"); | 621 | e_err("ME firmware caused invalid TDT - resetting\n"); |
620 | schedule_work(&adapter->reset_task); | 622 | schedule_work(&adapter->reset_task); |
@@ -1198,6 +1200,7 @@ static bool e1000_clean_tx_irq(struct e1000_ring *tx_ring) | |||
1198 | while ((eop_desc->upper.data & cpu_to_le32(E1000_TXD_STAT_DD)) && | 1200 | while ((eop_desc->upper.data & cpu_to_le32(E1000_TXD_STAT_DD)) && |
1199 | (count < tx_ring->count)) { | 1201 | (count < tx_ring->count)) { |
1200 | bool cleaned = false; | 1202 | bool cleaned = false; |
1203 | |||
1201 | rmb(); /* read buffer_info after eop_desc */ | 1204 | rmb(); /* read buffer_info after eop_desc */ |
1202 | for (; !cleaned; count++) { | 1205 | for (; !cleaned; count++) { |
1203 | tx_desc = E1000_TX_DESC(*tx_ring, i); | 1206 | tx_desc = E1000_TX_DESC(*tx_ring, i); |
@@ -1753,6 +1756,7 @@ static irqreturn_t e1000_intr_msi(int __always_unused irq, void *data) | |||
1753 | adapter->flags & FLAG_RX_NEEDS_RESTART) { | 1756 | adapter->flags & FLAG_RX_NEEDS_RESTART) { |
1754 | /* disable receives */ | 1757 | /* disable receives */ |
1755 | u32 rctl = er32(RCTL); | 1758 | u32 rctl = er32(RCTL); |
1759 | |||
1756 | ew32(RCTL, rctl & ~E1000_RCTL_EN); | 1760 | ew32(RCTL, rctl & ~E1000_RCTL_EN); |
1757 | adapter->flags |= FLAG_RESTART_NOW; | 1761 | adapter->flags |= FLAG_RESTART_NOW; |
1758 | } | 1762 | } |
@@ -1960,6 +1964,7 @@ static void e1000_configure_msix(struct e1000_adapter *adapter) | |||
1960 | /* Workaround issue with spurious interrupts on 82574 in MSI-X mode */ | 1964 | /* Workaround issue with spurious interrupts on 82574 in MSI-X mode */ |
1961 | if (hw->mac.type == e1000_82574) { | 1965 | if (hw->mac.type == e1000_82574) { |
1962 | u32 rfctl = er32(RFCTL); | 1966 | u32 rfctl = er32(RFCTL); |
1967 | |||
1963 | rfctl |= E1000_RFCTL_ACK_DIS; | 1968 | rfctl |= E1000_RFCTL_ACK_DIS; |
1964 | ew32(RFCTL, rfctl); | 1969 | ew32(RFCTL, rfctl); |
1965 | } | 1970 | } |
@@ -2204,6 +2209,7 @@ static void e1000_irq_disable(struct e1000_adapter *adapter) | |||
2204 | 2209 | ||
2205 | if (adapter->msix_entries) { | 2210 | if (adapter->msix_entries) { |
2206 | int i; | 2211 | int i; |
2212 | |||
2207 | for (i = 0; i < adapter->num_vectors; i++) | 2213 | for (i = 0; i < adapter->num_vectors; i++) |
2208 | synchronize_irq(adapter->msix_entries[i].vector); | 2214 | synchronize_irq(adapter->msix_entries[i].vector); |
2209 | } else { | 2215 | } else { |
@@ -2921,6 +2927,7 @@ static void e1000_configure_tx(struct e1000_adapter *adapter) | |||
2921 | 2927 | ||
2922 | if (adapter->flags2 & FLAG2_DMA_BURST) { | 2928 | if (adapter->flags2 & FLAG2_DMA_BURST) { |
2923 | u32 txdctl = er32(TXDCTL(0)); | 2929 | u32 txdctl = er32(TXDCTL(0)); |
2930 | |||
2924 | txdctl &= ~(E1000_TXDCTL_PTHRESH | E1000_TXDCTL_HTHRESH | | 2931 | txdctl &= ~(E1000_TXDCTL_PTHRESH | E1000_TXDCTL_HTHRESH | |
2925 | E1000_TXDCTL_WTHRESH); | 2932 | E1000_TXDCTL_WTHRESH); |
2926 | /* set up some performance related parameters to encourage the | 2933 | /* set up some performance related parameters to encourage the |
@@ -3239,6 +3246,7 @@ static void e1000_configure_rx(struct e1000_adapter *adapter) | |||
3239 | 3246 | ||
3240 | if (adapter->flags & FLAG_IS_ICH) { | 3247 | if (adapter->flags & FLAG_IS_ICH) { |
3241 | u32 rxdctl = er32(RXDCTL(0)); | 3248 | u32 rxdctl = er32(RXDCTL(0)); |
3249 | |||
3242 | ew32(RXDCTL(0), rxdctl | 0x3); | 3250 | ew32(RXDCTL(0), rxdctl | 0x3); |
3243 | } | 3251 | } |
3244 | 3252 | ||
@@ -4695,6 +4703,7 @@ static void e1000e_update_stats(struct e1000_adapter *adapter) | |||
4695 | /* Correctable ECC Errors */ | 4703 | /* Correctable ECC Errors */ |
4696 | if (hw->mac.type == e1000_pch_lpt) { | 4704 | if (hw->mac.type == e1000_pch_lpt) { |
4697 | u32 pbeccsts = er32(PBECCSTS); | 4705 | u32 pbeccsts = er32(PBECCSTS); |
4706 | |||
4698 | adapter->corr_errors += | 4707 | adapter->corr_errors += |
4699 | pbeccsts & E1000_PBECCSTS_CORR_ERR_CNT_MASK; | 4708 | pbeccsts & E1000_PBECCSTS_CORR_ERR_CNT_MASK; |
4700 | adapter->uncorr_errors += | 4709 | adapter->uncorr_errors += |
@@ -4808,6 +4817,7 @@ static void e1000e_enable_receives(struct e1000_adapter *adapter) | |||
4808 | (adapter->flags & FLAG_RESTART_NOW)) { | 4817 | (adapter->flags & FLAG_RESTART_NOW)) { |
4809 | struct e1000_hw *hw = &adapter->hw; | 4818 | struct e1000_hw *hw = &adapter->hw; |
4810 | u32 rctl = er32(RCTL); | 4819 | u32 rctl = er32(RCTL); |
4820 | |||
4811 | ew32(RCTL, rctl | E1000_RCTL_EN); | 4821 | ew32(RCTL, rctl | E1000_RCTL_EN); |
4812 | adapter->flags &= ~FLAG_RESTART_NOW; | 4822 | adapter->flags &= ~FLAG_RESTART_NOW; |
4813 | } | 4823 | } |
@@ -4930,6 +4940,7 @@ static void e1000_watchdog_task(struct work_struct *work) | |||
4930 | if ((adapter->flags & FLAG_TARC_SPEED_MODE_BIT) && | 4940 | if ((adapter->flags & FLAG_TARC_SPEED_MODE_BIT) && |
4931 | !txb2b) { | 4941 | !txb2b) { |
4932 | u32 tarc0; | 4942 | u32 tarc0; |
4943 | |||
4933 | tarc0 = er32(TARC(0)); | 4944 | tarc0 = er32(TARC(0)); |
4934 | tarc0 &= ~SPEED_MODE_BIT; | 4945 | tarc0 &= ~SPEED_MODE_BIT; |
4935 | ew32(TARC(0), tarc0); | 4946 | ew32(TARC(0), tarc0); |
@@ -6209,6 +6220,7 @@ static int __e1000_resume(struct pci_dev *pdev) | |||
6209 | e1e_wphy(&adapter->hw, BM_WUS, ~0); | 6220 | e1e_wphy(&adapter->hw, BM_WUS, ~0); |
6210 | } else { | 6221 | } else { |
6211 | u32 wus = er32(WUS); | 6222 | u32 wus = er32(WUS); |
6223 | |||
6212 | if (wus) { | 6224 | if (wus) { |
6213 | e_info("MAC Wakeup cause - %s\n", | 6225 | e_info("MAC Wakeup cause - %s\n", |
6214 | wus & E1000_WUS_EX ? "Unicast Packet" : | 6226 | wus & E1000_WUS_EX ? "Unicast Packet" : |
@@ -7144,6 +7156,7 @@ static struct pci_driver e1000_driver = { | |||
7144 | static int __init e1000_init_module(void) | 7156 | static int __init e1000_init_module(void) |
7145 | { | 7157 | { |
7146 | int ret; | 7158 | int ret; |
7159 | |||
7147 | pr_info("Intel(R) PRO/1000 Network Driver - %s\n", | 7160 | pr_info("Intel(R) PRO/1000 Network Driver - %s\n", |
7148 | e1000e_driver_version); | 7161 | e1000e_driver_version); |
7149 | pr_info("Copyright(c) 1999 - 2014 Intel Corporation.\n"); | 7162 | pr_info("Copyright(c) 1999 - 2014 Intel Corporation.\n"); |
diff --git a/drivers/net/ethernet/intel/e1000e/nvm.c b/drivers/net/ethernet/intel/e1000e/nvm.c index a9a976f04bff..b1f212b7baf7 100644 --- a/drivers/net/ethernet/intel/e1000e/nvm.c +++ b/drivers/net/ethernet/intel/e1000e/nvm.c | |||
@@ -398,6 +398,7 @@ s32 e1000e_write_nvm_spi(struct e1000_hw *hw, u16 offset, u16 words, u16 *data) | |||
398 | /* Loop to allow for up to whole page write of eeprom */ | 398 | /* Loop to allow for up to whole page write of eeprom */ |
399 | while (widx < words) { | 399 | while (widx < words) { |
400 | u16 word_out = data[widx]; | 400 | u16 word_out = data[widx]; |
401 | |||
401 | word_out = (word_out >> 8) | (word_out << 8); | 402 | word_out = (word_out >> 8) | (word_out << 8); |
402 | e1000_shift_out_eec_bits(hw, word_out, 16); | 403 | e1000_shift_out_eec_bits(hw, word_out, 16); |
403 | widx++; | 404 | widx++; |
diff --git a/drivers/net/ethernet/intel/e1000e/param.c b/drivers/net/ethernet/intel/e1000e/param.c index d0ac0f3249c8..aa1923f7ebdd 100644 --- a/drivers/net/ethernet/intel/e1000e/param.c +++ b/drivers/net/ethernet/intel/e1000e/param.c | |||
@@ -436,6 +436,7 @@ void e1000e_check_options(struct e1000_adapter *adapter) | |||
436 | 436 | ||
437 | if (num_IntMode > bd) { | 437 | if (num_IntMode > bd) { |
438 | unsigned int int_mode = IntMode[bd]; | 438 | unsigned int int_mode = IntMode[bd]; |
439 | |||
439 | e1000_validate_option(&int_mode, &opt, adapter); | 440 | e1000_validate_option(&int_mode, &opt, adapter); |
440 | adapter->int_mode = int_mode; | 441 | adapter->int_mode = int_mode; |
441 | } else { | 442 | } else { |
@@ -457,6 +458,7 @@ void e1000e_check_options(struct e1000_adapter *adapter) | |||
457 | 458 | ||
458 | if (num_SmartPowerDownEnable > bd) { | 459 | if (num_SmartPowerDownEnable > bd) { |
459 | unsigned int spd = SmartPowerDownEnable[bd]; | 460 | unsigned int spd = SmartPowerDownEnable[bd]; |
461 | |||
460 | e1000_validate_option(&spd, &opt, adapter); | 462 | e1000_validate_option(&spd, &opt, adapter); |
461 | if ((adapter->flags & FLAG_HAS_SMART_POWER_DOWN) && spd) | 463 | if ((adapter->flags & FLAG_HAS_SMART_POWER_DOWN) && spd) |
462 | adapter->flags |= FLAG_SMART_POWER_DOWN; | 464 | adapter->flags |= FLAG_SMART_POWER_DOWN; |
@@ -473,6 +475,7 @@ void e1000e_check_options(struct e1000_adapter *adapter) | |||
473 | 475 | ||
474 | if (num_CrcStripping > bd) { | 476 | if (num_CrcStripping > bd) { |
475 | unsigned int crc_stripping = CrcStripping[bd]; | 477 | unsigned int crc_stripping = CrcStripping[bd]; |
478 | |||
476 | e1000_validate_option(&crc_stripping, &opt, adapter); | 479 | e1000_validate_option(&crc_stripping, &opt, adapter); |
477 | if (crc_stripping == OPTION_ENABLED) { | 480 | if (crc_stripping == OPTION_ENABLED) { |
478 | adapter->flags2 |= FLAG2_CRC_STRIPPING; | 481 | adapter->flags2 |= FLAG2_CRC_STRIPPING; |
@@ -495,6 +498,7 @@ void e1000e_check_options(struct e1000_adapter *adapter) | |||
495 | 498 | ||
496 | if (num_KumeranLockLoss > bd) { | 499 | if (num_KumeranLockLoss > bd) { |
497 | unsigned int kmrn_lock_loss = KumeranLockLoss[bd]; | 500 | unsigned int kmrn_lock_loss = KumeranLockLoss[bd]; |
501 | |||
498 | e1000_validate_option(&kmrn_lock_loss, &opt, adapter); | 502 | e1000_validate_option(&kmrn_lock_loss, &opt, adapter); |
499 | enabled = kmrn_lock_loss; | 503 | enabled = kmrn_lock_loss; |
500 | } | 504 | } |
diff --git a/drivers/net/ethernet/intel/e1000e/phy.c b/drivers/net/ethernet/intel/e1000e/phy.c index 00b3fc98bf30..b2005e13fb01 100644 --- a/drivers/net/ethernet/intel/e1000e/phy.c +++ b/drivers/net/ethernet/intel/e1000e/phy.c | |||
@@ -2896,6 +2896,7 @@ static s32 __e1000_write_phy_reg_hv(struct e1000_hw *hw, u32 offset, u16 data, | |||
2896 | (hw->phy.addr == 2) && | 2896 | (hw->phy.addr == 2) && |
2897 | !(MAX_PHY_REG_ADDRESS & reg) && (data & (1 << 11))) { | 2897 | !(MAX_PHY_REG_ADDRESS & reg) && (data & (1 << 11))) { |
2898 | u16 data2 = 0x7EFF; | 2898 | u16 data2 = 0x7EFF; |
2899 | |||
2899 | ret_val = e1000_access_phy_debug_regs_hv(hw, | 2900 | ret_val = e1000_access_phy_debug_regs_hv(hw, |
2900 | (1 << 6) | 0x3, | 2901 | (1 << 6) | 0x3, |
2901 | &data2, false); | 2902 | &data2, false); |