diff options
| author | David S. Miller <davem@davemloft.net> | 2013-02-07 23:37:36 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-02-07 23:37:36 -0500 |
| commit | 6cddded4af7ca3a4567a301dbc43357e65a893b6 (patch) | |
| tree | 87e3d05d0d53e66a12959c8915ae7db7a6148766 | |
| parent | 0c35565b460ff99f973fb4a9ec63fbcb4176d2e6 (diff) | |
| parent | d9d59089c43fc33eb403cbb928e56c131f191dd5 (diff) | |
Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jesse/openvswitch into openvswitch
Jesse Gross says:
====================
One bug fix for net/3.8 for a long standing problem that was reported a few
times recently.
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/openvswitch/vport-netdev.c | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c index a9327e2e48ce..670cbc3518de 100644 --- a/net/openvswitch/vport-netdev.c +++ b/net/openvswitch/vport-netdev.c | |||
| @@ -35,10 +35,11 @@ | |||
| 35 | /* Must be called with rcu_read_lock. */ | 35 | /* Must be called with rcu_read_lock. */ |
| 36 | static void netdev_port_receive(struct vport *vport, struct sk_buff *skb) | 36 | static void netdev_port_receive(struct vport *vport, struct sk_buff *skb) |
| 37 | { | 37 | { |
| 38 | if (unlikely(!vport)) { | 38 | if (unlikely(!vport)) |
| 39 | kfree_skb(skb); | 39 | goto error; |
| 40 | return; | 40 | |
| 41 | } | 41 | if (unlikely(skb_warn_if_lro(skb))) |
| 42 | goto error; | ||
| 42 | 43 | ||
| 43 | /* Make our own copy of the packet. Otherwise we will mangle the | 44 | /* Make our own copy of the packet. Otherwise we will mangle the |
| 44 | * packet for anyone who came before us (e.g. tcpdump via AF_PACKET). | 45 | * packet for anyone who came before us (e.g. tcpdump via AF_PACKET). |
| @@ -50,6 +51,10 @@ static void netdev_port_receive(struct vport *vport, struct sk_buff *skb) | |||
| 50 | 51 | ||
| 51 | skb_push(skb, ETH_HLEN); | 52 | skb_push(skb, ETH_HLEN); |
| 52 | ovs_vport_receive(vport, skb); | 53 | ovs_vport_receive(vport, skb); |
| 54 | return; | ||
| 55 | |||
| 56 | error: | ||
| 57 | kfree_skb(skb); | ||
| 53 | } | 58 | } |
| 54 | 59 | ||
| 55 | /* Called with rcu_read_lock and bottom-halves disabled. */ | 60 | /* Called with rcu_read_lock and bottom-halves disabled. */ |
| @@ -169,9 +174,6 @@ static int netdev_send(struct vport *vport, struct sk_buff *skb) | |||
| 169 | goto error; | 174 | goto error; |
| 170 | } | 175 | } |
| 171 | 176 | ||
| 172 | if (unlikely(skb_warn_if_lro(skb))) | ||
| 173 | goto error; | ||
| 174 | |||
| 175 | skb->dev = netdev_vport->dev; | 177 | skb->dev = netdev_vport->dev; |
| 176 | len = skb->len; | 178 | len = skb->len; |
| 177 | dev_queue_xmit(skb); | 179 | dev_queue_xmit(skb); |
