diff options
author | Peter Zijlstra <peterz@infradead.org> | 2014-07-22 05:47:40 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2014-07-28 04:04:13 -0400 |
commit | 6ae72dff37596f736b795426306404f0793e4b1b (patch) | |
tree | 89a6488a4766e799312672baae3350ade42cf276 | |
parent | ca5bc6cd5de5b53eb8fd6fea39aa3fe2a1e8c3d9 (diff) |
sched: Robustify topology setup
We hard assume that higher topology levels are supersets of lower
levels.
Detect, warn and try to fixup when we encounter this violated.
Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Josh Boyer <jwboyer@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Bruno Wolff III <bruno@wolff.to>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20140722094740.GJ12054@laptop.lan
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | kernel/sched/core.c | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 415ab0268b51..2a36a74c16ae 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c | |||
@@ -6481,6 +6481,20 @@ struct sched_domain *build_sched_domain(struct sched_domain_topology_level *tl, | |||
6481 | sched_domain_level_max = max(sched_domain_level_max, sd->level); | 6481 | sched_domain_level_max = max(sched_domain_level_max, sd->level); |
6482 | child->parent = sd; | 6482 | child->parent = sd; |
6483 | sd->child = child; | 6483 | sd->child = child; |
6484 | |||
6485 | if (!cpumask_subset(sched_domain_span(child), | ||
6486 | sched_domain_span(sd))) { | ||
6487 | pr_err("BUG: arch topology borken\n"); | ||
6488 | #ifdef CONFIG_SCHED_DEBUG | ||
6489 | pr_err(" the %s domain not a subset of the %s domain\n", | ||
6490 | child->name, sd->name); | ||
6491 | #endif | ||
6492 | /* Fixup, ensure @sd has at least @child cpus. */ | ||
6493 | cpumask_or(sched_domain_span(sd), | ||
6494 | sched_domain_span(sd), | ||
6495 | sched_domain_span(child)); | ||
6496 | } | ||
6497 | |||
6484 | } | 6498 | } |
6485 | set_domain_attribute(sd, attr); | 6499 | set_domain_attribute(sd, attr); |
6486 | 6500 | ||