diff options
author | Li RongQing <roy.qing.li@gmail.com> | 2013-12-20 04:20:12 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-12-27 13:14:40 -0500 |
commit | 6a9eadccff2926e392173a989042f14c867cffbf (patch) | |
tree | 1aedee4f6e03d14cb30657370aff6a96edf09193 | |
parent | 4710b2ba873692194c636811ceda398f95e02db2 (diff) |
ipv6: release dst properly in ipip6_tunnel_xmit
if a dst is not attached to anywhere, it should be released before
exit ipip6_tunnel_xmit, otherwise cause dst memory leakage.
Fixes: 61c1db7fae21 ("ipv6: sit: add GSO/TSO support")
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/ipv6/sit.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c index a710fdec42d3..c87482252577 100644 --- a/net/ipv6/sit.c +++ b/net/ipv6/sit.c | |||
@@ -966,8 +966,10 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *skb, | |||
966 | tos = INET_ECN_encapsulate(tos, ipv6_get_dsfield(iph6)); | 966 | tos = INET_ECN_encapsulate(tos, ipv6_get_dsfield(iph6)); |
967 | 967 | ||
968 | skb = iptunnel_handle_offloads(skb, false, SKB_GSO_SIT); | 968 | skb = iptunnel_handle_offloads(skb, false, SKB_GSO_SIT); |
969 | if (IS_ERR(skb)) | 969 | if (IS_ERR(skb)) { |
970 | ip_rt_put(rt); | ||
970 | goto out; | 971 | goto out; |
972 | } | ||
971 | 973 | ||
972 | err = iptunnel_xmit(rt, skb, fl4.saddr, fl4.daddr, IPPROTO_IPV6, tos, | 974 | err = iptunnel_xmit(rt, skb, fl4.saddr, fl4.daddr, IPPROTO_IPV6, tos, |
973 | ttl, df, !net_eq(tunnel->net, dev_net(dev))); | 975 | ttl, df, !net_eq(tunnel->net, dev_net(dev))); |