diff options
| author | Jesse Brandeburg <jesse.brandeburg@intel.com> | 2014-02-11 03:24:13 -0500 |
|---|---|---|
| committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2014-03-14 19:29:16 -0400 |
| commit | 69bfb110fd58185df99a7dbe92a14c0d7ada764f (patch) | |
| tree | 92919ff64ce875b2618607f05e2bd01a3cea1273 | |
| parent | f29eaa3d08d4f0740256253cc6f5d6c7486a3c17 (diff) | |
i40e: cleanup strings
This patch cleans up the strings that the driver prints during normal
operation and moves many strings into dev_dbg. It also cleans up
strings printed during reset.
Change-ID: I1835cc4e3c3b22596182b683284e6bb87eac61b2
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Catherine Sullivan <catherine.sullivan@intel.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
| -rw-r--r-- | drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 8 | ||||
| -rw-r--r-- | drivers/net/ethernet/intel/i40e/i40e_main.c | 47 |
2 files changed, 24 insertions, 31 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c index 57fc86496f30..47b9754d1e8e 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c +++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c | |||
| @@ -1467,19 +1467,19 @@ static ssize_t i40e_dbg_command_write(struct file *filp, | |||
| 1467 | pf->msg_enable); | 1467 | pf->msg_enable); |
| 1468 | } | 1468 | } |
| 1469 | } else if (strncmp(cmd_buf, "pfr", 3) == 0) { | 1469 | } else if (strncmp(cmd_buf, "pfr", 3) == 0) { |
| 1470 | dev_info(&pf->pdev->dev, "forcing PFR\n"); | 1470 | dev_info(&pf->pdev->dev, "debugfs: forcing PFR\n"); |
| 1471 | i40e_do_reset_safe(pf, (1 << __I40E_PF_RESET_REQUESTED)); | 1471 | i40e_do_reset_safe(pf, (1 << __I40E_PF_RESET_REQUESTED)); |
| 1472 | 1472 | ||
| 1473 | } else if (strncmp(cmd_buf, "corer", 5) == 0) { | 1473 | } else if (strncmp(cmd_buf, "corer", 5) == 0) { |
| 1474 | dev_info(&pf->pdev->dev, "forcing CoreR\n"); | 1474 | dev_info(&pf->pdev->dev, "debugfs: forcing CoreR\n"); |
| 1475 | i40e_do_reset_safe(pf, (1 << __I40E_CORE_RESET_REQUESTED)); | 1475 | i40e_do_reset_safe(pf, (1 << __I40E_CORE_RESET_REQUESTED)); |
| 1476 | 1476 | ||
| 1477 | } else if (strncmp(cmd_buf, "globr", 5) == 0) { | 1477 | } else if (strncmp(cmd_buf, "globr", 5) == 0) { |
| 1478 | dev_info(&pf->pdev->dev, "forcing GlobR\n"); | 1478 | dev_info(&pf->pdev->dev, "debugfs: forcing GlobR\n"); |
| 1479 | i40e_do_reset_safe(pf, (1 << __I40E_GLOBAL_RESET_REQUESTED)); | 1479 | i40e_do_reset_safe(pf, (1 << __I40E_GLOBAL_RESET_REQUESTED)); |
| 1480 | 1480 | ||
| 1481 | } else if (strncmp(cmd_buf, "empr", 4) == 0) { | 1481 | } else if (strncmp(cmd_buf, "empr", 4) == 0) { |
| 1482 | dev_info(&pf->pdev->dev, "forcing EMPR\n"); | 1482 | dev_info(&pf->pdev->dev, "debugfs: forcing EMPR\n"); |
| 1483 | i40e_do_reset_safe(pf, (1 << __I40E_EMP_RESET_REQUESTED)); | 1483 | i40e_do_reset_safe(pf, (1 << __I40E_EMP_RESET_REQUESTED)); |
| 1484 | 1484 | ||
| 1485 | } else if (strncmp(cmd_buf, "read", 4) == 0) { | 1485 | } else if (strncmp(cmd_buf, "read", 4) == 0) { |
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index acf0b20a57bc..f7b1753ac565 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c | |||
| @@ -3755,8 +3755,8 @@ static int i40e_vsi_configure_bw_alloc(struct i40e_vsi *vsi, u8 enabled_tc, | |||
| 3755 | NULL); | 3755 | NULL); |
| 3756 | if (aq_ret) { | 3756 | if (aq_ret) { |
| 3757 | dev_info(&vsi->back->pdev->dev, | 3757 | dev_info(&vsi->back->pdev->dev, |
| 3758 | "%s: AQ command Config VSI BW allocation per TC failed = %d\n", | 3758 | "AQ command Config VSI BW allocation per TC failed = %d\n", |
| 3759 | __func__, vsi->back->hw.aq.asq_last_status); | 3759 | vsi->back->hw.aq.asq_last_status); |
| 3760 | return -EINVAL; | 3760 | return -EINVAL; |
| 3761 | } | 3761 | } |
| 3762 | 3762 | ||
| @@ -4364,7 +4364,7 @@ void i40e_do_reset(struct i40e_pf *pf, u32 reset_flags) | |||
| 4364 | * for the warning interrupt will deal with the shutdown | 4364 | * for the warning interrupt will deal with the shutdown |
| 4365 | * and recovery of the switch setup. | 4365 | * and recovery of the switch setup. |
| 4366 | */ | 4366 | */ |
| 4367 | dev_info(&pf->pdev->dev, "GlobalR requested\n"); | 4367 | dev_dbg(&pf->pdev->dev, "GlobalR requested\n"); |
| 4368 | val = rd32(&pf->hw, I40E_GLGEN_RTRIG); | 4368 | val = rd32(&pf->hw, I40E_GLGEN_RTRIG); |
| 4369 | val |= I40E_GLGEN_RTRIG_GLOBR_MASK; | 4369 | val |= I40E_GLGEN_RTRIG_GLOBR_MASK; |
| 4370 | wr32(&pf->hw, I40E_GLGEN_RTRIG, val); | 4370 | wr32(&pf->hw, I40E_GLGEN_RTRIG, val); |
| @@ -4375,7 +4375,7 @@ void i40e_do_reset(struct i40e_pf *pf, u32 reset_flags) | |||
| 4375 | * | 4375 | * |
| 4376 | * Same as Global Reset, except does *not* include the MAC/PHY | 4376 | * Same as Global Reset, except does *not* include the MAC/PHY |
| 4377 | */ | 4377 | */ |
| 4378 | dev_info(&pf->pdev->dev, "CoreR requested\n"); | 4378 | dev_dbg(&pf->pdev->dev, "CoreR requested\n"); |
| 4379 | val = rd32(&pf->hw, I40E_GLGEN_RTRIG); | 4379 | val = rd32(&pf->hw, I40E_GLGEN_RTRIG); |
| 4380 | val |= I40E_GLGEN_RTRIG_CORER_MASK; | 4380 | val |= I40E_GLGEN_RTRIG_CORER_MASK; |
| 4381 | wr32(&pf->hw, I40E_GLGEN_RTRIG, val); | 4381 | wr32(&pf->hw, I40E_GLGEN_RTRIG, val); |
| @@ -4409,7 +4409,7 @@ void i40e_do_reset(struct i40e_pf *pf, u32 reset_flags) | |||
| 4409 | * the switch, since we need to do all the recovery as | 4409 | * the switch, since we need to do all the recovery as |
| 4410 | * for the Core Reset. | 4410 | * for the Core Reset. |
| 4411 | */ | 4411 | */ |
| 4412 | dev_info(&pf->pdev->dev, "PFR requested\n"); | 4412 | dev_dbg(&pf->pdev->dev, "PFR requested\n"); |
| 4413 | i40e_handle_reset_warning(pf); | 4413 | i40e_handle_reset_warning(pf); |
| 4414 | 4414 | ||
| 4415 | } else if (reset_flags & (1 << __I40E_REINIT_REQUESTED)) { | 4415 | } else if (reset_flags & (1 << __I40E_REINIT_REQUESTED)) { |
| @@ -4458,18 +4458,18 @@ bool i40e_dcb_need_reconfig(struct i40e_pf *pf, | |||
| 4458 | &old_cfg->etscfg.prioritytable, | 4458 | &old_cfg->etscfg.prioritytable, |
| 4459 | sizeof(new_cfg->etscfg.prioritytable))) { | 4459 | sizeof(new_cfg->etscfg.prioritytable))) { |
| 4460 | need_reconfig = true; | 4460 | need_reconfig = true; |
| 4461 | dev_info(&pf->pdev->dev, "ETS UP2TC changed.\n"); | 4461 | dev_dbg(&pf->pdev->dev, "ETS UP2TC changed.\n"); |
| 4462 | } | 4462 | } |
| 4463 | 4463 | ||
| 4464 | if (memcmp(&new_cfg->etscfg.tcbwtable, | 4464 | if (memcmp(&new_cfg->etscfg.tcbwtable, |
| 4465 | &old_cfg->etscfg.tcbwtable, | 4465 | &old_cfg->etscfg.tcbwtable, |
| 4466 | sizeof(new_cfg->etscfg.tcbwtable))) | 4466 | sizeof(new_cfg->etscfg.tcbwtable))) |
| 4467 | dev_info(&pf->pdev->dev, "ETS TC BW Table changed.\n"); | 4467 | dev_dbg(&pf->pdev->dev, "ETS TC BW Table changed.\n"); |
| 4468 | 4468 | ||
| 4469 | if (memcmp(&new_cfg->etscfg.tsatable, | 4469 | if (memcmp(&new_cfg->etscfg.tsatable, |
| 4470 | &old_cfg->etscfg.tsatable, | 4470 | &old_cfg->etscfg.tsatable, |
| 4471 | sizeof(new_cfg->etscfg.tsatable))) | 4471 | sizeof(new_cfg->etscfg.tsatable))) |
| 4472 | dev_info(&pf->pdev->dev, "ETS TSA Table changed.\n"); | 4472 | dev_dbg(&pf->pdev->dev, "ETS TSA Table changed.\n"); |
| 4473 | } | 4473 | } |
| 4474 | 4474 | ||
| 4475 | /* Check if PFC configuration has changed */ | 4475 | /* Check if PFC configuration has changed */ |
| @@ -4477,7 +4477,7 @@ bool i40e_dcb_need_reconfig(struct i40e_pf *pf, | |||
| 4477 | &old_cfg->pfc, | 4477 | &old_cfg->pfc, |
| 4478 | sizeof(new_cfg->pfc))) { | 4478 | sizeof(new_cfg->pfc))) { |
| 4479 | need_reconfig = true; | 4479 | need_reconfig = true; |
| 4480 | dev_info(&pf->pdev->dev, "PFC config change detected.\n"); | 4480 | dev_dbg(&pf->pdev->dev, "PFC config change detected.\n"); |
| 4481 | } | 4481 | } |
| 4482 | 4482 | ||
| 4483 | /* Check if APP Table has changed */ | 4483 | /* Check if APP Table has changed */ |
| @@ -4485,7 +4485,7 @@ bool i40e_dcb_need_reconfig(struct i40e_pf *pf, | |||
| 4485 | &old_cfg->app, | 4485 | &old_cfg->app, |
| 4486 | sizeof(new_cfg->app))) { | 4486 | sizeof(new_cfg->app))) { |
| 4487 | need_reconfig = true; | 4487 | need_reconfig = true; |
| 4488 | dev_info(&pf->pdev->dev, "APP Table change detected.\n"); | 4488 | dev_dbg(&pf->pdev->dev, "APP Table change detected.\n"); |
| 4489 | } | 4489 | } |
| 4490 | 4490 | ||
| 4491 | return need_reconfig; | 4491 | return need_reconfig; |
| @@ -4535,7 +4535,7 @@ static int i40e_handle_lldp_event(struct i40e_pf *pf, | |||
| 4535 | 4535 | ||
| 4536 | /* No change detected in DCBX configs */ | 4536 | /* No change detected in DCBX configs */ |
| 4537 | if (!memcmp(&tmp_dcbx_cfg, dcbx_cfg, sizeof(tmp_dcbx_cfg))) { | 4537 | if (!memcmp(&tmp_dcbx_cfg, dcbx_cfg, sizeof(tmp_dcbx_cfg))) { |
| 4538 | dev_info(&pf->pdev->dev, "No change detected in DCBX configuration.\n"); | 4538 | dev_dbg(&pf->pdev->dev, "No change detected in DCBX configuration.\n"); |
| 4539 | goto exit; | 4539 | goto exit; |
| 4540 | } | 4540 | } |
| 4541 | 4541 | ||
| @@ -4593,8 +4593,8 @@ static void i40e_handle_lan_overflow_event(struct i40e_pf *pf, | |||
| 4593 | struct i40e_vf *vf; | 4593 | struct i40e_vf *vf; |
| 4594 | u16 vf_id; | 4594 | u16 vf_id; |
| 4595 | 4595 | ||
| 4596 | dev_info(&pf->pdev->dev, "%s: Rx Queue Number = %d QTX_CTL=0x%08x\n", | 4596 | dev_dbg(&pf->pdev->dev, "overflow Rx Queue Number = %d QTX_CTL=0x%08x\n", |
| 4597 | __func__, queue, qtx_ctl); | 4597 | queue, qtx_ctl); |
| 4598 | 4598 | ||
| 4599 | /* Queue belongs to VF, find the VF and issue VF reset */ | 4599 | /* Queue belongs to VF, find the VF and issue VF reset */ |
| 4600 | if (((qtx_ctl & I40E_QTX_CTL_PFVF_Q_MASK) | 4600 | if (((qtx_ctl & I40E_QTX_CTL_PFVF_Q_MASK) |
| @@ -4946,7 +4946,7 @@ static void i40e_clean_adminq_subtask(struct i40e_pf *pf) | |||
| 4946 | event.msg_size); | 4946 | event.msg_size); |
| 4947 | break; | 4947 | break; |
| 4948 | case i40e_aqc_opc_lldp_update_mib: | 4948 | case i40e_aqc_opc_lldp_update_mib: |
| 4949 | dev_info(&pf->pdev->dev, "ARQ: Update LLDP MIB event received\n"); | 4949 | dev_dbg(&pf->pdev->dev, "ARQ: Update LLDP MIB event received\n"); |
| 4950 | #ifdef CONFIG_I40E_DCB | 4950 | #ifdef CONFIG_I40E_DCB |
| 4951 | |||
